mbox series

[GIT,PULL,FOR,5.17] V4L2 patches

Message ID YbdPdh/ivnjZKIOA@valkosipuli.retiisi.eu (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,5.17] V4L2 patches | expand

Pull-request

git://linuxtv.org/sailus/media_tree.git tags/for-5.17-2-signed

Message

Sakari Ailus Dec. 13, 2021, 1:49 p.m. UTC 
Hi Mauro,

Here's a few patches for 5.17. In particular, included are isl79987 driver
from Michale Tretter and Marek Vasut, and a dependency fix for the recently
added max96712 driver.

Please pull.


The following changes since commit 4383cfa18c5bbc5b9b6a9e77adc12aec1c20b72d:

  Merge tag 'v5.16-rc4' into media_tree (2021-12-07 11:29:41 +0100)

are available in the Git repository at:

  git://linuxtv.org/sailus/media_tree.git tags/for-5.17-2-signed

for you to fetch changes up to 0541ae639fb1165fb309ebf58605f901146c2535:

  media: i2c: isl7998x: Add driver for Intersil ISL7998x (2021-12-08 09:51:54 +0200)

----------------------------------------------------------------
V4L2 patches for 5.17

----------------------------------------------------------------
Andy Shevchenko (1):
      media: i2c: max9286: Get rid of duplicate of_node assignment

Marek Vasut (2):
      media: dt-bindings: Add Intersil ISL79987 DT bindings
      media: i2c: isl7998x: Add driver for Intersil ISL7998x

Michael Tretter (1):
      media: imx6-mipi-csi2: use pre_streamon callback to set sensor into LP11

Sakari Ailus (1):
      max96712: Depend on VIDEO_V4L2

 .../bindings/media/i2c/isil,isl79987.yaml          |  113 ++
 MAINTAINERS                                        |    8 +
 drivers/media/i2c/Kconfig                          |   10 +
 drivers/media/i2c/Makefile                         |    1 +
 drivers/media/i2c/isl7998x.c                       | 1543 ++++++++++++++++++++
 drivers/media/i2c/max9286.c                        |    1 -
 drivers/staging/media/imx/imx6-mipi-csi2.c         |    9 +-
 drivers/staging/media/max96712/Kconfig             |    1 +
 include/uapi/linux/v4l2-controls.h                 |    6 +
 9 files changed, 1690 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml
 create mode 100644 drivers/media/i2c/isl7998x.c

Comments

Jenkins Dec. 13, 2021, 2:27 p.m. UTC | #1 
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/YbdPdh/ivnjZKIOA@valkosipuli.retiisi.eu/
Build log: https://builder.linuxtv.org/job/patchwork/165075/
Build time: 00:35:23
Link: https://lore.kernel.org/linux-media/YbdPdh/ivnjZKIOA@valkosipuli.retiisi.eu

gpg: Signature made Mon 13 Dec 2021 12:05:48 PM UTC
gpg:                using DSA key 53AC58A5F5948636C04A1BF8141DFA54A1EC8DEA
gpg:                issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: F0D0 377A 0D4F 25A7 9238  EFE5 6D40 361B 6E28 C193
     Subkey fingerprint: 53AC 58A5 F594 8636 C04A  1BF8 141D FA54 A1EC 8DEA

Summary: got 3/5 patches with issues, being 2 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-max96712-Depend-on-VIDEO_V4L2.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

    allyesconfig: return code #0:
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
	../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
	../drivers/media/i2c/ov8865.c: ../drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn: inconsistent indenting
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2874 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0004-media-dt-bindings-Add-Intersil-ISL79987-DT-bindings.patch:

   checkpatch.pl:
	$ cat patches/0004-media-dt-bindings-Add-Intersil-ISL79987-DT-bindings.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:23: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

patches/0005-media-i2c-isl7998x-Add-driver-for-Intersil-ISL7998x.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ov8865.c: ../drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn: inconsistent indenting
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
	../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2864 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0005-media-i2c-isl7998x-Add-driver-for-Intersil-ISL7998x.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:59: WARNING: please write a paragraph that describes the config symbol fully
	-:879: CHECK: Alignment should match open parenthesis
	-:1165: ERROR: Macros with complex values should be enclosed in parentheses
	-:1165: CHECK: Macro argument reuse 'page' - possible side-effects?
	-:1193: ERROR: Macros with complex values should be enclosed in parentheses
	-:1193: CHECK: Macro argument reuse 'page' - possible side-effects?
	-:1227: ERROR: Macros with complex values should be enclosed in parentheses
	-:1227: CHECK: Macro argument reuse 'page' - possible side-effects?


Error #512 when building PDF docs
Mauro Carvalho Chehab Dec. 14, 2021, 10:21 a.m. UTC | #2 
Hi Sakari,

Em Mon, 13 Dec 2021 15:49:42 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:

> Hi Mauro,
> 
> Here's a few patches for 5.17. In particular, included are isl79987 driver
> from Michale Tretter and Marek Vasut, and a dependency fix for the recently
> added max96712 driver.
> 
> Please pull.
> 
> 
> The following changes since commit 4383cfa18c5bbc5b9b6a9e77adc12aec1c20b72d:
> 
>   Merge tag 'v5.16-rc4' into media_tree (2021-12-07 11:29:41 +0100)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/sailus/media_tree.git tags/for-5.17-2-signed
> 
> for you to fetch changes up to 0541ae639fb1165fb309ebf58605f901146c2535:
> 
>   media: i2c: isl7998x: Add driver for Intersil ISL7998x (2021-12-08 09:51:54 +0200)
> 
> ----------------------------------------------------------------
> V4L2 patches for 5.17
> 
> ----------------------------------------------------------------
> Andy Shevchenko (1):
>       media: i2c: max9286: Get rid of duplicate of_node assignment
> 
> Marek Vasut (2):
>       media: dt-bindings: Add Intersil ISL79987 DT bindings
>       media: i2c: isl7998x: Add driver for Intersil ISL7998x

There are a couple of issues at the STD decoding logic, plus some coding
style issues at the isl7998x driver. So, I'm not applying those two
patches. Those are easily fixable, but we'll be closing the merge window
for 5.17 this week. If it were just the coding styles, I would have just
fixed and applied, but the best here would be for Marek to fix the issues
I point, re-test and submit asap, in order to be on this merge window.

> 
> Michael Tretter (1):
>       media: imx6-mipi-csi2: use pre_streamon callback to set sensor into LP11
> 
> Sakari Ailus (1):
>       max96712: Depend on VIDEO_V4L2
> 
>  .../bindings/media/i2c/isil,isl79987.yaml          |  113 ++
>  MAINTAINERS                                        |    8 +
>  drivers/media/i2c/Kconfig                          |   10 +
>  drivers/media/i2c/Makefile                         |    1 +
>  drivers/media/i2c/isl7998x.c                       | 1543 ++++++++++++++++++++
>  drivers/media/i2c/max9286.c                        |    1 -
>  drivers/staging/media/imx/imx6-mipi-csi2.c         |    9 +-
>  drivers/staging/media/max96712/Kconfig             |    1 +
>  include/uapi/linux/v4l2-controls.h                 |    6 +
>  9 files changed, 1690 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml
>  create mode 100644 drivers/media/i2c/isl7998x.c
> 



Thanks,
Mauro
Sakari Ailus Dec. 14, 2021, 10:33 a.m. UTC | #3 
On Tue, Dec 14, 2021 at 11:21:31AM +0100, Mauro Carvalho Chehab wrote:
> Hi Sakari,
> 
> Em Mon, 13 Dec 2021 15:49:42 +0200
> Sakari Ailus <sakari.ailus@iki.fi> escreveu:
> 
> > Hi Mauro,
> > 
> > Here's a few patches for 5.17. In particular, included are isl79987 driver
> > from Michale Tretter and Marek Vasut, and a dependency fix for the recently
> > added max96712 driver.
> > 
> > Please pull.
> > 
> > 
> > The following changes since commit 4383cfa18c5bbc5b9b6a9e77adc12aec1c20b72d:
> > 
> >   Merge tag 'v5.16-rc4' into media_tree (2021-12-07 11:29:41 +0100)
> > 
> > are available in the Git repository at:
> > 
> >   git://linuxtv.org/sailus/media_tree.git tags/for-5.17-2-signed
> > 
> > for you to fetch changes up to 0541ae639fb1165fb309ebf58605f901146c2535:
> > 
> >   media: i2c: isl7998x: Add driver for Intersil ISL7998x (2021-12-08 09:51:54 +0200)
> > 
> > ----------------------------------------------------------------
> > V4L2 patches for 5.17
> > 
> > ----------------------------------------------------------------
> > Andy Shevchenko (1):
> >       media: i2c: max9286: Get rid of duplicate of_node assignment
> > 
> > Marek Vasut (2):
> >       media: dt-bindings: Add Intersil ISL79987 DT bindings
> >       media: i2c: isl7998x: Add driver for Intersil ISL7998x
> 
> There are a couple of issues at the STD decoding logic, plus some coding
> style issues at the isl7998x driver. So, I'm not applying those two
> patches. Those are easily fixable, but we'll be closing the merge window
> for 5.17 this week. If it were just the coding styles, I would have just
> fixed and applied, but the best here would be for Marek to fix the issues
> I point, re-test and submit asap, in order to be on this merge window.

Ack, I see you've already replied Michael. Thanks.