From patchwork Sun Aug 28 18:00:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 9302881 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0906260757 for ; Sun, 28 Aug 2016 18:01:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3F3F28815 for ; Sun, 28 Aug 2016 18:01:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E837528823; Sun, 28 Aug 2016 18:01:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8126028815 for ; Sun, 28 Aug 2016 18:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755762AbcH1SAm (ORCPT ); Sun, 28 Aug 2016 14:00:42 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36052 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669AbcH1SAl (ORCPT ); Sun, 28 Aug 2016 14:00:41 -0400 Received: from static-50-53-43-78.bvtn.or.frontiernet.net ([50.53.43.78] helo=[192.168.1.13]) by merlin.infradead.org with esmtpsa (Exim 4.85_2 #1 (Red Hat Linux)) id 1be4Nl-0003eR-BO; Sun, 28 Aug 2016 18:00:33 +0000 To: LKML , linux-media From: Randy Dunlap Subject: [PATCH] media: usb: dvb-usb: fix DIBUSB_MB usage of dib3000mc functions Cc: Fengguang Wu , Joe Perches , Mauro Carvalho Chehab , Andrew Morton Message-ID: Date: Sun, 28 Aug 2016 11:00:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap The problem is that this driver uses a "common" driver supplement which calls a few dib3000mc*() functions but that driver is not "select"ed by DVB_USB_DIBUSB_MB. We can fix the build errors by selecting DVB_DIB3000MC (at the expense of around 8 KB on x86_64) just to add a few "library-like" functions. Or someone can split the required functions into a separate buildable file, but for such an ancient driver, I don't see the need to do this. Fixes these build errors: drivers/built-in.o: In function `dibusb_dib3000mc_frontend_attach': (.text+0x1a63bd): undefined reference to `dib3000mc_pid_parse' drivers/built-in.o: In function `dibusb_dib3000mc_frontend_attach': (.text+0x1a63c5): undefined reference to `dib3000mc_pid_control' drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach': (.text+0x1a6610): undefined reference to `dib3000mc_set_config' Signed-off-by: Randy Dunlap Reported-by: Fengguang Wu Cc: Joe Perches Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/usb/dvb-usb/Kconfig | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- lnx-48-rc3.orig/drivers/media/usb/dvb-usb/Kconfig +++ lnx-48-rc3/drivers/media/usb/dvb-usb/Kconfig @@ -34,6 +34,7 @@ config DVB_USB_DIBUSB_MB depends on DVB_USB select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT select DVB_DIB3000MB + select DVB_DIB3000MC select MEDIA_TUNER_MT2060 if MEDIA_SUBDRV_AUTOSELECT help Support for USB 1.1 and 2.0 DVB-T receivers based on reference designs made by