From patchwork Tue Nov 6 10:15:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10670023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 29B5914BD for ; Tue, 6 Nov 2018 10:15:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 194252A2D5 for ; Tue, 6 Nov 2018 10:15:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D4362A2E5; Tue, 6 Nov 2018 10:15:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACB7A2A2D5 for ; Tue, 6 Nov 2018 10:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387760AbeKFTkJ (ORCPT ); Tue, 6 Nov 2018 14:40:09 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:56738 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387480AbeKFTkJ (ORCPT ); Tue, 6 Nov 2018 14:40:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GzWP1nPrFY8wVWLrUSf+jT3r7zYowDDsP2p2hLR6AFA=; b=hsf6ofCD5bOkQaiFlmLZGPn0V kUQ6KNy2rgA1Lr/6R678BAeP9K88OcZACoLMMItxTnHkM39c1EFy31bzIfldZkxnrdrJ+9uSwBGRW KkyBgOJCxlxznV6b+opycDQBX10rbf460nH+KFIeQ+U+eyuvPHhmKF0eSTuMpwsvB7Rn2i/WWnf4f hNn/HF1PTSimLR8pj6fB6+EkSFuVRb/0tElRPBEcEX8kOOjAq2rZ6wbMdKgi7S1ySoKdtV0v62F5m slFKatO+0U/sOG3HIMb0GKNBI5dbrO8ru6uvZXLaA6vxKEpi02zeQckPJ9YafxeeZqSIA7hY3UXz2 irIWw43sw==; Received: from [191.33.155.146] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJyOZ-0001WF-3L; Tue, 06 Nov 2018 10:15:39 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.91) (envelope-from ) id 1gJyOV-0000fB-Q1; Tue, 06 Nov 2018 05:15:35 -0500 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Greg Kroah-Hartman , Kees Cook , Hans Verkuil , devel@driverdev.osuosl.org Subject: [PATCH] davinci_vpfe: add a missing break Date: Tue, 6 Nov 2018 05:15:33 -0500 Message-Id: X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As warned by gcc: drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function 'ipipeif_hw_setup': drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (isif_port_if) { ^~~~~~ drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:314:2: note: here case IPIPEIF_SDRAM_YUV: ^~~~ There is a missing break for the raw format. Signed-off-by: Mauro Carvalho Chehab Nacked-by: Hans Verkuil --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c b/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c index a53231b08d30..975272bcf8ca 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c @@ -310,6 +310,7 @@ static int ipipeif_hw_setup(struct v4l2_subdev *sd) ipipeif_write(val, ipipeif_base_addr, IPIPEIF_CFG2); break; } + break; case IPIPEIF_SDRAM_YUV: /* Set clock divider */