diff mbox series

[GIT,PULL] Linux Media vimc update for Linux 6.15-rc1

Message ID a3344fc3-c7ea-44ae-8fc8-86184315a58f@linuxfoundation.org (mailing list archive)
State New
Headers show
Series [GIT,PULL] Linux Media vimc update for Linux 6.15-rc1 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux tags/linux-vimc-6.15-rc1

Commit Message

Shuah Khan March 6, 2025, 7:46 p.m. UTC
Hi Mauro,

Please pull the following vimc update for Linux 6.15-rc1.

Fixes a bug in vimc streamer pipeline init code found by syzbot.

diff is attached.

thanks,
-- Shuah

----------------------------------------------------------------
The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3:

   Linux 6.14-rc2 (2025-02-09 12:45:03 -0800)

are available in the Git repository at:

   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux tags/linux-vimc-6.15-rc1

for you to fetch changes up to d6813eb9c3de01307801f253d89d777b4669a0d0:

   media: vimc: skip .s_stream() for stopped entities (2025-03-06 09:11:39 -0700)

----------------------------------------------------------------
linux-vimc-6.15-rc1

Fixes a bug in vimc streamer pipeline init code found by syzbot.

----------------------------------------------------------------
Nikita Zhandarovich (1):
       media: vimc: skip .s_stream() for stopped entities

  drivers/media/test-drivers/vimc/vimc-streamer.c | 6 ++++++
  1 file changed, 6 insertions(+)
----------------------------------------------------------------

Comments

Hans Verkuil March 6, 2025, 8:03 p.m. UTC | #1
On 06/03/2025 20:46, Shuah Khan wrote:
> Hi Mauro,
> 
> Please pull the following vimc update for Linux 6.15-rc1.
> 
> Fixes a bug in vimc streamer pipeline init code found by syzbot.

Ah, I merged that vimc fix already, so I'll just mark this PR as Obsoleted.

Regards,

	Hans

> 
> diff is attached.
> 
> thanks,
> -- Shuah
> 
> ----------------------------------------------------------------
> The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3:
> 
>    Linux 6.14-rc2 (2025-02-09 12:45:03 -0800)
> 
> are available in the Git repository at:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux tags/linux-vimc-6.15-rc1
> 
> for you to fetch changes up to d6813eb9c3de01307801f253d89d777b4669a0d0:
> 
>    media: vimc: skip .s_stream() for stopped entities (2025-03-06 09:11:39 -0700)
> 
> ----------------------------------------------------------------
> linux-vimc-6.15-rc1
> 
> Fixes a bug in vimc streamer pipeline init code found by syzbot.
> 
> ----------------------------------------------------------------
> Nikita Zhandarovich (1):
>        media: vimc: skip .s_stream() for stopped entities
> 
>   drivers/media/test-drivers/vimc/vimc-streamer.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> ----------------------------------------------------------------
diff mbox series

Patch

diff --git a/drivers/media/test-drivers/vimc/vimc-streamer.c b/drivers/media/test-drivers/vimc/vimc-streamer.c
index 807551a5143b..15d863f97cbf 100644
--- a/drivers/media/test-drivers/vimc/vimc-streamer.c
+++ b/drivers/media/test-drivers/vimc/vimc-streamer.c
@@ -59,6 +59,12 @@  static void vimc_streamer_pipeline_terminate(struct vimc_stream *stream)
 			continue;
 
 		sd = media_entity_to_v4l2_subdev(ved->ent);
+		/*
+		 * Do not call .s_stream() to stop an already
+		 * stopped/unstarted subdev.
+		 */
+		if (!v4l2_subdev_is_streaming(sd))
+			continue;
 		v4l2_subdev_call(sd, video, s_stream, 0);
 	}
 }