From patchwork Wed Apr 13 08:49:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 8819631 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7E9A79F3A0 for ; Wed, 13 Apr 2016 08:49:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AC05A20272 for ; Wed, 13 Apr 2016 08:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A96CD201FE for ; Wed, 13 Apr 2016 08:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758248AbcDMIta (ORCPT ); Wed, 13 Apr 2016 04:49:30 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:16547 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756983AbcDMIt1 (ORCPT ); Wed, 13 Apr 2016 04:49:27 -0400 X-IronPort-AV: E=Sophos;i="5.24,479,1454972400"; d="scan'208";a="213840454" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Apr 2016 10:49:25 +0200 Date: Wed, 13 Apr 2016 10:49:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Songjun Wu cc: linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , Hans Verkuil , Sudip Mukherjee , Mikhail Ulyanov , Fabien Dessenne , Peter Griffin , Benoit Parrot , Laurent Pinchart , Gerd Hoffmann , =?ISO-8859-15?Q?Richard_R=F6jfors?= , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, kbuild@01.org, g.liakhovetski@gmx.de, nicolas.ferre@atmel.com Subject: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and ISC_DCTRL_IE_IS right together. atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0); - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview); + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS); regmap_write(regmap, ISC_DAD0, addr); regmap_update_bits(regmap, ISC_CTRLEN, ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);