From patchwork Sun Jan  2 19:14:03 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jesper Juhl <jj@chaosbits.net>
X-Patchwork-Id: 446481
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p02JEOg6005144
	for <patchwork-media@patchwork.kernel.org>;
	Sun, 2 Jan 2011 19:14:25 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751348Ab1ABTOG (ORCPT
	<rfc822;patchwork-media@patchwork.kernel.org>);
	Sun, 2 Jan 2011 14:14:06 -0500
Received: from swampdragon.chaosbits.net ([90.184.90.115]:29620 "EHLO
	swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by
	vger.kernel.org with ESMTP id S1751192Ab1ABTOE (ORCPT
	<rfc822; linux-media@vger.kernel.org>); Sun, 2 Jan 2011 14:14:04 -0500
Received: by swampdragon.chaosbits.net (Postfix, from userid 1000)
	id 8A7BB9403D; Sun,  2 Jan 2011 20:14:03 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by swampdragon.chaosbits.net (Postfix) with ESMTP id 7CF159403B;
	Sun,  2 Jan 2011 20:14:03 +0100 (CET)
Date: Sun, 2 Jan 2011 20:14:03 +0100 (CET)
From: Jesper Juhl <jj@chaosbits.net>
To: Malcolm Priestley <tvboxspy@gmail.com>
cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATVH] media, dvb, IX2505V: Remember to free allocated memory
	in failure path (ix2505v_attach()).
In-Reply-To: <alpine.LNX.2.00.1101021948100.11481@swampdragon.chaosbits.net>
Message-ID: <alpine.LNX.2.00.1101022012520.11481@swampdragon.chaosbits.net>
References: <alpine.LNX.2.00.1012310008070.32595@swampdragon.chaosbits.net>
	<1293758374.10326.7.camel@tvboxspy>
	<alpine.LNX.2.00.1012311541430.16655@swampdragon.chaosbits.net>
	<1293820435.29966.59.camel@tvboxspy>
	<alpine.LNX.2.00.1101021948100.11481@swampdragon.chaosbits.net>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]);
	Sun, 02 Jan 2011 19:14:25 +0000 (UTC)


diff --git a/drivers/media/dvb/frontends/ix2505v.c b/drivers/media/dvb/frontends/ix2505v.c
index 55f2eba..846ffd3 100644
--- a/drivers/media/dvb/frontends/ix2505v.c
+++ b/drivers/media/dvb/frontends/ix2505v.c
@@ -311,7 +311,7 @@ struct dvb_frontend *ix2505v_attach(struct dvb_frontend *fe,
 	return fe;
 
 error:
-	ix2505v_release(fe);
+	kfree(state);
 	return NULL;
 }
 EXPORT_SYMBOL(ix2505v_attach);