From patchwork Thu Jan 13 22:05:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 476821 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0DM5q34011784 for ; Thu, 13 Jan 2011 22:05:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757044Ab1AMWFt (ORCPT ); Thu, 13 Jan 2011 17:05:49 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:26744 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941Ab1AMWFs (ORCPT ); Thu, 13 Jan 2011 17:05:48 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 817039403F; Thu, 13 Jan 2011 23:05:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 7F4909403B; Thu, 13 Jan 2011 23:05:47 +0100 (CET) Date: Thu, 13 Jan 2011 23:05:47 +0100 (CET) From: Jesper Juhl To: linux-media@vger.kernel.org cc: linux-kernel@vger.kernel.org, Jean-Francois Moine , Mauro Carvalho Chehab , Hans de Goede , Lee Jones Subject: [PATCH][rfc] media, video, stv06xx, pb0100: Don't potentially deref NULL in pb0100_start(). Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 13 Jan 2011 22:05:52 +0000 (UTC) diff --git a/drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c b/drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c index ac47b4c..75a5b9c 100644 --- a/drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c +++ b/drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c @@ -217,6 +217,8 @@ static int pb0100_start(struct sd *sd) intf = usb_ifnum_to_if(sd->gspca_dev.dev, sd->gspca_dev.iface); alt = usb_altnum_to_altsetting(intf, sd->gspca_dev.alt); + if (!alt) + return -ENODEV; packet_size = le16_to_cpu(alt->endpoint[0].desc.wMaxPacketSize); /* If we don't have enough bandwidth use a lower framerate */