From patchwork Thu Apr 7 19:46:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 693401 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p388EDrS003611 for ; Fri, 8 Apr 2011 08:14:22 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756722Ab1DGTqL (ORCPT ); Thu, 7 Apr 2011 15:46:11 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:13443 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756565Ab1DGTqK (ORCPT ); Thu, 7 Apr 2011 15:46:10 -0400 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 0D8879403E; Thu, 7 Apr 2011 21:46:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 068EB9403B; Thu, 7 Apr 2011 21:46:28 +0200 (CEST) Date: Thu, 7 Apr 2011 21:46:27 +0200 (CEST) From: Jesper Juhl To: Mauro Carvalho Chehab cc: Malcolm Priestley , =?ISO-8859-15?Q?David_H=E4rdeman?= , Jarod Wilson , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch() Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 08 Apr 2011 08:14:22 +0000 (UTC) Don't leak 'fw' in drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to call release_firmware(). Signed-off-by: Jesper Juhl --- lmedm04.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) compile tested only diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c index cd26e7c..d7cc625 100644 --- a/drivers/media/dvb/dvb-usb/lmedm04.c +++ b/drivers/media/dvb/dvb-usb/lmedm04.c @@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) if (cold) { info("FRM Changing to %s firmware", fw_lme); lme_coldreset(udev); - return -ENODEV; + ret = -ENODEV; } release_firmware(fw);