From patchwork Fri Jun 29 09:40:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 10496025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ADCE96022E for ; Fri, 29 Jun 2018 09:46:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D085C29889 for ; Fri, 29 Jun 2018 09:46:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4DA7298A6; Fri, 29 Jun 2018 09:46:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C75129889 for ; Fri, 29 Jun 2018 09:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754648AbeF2Jkv (ORCPT ); Fri, 29 Jun 2018 05:40:51 -0400 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:57399 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933534AbeF2Jkr (ORCPT ); Fri, 29 Jun 2018 05:40:47 -0400 Received: from [IPv6:2001:420:44c1:2579:7a24:afff:fed9:e375] ([IPv6:2001:420:44c1:2579:7a24:afff:fed9:e375]) by smtp-cloud9.xs4all.net with ESMTPA id YptRfaUd3EJtcYptVfkzMN; Fri, 29 Jun 2018 11:40:45 +0200 To: Linux Media Mailing List Cc: Hugues FRUCHET From: Hans Verkuil Subject: [PATCH] vivid: fix gain when autogain is on Message-ID: Date: Fri, 29 Jun 2018 11:40:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-US X-CMAE-Envelope: MS4wfAartVn+lS4ZNIXJiTptir3hz4ALECkoAsuYDZlKuKHu4/zJbtru6Dph1KrTuAN8cp2L36zU5TuP+yBITtfzFlrdf0RD3vk98nQejqitgYdZkROKVDIn MkWqcJcdQ/HuL0Cgd8GrGceyY49Dzz/vgzp4d1dOp7XQoGJpOZZFBK4i5d94VPvbB7YXSU63cuz6gIr2iO18AKcj3jTzPYtFb8hotiRhppalDB5ja0SPONVS lkKwc8Xcdx7tH4N9oz+EAzFTr/BSMgTtvny5GwrhksHv8d0MH9lVr8Hy9M/WeRxi5KxlFQXLoewxV2t+4d8CpZO2tDFMOfczR88VDVsM3P8= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the vivid driver you want gain to continuous change while autogain is on. However, dev->jiffies_vid_cap doesn't actually change. It probably did in the past, but changes in the code caused this to be a fixed value that is only set when you start streaming. Replace it by jiffies, which is always changing. Signed-off-by: Hans Verkuil diff --git a/drivers/media/platform/vivid/vivid-ctrls.c b/drivers/media/platform/vivid/vivid-ctrls.c index 6b0bfa091592..6eb8ad7fb12c 100644 --- a/drivers/media/platform/vivid/vivid-ctrls.c +++ b/drivers/media/platform/vivid/vivid-ctrls.c @@ -295,7 +295,7 @@ static int vivid_user_vid_g_volatile_ctrl(struct v4l2_ctrl *ctrl) switch (ctrl->id) { case V4L2_CID_AUTOGAIN: - dev->gain->val = dev->jiffies_vid_cap & 0xff; + dev->gain->val = (jiffies / HZ) & 0xff; break; } return 0;