| Message ID | b7ed68fff22e3ce5a6c635099ed5662c6dd7c1a5.1511982439.git.mchehab@s-opensource.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 29 Nov 2017, Mauro Carvalho Chehab wrote: > Remove this warning: > drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand * @icd - soc-camera device > on line 309 - I thought it was a doc line > > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Thanks Guennadi > --- > drivers/media/platform/soc_camera/soc_scale_crop.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/soc_camera/soc_scale_crop.c b/drivers/media/platform/soc_camera/soc_scale_crop.c > index 0116097c0c0f..270ec613c27c 100644 > --- a/drivers/media/platform/soc_camera/soc_scale_crop.c > +++ b/drivers/media/platform/soc_camera/soc_scale_crop.c > @@ -306,16 +306,17 @@ static int client_set_fmt(struct soc_camera_device *icd, > } > > /** > - * @icd - soc-camera device > - * @rect - camera cropping window > - * @subrect - part of rect, sent to the user > - * @mf - in- / output camera output window > - * @width - on input: max host input width > - * on output: user width, mapped back to input > - * @height - on input: max host input height > - * on output: user height, mapped back to input > - * @host_can_scale - host can scale this pixel format > - * @shift - shift, used for scaling > + * soc_camera_client_scale > + * @icd: soc-camera device > + * @rect: camera cropping window > + * @subrect: part of rect, sent to the user > + * @mf: in- / output camera output window > + * @width: on input: max host input width; > + * on output: user width, mapped back to input > + * @height: on input: max host input height; > + * on output: user height, mapped back to input > + * @host_can_scale: host can scale this pixel format > + * @shift: shift, used for scaling > */ > int soc_camera_client_scale(struct soc_camera_device *icd, > struct v4l2_rect *rect, struct v4l2_rect *subrect, > -- > 2.14.3 >
diff --git a/drivers/media/platform/soc_camera/soc_scale_crop.c b/drivers/media/platform/soc_camera/soc_scale_crop.c index 0116097c0c0f..270ec613c27c 100644 --- a/drivers/media/platform/soc_camera/soc_scale_crop.c +++ b/drivers/media/platform/soc_camera/soc_scale_crop.c @@ -306,16 +306,17 @@ static int client_set_fmt(struct soc_camera_device *icd, } /** - * @icd - soc-camera device - * @rect - camera cropping window - * @subrect - part of rect, sent to the user - * @mf - in- / output camera output window - * @width - on input: max host input width - * on output: user width, mapped back to input - * @height - on input: max host input height - * on output: user height, mapped back to input - * @host_can_scale - host can scale this pixel format - * @shift - shift, used for scaling + * soc_camera_client_scale + * @icd: soc-camera device + * @rect: camera cropping window + * @subrect: part of rect, sent to the user + * @mf: in- / output camera output window + * @width: on input: max host input width; + * on output: user width, mapped back to input + * @height: on input: max host input height; + * on output: user height, mapped back to input + * @host_can_scale: host can scale this pixel format + * @shift: shift, used for scaling */ int soc_camera_client_scale(struct soc_camera_device *icd, struct v4l2_rect *rect, struct v4l2_rect *subrect,
Remove this warning: drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand * @icd - soc-camera device on line 309 - I thought it was a doc line Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> --- drivers/media/platform/soc_camera/soc_scale_crop.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)