From patchwork Wed Jul 6 21:25:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9217067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6D7D66048B for ; Wed, 6 Jul 2016 21:27:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EBCC28496 for ; Wed, 6 Jul 2016 21:27:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 536F128498; Wed, 6 Jul 2016 21:27:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 97C5628496 for ; Wed, 6 Jul 2016 21:27:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755822AbcGFV1M (ORCPT ); Wed, 6 Jul 2016 17:27:12 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34735 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755769AbcGFV1L (ORCPT ); Wed, 6 Jul 2016 17:27:11 -0400 Received: by mail-wm0-f68.google.com with SMTP id 187so1436323wmz.1 for ; Wed, 06 Jul 2016 14:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=k2zHLUVI1DuE72pBr+ci90MSRp1rBNJwi6PG3gfnyz0=; b=g9+iCRbXJOuZ8i3ePgs+L7AeR4zD0eI1Jkx3HUB6NTb7IzcNYsvPn+5nmSHMeyVNcS hNTG/E9IV5+rdXW6RlIumPt7O4f2svz3PSmS8kOF7XTTFVV3zHxbuk35dM9FUmt0HhOQ rYTCBUf0Ls9PXsExVw0bsn3gc/o8FqRgx3Vi3krUkvqvpvd4vVIVpo7C996G1PCkddgk Zl3ZmbV4duX2Bph2RvCFRiNhtVZYEzRevsRbK0zTEU9+WP1ECFwSal+aZD321XeF+4+w KgwS8TgSc6AYJolZnDwfFBd3eHHqMGp9Omg6peswqrSvdJS0Km59Vg9gKsC2InULlgJ2 mfcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=k2zHLUVI1DuE72pBr+ci90MSRp1rBNJwi6PG3gfnyz0=; b=PrRryZm+plehdBRxb4O6bB20WYtNVUo0BVOW6mP57w1RdkLHpje2RYD+iR2X5I7W7i OcrFuUcfFA6s384HJlKCK8K/z3cEewlD9vWpv7JtLFMPLdFOfRR9RAE2tRNPW/SRnp6A psoaLbT0iPn8vMT/xa62NKAYWbIRVZFFA3+d6ndAYIsTbVCxFgp9p6jWX+BUZzRE0+oq OCtATepqoRETQ2BiKyrbaY90AcvRGYECNyxPpUurUf5btRZrQ2boQ7+0yRXJjXz5Eeko TZcwcceSQAjmlahW85+BoSygnYcZQwF/8aAej7w55pNp6tZs+COEoINzcWoT+MM3D2CR LS1g== X-Gm-Message-State: ALyK8tKeWeNa5M1aMG7hgZVWAF2laoMe2t/UaD/6PoK98GpR7lMa6Kv8Q35cBbF5IXb82Q== X-Received: by 10.28.168.86 with SMTP id r83mr22183313wme.44.1467840429996; Wed, 06 Jul 2016 14:27:09 -0700 (PDT) Received: from ?IPv6:2003:62:5f01:4400:c42:27b6:7227:6e54? (p200300625F0144000C4227B672276E54.dip0.t-ipconnect.de. [2003:62:5f01:4400:c42:27b6:7227:6e54]) by smtp.googlemail.com with ESMTPSA id f140sm5459460wmf.22.2016.07.06.14.27.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 14:27:09 -0700 (PDT) Subject: Re: Recent nuvoton-cir changes introduce a hang with nct6775 To: =?UTF-8?B?QW50dGkgU2VwcMOkbMOk?= References: Cc: linux-media@vger.kernel.org From: Heiner Kallweit Message-ID: Date: Wed, 6 Jul 2016 23:25:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Am 06.07.2016 um 08:51 schrieb Antti Seppälä: > Hello. > > I recently updated my kernel to a newer version but couldn't boot it > because it hangs. > > It turns out that your patch[1] to nuvoton-cir has really bad > side-effects when it interacts with nct6775 module. It could be that > one of the devices never frees the request_muxed_region which causes > the other module to wait indefinitely. > > Reverting the patch or preventing nct6775 module from loading makes > the issue go away. > > Other people have run into this issue too[2]. > > This is a regression and should be fixed. > Could you look into it and maybe submit a follow-up patch to fix this > or shall I perhaps ask for a revert of the troublesome commit? > > > [1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/media/rc/nuvoton-cir.c?id=3def9ad6d3066e597d0ce86801a81eedb130b04a > > [2]: https://bbs.archlinux.org/viewtopic.php?id=213647 > > > Regards, > Thanks for reporting. Indeed there may be an issue with systems using the alternative EFM IO address of the Nuvoton chip. Therefore it doesn't occur on all systems with this chip and then only if the nct6775 driver is loaded after the nuvoton-cir driver. Could you please check whether the following patch fixes the issue for you? --- 2.9.0 Regards, Heiner -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c index 99b303b..e8ceb0e 100644 --- a/drivers/media/rc/nuvoton-cir.c +++ b/drivers/media/rc/nuvoton-cir.c @@ -401,6 +401,7 @@ static int nvt_hw_detect(struct nvt_dev *nvt) /* Check if we're wired for the alternate EFER setup */ nvt->chip_major = nvt_cr_read(nvt, CR_CHIP_ID_HI); if (nvt->chip_major == 0xff) { + nvt_efm_disable(nvt); nvt->cr_efir = CR_EFIR2; nvt->cr_efdr = CR_EFDR2; nvt_efm_enable(nvt);