mbox series

[GIT,PULL] media: atomisp: Changes for 6.4-1

Message ID bf274a09-a823-c547-4284-603e8c6da794@redhat.com (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] media: atomisp: Changes for 6.4-1 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git tags/media-atomisp-6.4-1

Message

Hans de Goede April 9, 2023, 1:11 p.m. UTC
Hi Mauro,

Here are all my atomisp changes for 6.4 + a couple of atomisp patches
from others.

These patches have been posted on the list and I have addressed
all review remarks to these patches.

Highlights:
- Remove depth-mode support
- Remove continuous mode support
- Remove support for streaming from 2 sensors at once
- Add v4l2_get_acpi_sensor_info() helper to get GPIO info from ACPI _DSM
- gc0310 sensor driver:
 - Significant rework / modernization
 - Move to runtime-pm
 - Drop custom atomisp_gmin_platform regulator/clk poking code,
   replacing it with using ACPI to do the pm for us

Regards,

Hans


The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:

  media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git tags/media-atomisp-6.4-1

for you to fetch changes up to df852cfd8802302abf43264fde6a4c9757e26e69:

  media: atomisp: gmin_platform: Add Lenovo Ideapad Miix 310 gmin_vars (2023-04-09 15:01:32 +0200)

----------------------------------------------------------------
atomisp staging driver changes for 6.4

Highlights:
- Remove depth-mode support
- Remove continuous mode support
- Remove support for streaming from 2 sensors at once
- Add v4l2_get_acpi_sensor_info() helper to get GPIO info from ACPI _DSM
- gc0310 sensor driver:
 - Significant rework / modernization
 - Move to runtime-pm
 - Drop custom atomisp_gmin_platform regulator/clk poking code,
   replacing it with using ACPI to do the pm for us

----------------------------------------------------------------
Hans de Goede (38):
      media: atomisp: Remove depth-mode support
      media: atomisp: Remove continuous mode support
      media: atomisp: Remove delayed_init related code
      media: atomisp: Remove crop_needs_override from atomisp_set_fmt()
      media: atomisp: Remove atomisp_css_enable_raw_binning()
      media: atomisp: Remove atomisp_get_metadata_type()
      media: atomisp: Remove unused SOC_CAMERA, XENON_FLASH and FILE_INPUT subdev types
      media: atomisp: Remove ATOMISP_USE_YUVPP()
      media: atomisp: Remove yuvpp_mode
      media: atomisp: Remove online_process setting
      media: atomisp: Add v4l2_get_acpi_sensor_info() helper
      media: atomisp: ov2680: Use v4l2_get_acpi_sensor_info() for the GPIO lookups
      media: atomisp: ov2680: Error handling fixes
      media: atomisp: gc0310: Remove some unused structure definitions
      media: atomisp: gc0310: Remove GC0310_TOK_*
      media: atomisp: gc0310: Simplify gc0310_write_reg_array()
      media: atomisp: gc0310: Remove enum gc0310_tok_type
      media: atomisp: gc0310: Replace custom reg access functions with smbus helpers
      media: atomisp: gc0310: Remove non working flip-controls
      media: atomisp: gc0310: Remove read-only exposure control
      media: atomisp: gc0310: Drop custom ATOMISP_IOC_S_EXPOSURE support
      media: atomisp: gc0310: Add exposure and gain controls
      media: atomisp: gc0310: Add error_unlock label to s_stream()
      media: atomisp: gc0310: Modernize and simply set_fmt(), get_fmt(), etc.
      media: atomisp: gc0310: Delay power-on till streaming is started
      media: atomisp: gc0310: Add runtime-pm support
      media: atomisp: gc0310: Use devm_kzalloc() for data struct
      media: atomisp: gc0310: Switch over to ACPI powermanagement
      media: atomisp: Remove duplicate atomisp_[start|stop]_streaming() prototypes
      media: atomisp: Remove continuous mode related code from atomisp_set_fmt()
      media: atomisp: Remove custom V4L2_CID_FMT_AUTO control
      media: atomisp: Remove snr_mbus_fmt local var from atomisp_try_fmt()
      media: atomisp: Remove unused ATOM_ISP_MAX_WIDTH_TMP and ATOM_ISP_MAX_HEIGHT_TMP
      media: atomisp: Remove atomisp_try_fmt() call from atomisp_set_fmt()
      media: atomisp: Drop support for streaming from 2 sensors at once
      media: atomisp: Remove struct atomisp_sub_device index field
      media: atomisp: gmin_platform: Make DMI quirks take precedence over the _DSM table
      media: atomisp: gmin_platform: Add Lenovo Ideapad Miix 310 gmin_vars

Tsuchiya Yuto (1):
      media: atomisp: Remove remaining instance of call to trace_printk

 drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 1003 ++++--------------
 drivers/staging/media/atomisp/i2c/atomisp-ov2680.c |   33 +-
 drivers/staging/media/atomisp/i2c/gc0310.h         |  416 +++-----
 drivers/staging/media/atomisp/i2c/ov2680.h         |    1 -
 .../staging/media/atomisp/include/linux/atomisp.h  |   28 -
 .../media/atomisp/include/linux/atomisp_platform.h |   11 +-
 drivers/staging/media/atomisp/pci/atomisp_cmd.c    | 1070 +++-----------------
 drivers/staging/media/atomisp/pci/atomisp_cmd.h    |    9 -
 drivers/staging/media/atomisp/pci/atomisp_compat.h |   11 +-
 .../media/atomisp/pci/atomisp_compat_css20.c       |  420 ++------
 drivers/staging/media/atomisp/pci/atomisp_fops.c   |  119 +--
 .../media/atomisp/pci/atomisp_gmin_platform.c      |  289 +++++-
 .../staging/media/atomisp/pci/atomisp_internal.h   |   41 +-
 drivers/staging/media/atomisp/pci/atomisp_ioctl.c  |  226 +----
 drivers/staging/media/atomisp/pci/atomisp_ioctl.h  |    6 -
 drivers/staging/media/atomisp/pci/atomisp_subdev.c |  189 +---
 drivers/staging/media/atomisp/pci/atomisp_subdev.h |   22 -
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c   |   75 +-
 18 files changed, 953 insertions(+), 3016 deletions(-)

Comments

Jenkins April 9, 2023, 2:10 p.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/bf274a09-a823-c547-4284-603e8c6da794@redhat.com/
Build log: https://builder.linuxtv.org/job/patchwork/296238/
Build time: 00:52:43
Link: https://lore.kernel.org/linux-media/bf274a09-a823-c547-4284-603e8c6da794@redhat.com

gpg: Signature made Sun 09 Apr 2023 01:06:41 PM UTC
gpg:                using RSA key BAF03B5D2718411A5E9E177E92EC4779440327DC
gpg:                issuer "hdegoede@redhat.com"
gpg: Good signature from "Hans de Goede <hdegoede@redhat.com>" [expired]
gpg: Note: This key has expired!
Primary key fingerprint: A1EA 0673 EAD8 B74F 17D2  B9E1 7C31 E21A 98D2 1E0D
     Subkey fingerprint: BAF0 3B5D 2718 411A 5E9E  177E 92EC 4779 4403 27DC

Summary: got 27/39 patches with issues, being 26 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-atomisp-Remove-depth-mode-support.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3335 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3434 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2490 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000016Kb sm_state_count = 1974630
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy.  No more merges.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 57 seconds
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting

patches/0002-media-atomisp-Remove-continuous-mode-support.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3139 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3238 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0003-media-atomisp-Remove-delayed_init-related-code.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3104 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3203 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0004-media-atomisp-Remove-crop_needs_override-from-atomis.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3104 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3203 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0005-media-atomisp-Remove-atomisp_css_enable_raw_binning.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3104 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3203 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0006-media-atomisp-Remove-atomisp_get_metadata_type.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3097 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3196 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0007-media-atomisp-Remove-unused-SOC_CAMERA-XENON_FLASH-a.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3095 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3194 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0008-media-atomisp-Remove-ATOMISP_USE_YUVPP.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3090 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3189 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0009-media-atomisp-Remove-yuvpp_mode.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3090 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3189 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0010-media-atomisp-Remove-online_process-setting.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0011-media-atomisp-Remove-remaining-instance-of-call-to-t.patch:

   checkpatch.pl:
	$ cat patches/0011-media-atomisp-Remove-remaining-instance-of-call-to-t.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:7: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)

patches/0012-media-atomisp-Add-v4l2_get_acpi_sensor_info-helper.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0013-media-atomisp-ov2680-Use-v4l2_get_acpi_sensor_info-f.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:416 ov2680_s_stream() warn: missing error code 'ret'

patches/0014-media-atomisp-ov2680-Error-handling-fixes.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:416 ov2680_s_stream() warn: missing error code 'ret'

patches/0021-media-atomisp-gc0310-Remove-read-only-exposure-contr.patch:

    allyesconfig: return code #512:
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:169:35: error: ‘ctrl_ops’ defined but not used [-Werror=unused-const-variable=]
	cc1: all warnings being treated as errors
	make[7]: *** [../scripts/Makefile.build:252: drivers/staging/media/atomisp/i2c/atomisp-gc0310.o] Error 1
	make[6]: *** [../scripts/Makefile.build:494: drivers/staging/media/atomisp/i2c] Error 2
	make[5]: *** [../scripts/Makefile.build:494: drivers/staging/media/atomisp] Error 2
	make[4]: *** [../scripts/Makefile.build:494: drivers/staging/media] Error 2
	make[3]: *** [../scripts/Makefile.build:494: drivers/staging] Error 2
	make[2]: *** [../scripts/Makefile.build:494: drivers] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:2028: .] Error 2
	make: *** [Makefile:226: __sub-make] Error 2

patches/0022-media-atomisp-gc0310-Drop-custom-ATOMISP_IOC_S_EXPOS.patch:

    allyesconfig: return code #512:
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:71:35: error: ‘ctrl_ops’ defined but not used [-Werror=unused-const-variable=]
	cc1: all warnings being treated as errors
	make[7]: *** [../scripts/Makefile.build:252: drivers/staging/media/atomisp/i2c/atomisp-gc0310.o] Error 1
	make[6]: *** [../scripts/Makefile.build:494: drivers/staging/media/atomisp/i2c] Error 2
	make[5]: *** [../scripts/Makefile.build:494: drivers/staging/media/atomisp] Error 2
	make[4]: *** [../scripts/Makefile.build:494: drivers/staging/media] Error 2
	make[3]: *** [../scripts/Makefile.build:494: drivers/staging] Error 2
	make[2]: *** [../scripts/Makefile.build:494: drivers] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:2028: .] Error 2
	make: *** [Makefile:226: __sub-make] Error 2

patches/0027-media-atomisp-gc0310-Add-runtime-pm-support.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:339 gc0310_s_stream() warn: missing error code 'ret'

patches/0028-media-atomisp-gc0310-Use-devm_kzalloc-for-data-struc.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:339 gc0310_s_stream() warn: missing error code 'ret'

patches/0029-media-atomisp-gc0310-Switch-over-to-ACPI-powermanage.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:212 gc0310_s_stream() warn: missing error code 'ret'

patches/0030-media-atomisp-Remove-duplicate-atomisp_-start-stop-_.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0031-media-atomisp-Remove-continuous-mode-related-code-fr.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0032-media-atomisp-Remove-custom-V4L2_CID_FMT_AUTO-contro.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:416 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:212 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0033-media-atomisp-Remove-snr_mbus_fmt-local-var-from-ato.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0034-media-atomisp-Remove-unused-ATOM_ISP_MAX_WIDTH_TMP-a.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0035-media-atomisp-Remove-atomisp_try_fmt-call-from-atomi.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3085 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3184 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0036-media-atomisp-Drop-support-for-streaming-from-2-sens.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3015 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3114 atomisp_cp_morph_table() warn: missing unwind goto?

patches/0037-media-atomisp-Remove-struct-atomisp_sub_device-index.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3013 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3112 atomisp_cp_morph_table() warn: missing unwind goto?


Error #512 when building PDF docs
Hans de Goede April 9, 2023, 2:56 p.m. UTC | #2
Hi,

On 4/9/23 16:10, Jenkins wrote:
> From: builder@linuxtv.org
> 
> Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/bf274a09-a823-c547-4284-603e8c6da794@redhat.com/
> Build log: https://builder.linuxtv.org/job/patchwork/296238/
> Build time: 00:52:43
> Link: https://lore.kernel.org/linux-media/bf274a09-a823-c547-4284-603e8c6da794@redhat.com
> 
> gpg: Signature made Sun 09 Apr 2023 01:06:41 PM UTC
> gpg:                using RSA key BAF03B5D2718411A5E9E177E92EC4779440327DC
> gpg:                issuer "hdegoede@redhat.com"
> gpg: Good signature from "Hans de Goede <hdegoede@redhat.com>" [expired]
> gpg: Note: This key has expired!
> Primary key fingerprint: A1EA 0673 EAD8 B74F 17D2  B9E1 7C31 E21A 98D2 1E0D
>      Subkey fingerprint: BAF0 3B5D 2718 411A 5E9E  177E 92EC 4779 4403 27DC
> 
> Summary: got 27/39 patches with issues, being 26 at build time, plus one error when buinding PDF document
> 
> Error/warnings:
> 
> patches/0001-media-atomisp-Remove-depth-mode-support.patch:
> 
>     allyesconfig: return code #0:
> 	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> 	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> 	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
> 	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret'

ret is initialized to 0 and the intend is to return 0 here ...


> 	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3335 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
> 	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3434 atomisp_cp_morph_table() warn: missing unwind goto?

These 2 functions are not changed by this patch, so any problem there is a pre-existing problem.

And the same goes for all the warnings on all the other patches.

Regards,

Hans