diff mbox

[1/6,media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices()

Message ID c949fbd6-0a01-d6e7-d6f9-d55dbf5dce5e@users.sourceforge.net (mailing list archive)
State New, archived
Headers show

Commit Message

SF Markus Elfring Sept. 24, 2017, 10:22 a.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 24 Sep 2017 10:08:22 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/platform/omap/omap_vout.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Joe Perches Sept. 24, 2017, 10:35 a.m. UTC | #1 
On Sun, 2017-09-24 at 12:22 +0200, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
[]
> diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
[]
> @@ -1948,7 +1948,5 @@ static int __init omap_vout_create_video_devices(struct platform_device *pdev)
> -		if (!vout) {
> -			dev_err(&pdev->dev, ": could not allocate memory\n");
> +		if (!vout)
>  			return -ENOMEM;
> -		}
>  
>  		vout->vid = k;
>  		vid_dev->vouts[k] = vout;

Use normal patch styles.
Fix your tools before you send any more patches.
diff mbox

Patch

diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
index 4d29860d27b4..aebc1e628ac5 100644
--- a/drivers/media/platform/omap/omap_vout.c
+++ b/drivers/media/platform/omap/omap_vout.c
@@ -1948,7 +1948,5 @@  static int __init omap_vout_create_video_devices(struct platform_device *pdev)
-		if (!vout) {
-			dev_err(&pdev->dev, ": could not allocate memory\n");
+		if (!vout)
 			return -ENOMEM;
-		}
 
 		vout->vid = k;
 		vid_dev->vouts[k] = vout;