| Message ID | cc864898af00fc9e3e0e84246848b235aeb85aca.1503813075.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Arvind, On Sun, Aug 27, 2017 at 11:26:39AM +0530, Arvind Yadav wrote: > v4l2_subdev_sensor_ops are not supposed to change at runtime. > v4l2_subdev_sensor_ops are working with const 'sensor' field of > sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops > structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Thanks for the patch. The change has already been made by this patch: commit 65058214f5c2ebe844916b92d1bece64fd00206e Author: Julia Lawall <Julia.Lawall@lip6.fr> Date: Tue Aug 8 06:58:29 2017 -0400 media: staging: media: atomisp: constify video_subdev structures These structures are both stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c index 3fa9153..2c9b752 100644 --- a/drivers/staging/media/atomisp/i2c/mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c @@ -1806,7 +1806,7 @@ static const struct v4l2_subdev_video_ops mt9m114_video_ops = { .g_frame_interval = mt9m114_g_frame_interval, }; -static struct v4l2_subdev_sensor_ops mt9m114_sensor_ops = { +static const struct v4l2_subdev_sensor_ops mt9m114_sensor_ops = { .g_skip_frames = mt9m114_g_skip_frames, };
v4l2_subdev_sensor_ops are not supposed to change at runtime. v4l2_subdev_sensor_ops are working with const 'sensor' field of sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)