diff mbox

[media] lmed04: add missing breaks

Message ID d442b15fb4deb2b5d516e2dae1f569b1d5472399.1416914348.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Nov. 25, 2014, 11:19 a.m. UTC 
drivers/media/usb/dvb-usb-v2/lmedm04.c:828 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware'
drivers/media/usb/dvb-usb-v2/lmedm04.c:849 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware'

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Comments

Malcolm Priestley Nov. 25, 2014, 5:10 p.m. UTC | #1 
On 25/11/14 11:19, Mauro Carvalho Chehab wrote:
> drivers/media/usb/dvb-usb-v2/lmedm04.c:828 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware'
> drivers/media/usb/dvb-usb-v2/lmedm04.c:849 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware'
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> index 9f2c5459b73a..99587418f4f0 100644
> --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
> +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> @@ -826,6 +826,7 @@ static const char *lme_firmware_switch(struct dvb_usb_device *d, int cold)
>   				break;
>   			}
>   			st->dvb_usb_lme2510_firmware = TUNER_LG;
> +			break;
>   		case TUNER_LG:
>   			fw_lme = fw_lg;
>   			ret = request_firmware(&fw, fw_lme, &udev->dev);
> @@ -847,6 +848,7 @@ static const char *lme_firmware_switch(struct dvb_usb_device *d, int cold)
>   				break;
>   			}
>   			st->dvb_usb_lme2510_firmware = TUNER_LG;
> +			break;
>   		case TUNER_LG:
>   			fw_lme = fw_c_lg;
>   			ret = request_firmware(&fw, fw_lme, &udev->dev);
>
The break is not missing it's three lines above.

All these switches are fall through until it finds firmware the user has.

The switch comes into play when the firmware needs to changed.

Malcolm


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
index 9f2c5459b73a..99587418f4f0 100644
--- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
+++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
@@ -826,6 +826,7 @@  static const char *lme_firmware_switch(struct dvb_usb_device *d, int cold)
 				break;
 			}
 			st->dvb_usb_lme2510_firmware = TUNER_LG;
+			break;
 		case TUNER_LG:
 			fw_lme = fw_lg;
 			ret = request_firmware(&fw, fw_lme, &udev->dev);
@@ -847,6 +848,7 @@  static const char *lme_firmware_switch(struct dvb_usb_device *d, int cold)
 				break;
 			}
 			st->dvb_usb_lme2510_firmware = TUNER_LG;
+			break;
 		case TUNER_LG:
 			fw_lme = fw_c_lg;
 			ret = request_firmware(&fw, fw_lme, &udev->dev);