From patchwork Sun Oct 31 11:25:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 12594989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31319C433EF for ; Sun, 31 Oct 2021 11:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10D5261051 for ; Sun, 31 Oct 2021 11:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbhJaL1i (ORCPT ); Sun, 31 Oct 2021 07:27:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:47130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbhJaL1i (ORCPT ); Sun, 31 Oct 2021 07:27:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D18F60F58; Sun, 31 Oct 2021 11:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635679506; bh=/ba630/yMxIG0G/HrfuOl0TTd12zVAhW+3p5jt4O1qg=; h=From:To:Cc:Subject:Date:From; b=oc2RO08dPHGJIm4glq6KAAnyX1wJ3BcD1+WsaqgNw7C5s7sWu6Qf4EUW2Vm6UsAsn QV2meBXVjguJoYt5SVMRQ1eoRT2pyC31iglV8D5F6Pkqg4/36ERdF7S/B6vdd8BsTg 1gO8Nn8NZsVCHFf6ZF/ii+64U7GyKjRUqsCbIMP/6erYsHzEfiSTT8CUDZcCekLiA3 /wDiP/+hf7Vq0OygRfpYk7Tke8GXHhvWOo7z4OkDjWm0D20Myxqsi3+Zns0U8bg9ST P1bOAn/Ircmq2S55sgWZNYpKDJfq45eyq/V/O7qUc8oRtZ3c5nY9z7fiplI4UsLq3v TKJh1orqxpkrw== Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1mh8xT-003wZJ-Cp; Sun, 31 Oct 2021 11:25:03 +0000 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Arnd Bergmann , Dan Carpenter , Greg Kroah-Hartman , Kaixu Xia , Mauro Carvalho Chehab , Peter Zijlstra , Sakari Ailus , Thomas Gleixner , Tsuchiya Yuto , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 1/3] media: atomisp: don't print errors for ignored MBUS formats Date: Sun, 31 Oct 2021 11:25:00 +0000 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The bayer formats aren't currently available for userspace to select: those are marked as IA_CSS_FRAME_FORMAT_RAW and trying to get them result on binary firmware load errors: [74625.258097] atomisp-isp2 0000:00:03.0: Using binary isp_preview_var_isp2 (id 22), type 0, mode 1, continuous true [74625.258146] atomisp-isp2 0000:00:03.0: Seeking for binary failed at: [74625.258161] CPU: 3 PID: 2792 Comm: v4l2grab Tainted: G C 5.15.0-rc4+ #77 [74625.258190] Hardware name: ASUSTeK COMPUTER INC. T101HA/T101HA, BIOS T101HA.306 04/23/2019 [74625.258208] Call Trace: [74625.258231] dump_stack_lvl+0x46/0x5a [74625.258272] ia_css_binary_find+0xa7d/0xcf0 [atomisp] [74625.258570] load_preview_binaries+0x323/0x3c0 [atomisp] ... [74625.265892] atomisp-isp2 0000:00:03.0: can't create streams [74625.265937] atomisp-isp2 0000:00:03.0: __get_frame_info 1604x1200 (padded to 0) returned -22 [74625.265962] atomisp-isp2 0000:00:03.0: Can't set format on ISP. Error -22 As those formats are ignored by purpose, it doesn't make any sense to print a message like: atomisp_enum_fmt_cap(): format for code 3007 not found. for those. Yet, some day it would be interesting to also report the bayer formats, letting userspace to decode them on a different way. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c index f082d7a67875..8f0a9a69f075 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c @@ -829,8 +829,6 @@ static int atomisp_enum_fmt_cap(struct file *file, void *fh, f->pixelformat = format->pixelformat; return 0; } - dev_err(isp->dev, "%s(): format for code %x not found.\n", - __func__, code.code); return -EINVAL; }