From patchwork Wed Jun 7 13:44:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9771543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CEA6B60350 for ; Wed, 7 Jun 2017 13:45:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD8F328464 for ; Wed, 7 Jun 2017 13:45:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B1B6F2847A; Wed, 7 Jun 2017 13:45:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6410828464 for ; Wed, 7 Jun 2017 13:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467AbdFGNo5 (ORCPT ); Wed, 7 Jun 2017 09:44:57 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:32922 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbdFGNo4 (ORCPT ); Wed, 7 Jun 2017 09:44:56 -0400 Received: by mail-pg0-f67.google.com with SMTP id a70so1551873pge.0; Wed, 07 Jun 2017 06:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Wn2nZ/bQdPeshOzsu8pY8etLue5fVWa+Bee1Lj6eboA=; b=T5w31OVP16/UTdadTK6n597cvVOJOKNmfoPj/zHtx5K7yqJzDzmLtFUG1n/30o/hng rFWQBxveyRY4SxKV2zyrNv1p3wKSBG894FxA59OsSWbdiyVbMGOK4ShXEfxmWyPh++3+ om00wasMZHEWj9010AFYMv8WJwasqmmB82OvXAGUVBPL3JA8yC2vWvBmip4lkFvhYWYm AnInu3E3IS4RLnm/kFM+tM2UESv7ytFYUlWrMkJZ5EXOSX1BnT6yT3v9ks7qL6mqyzf1 twKYD963bIIMwYBJIh3QHSIW1afNmtiVxeFl5ylnju0KsSqTc9jCoHeHGp86746OrJvW c0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Wn2nZ/bQdPeshOzsu8pY8etLue5fVWa+Bee1Lj6eboA=; b=d8ZCETk6cwZKxOxw9aqsNfUaarobdSmKiOtRdAPXOPL1DlSJ5WZd17ZVVf/hx+b+Kx TUOmeqcf3fwwqT0ba+5cqpiJHAW0qoYFddI5I5JJA0FMP0v8/lDQN/RPtH26eZzbsYHL aoXgTfV5c6QvcB+uAT4NAGJ4QdtcHLvTck6pYU5P+QL+AQCxgz/dU1rbl/tR3alXeuMY ICMtisUVu6SLZ9CW+opSfGp0+L6NaUaUcEhthX5kR3pzxFgSsnW9wl57Fvnun+9dGXGk oaWuAHiZC2G5CN2rzHy3J8q4cd/5oXIv9v9sdAq6zBU/BVaaVSbijVhKsPkmlhKfxIfN o03w== X-Gm-Message-State: AODbwcDU4TM+BtWIk0GW3rHlVoS3dyzgNuCSHnxUcxfPczPuoGNZ94hW 5Hf21QmrdsJtlo7n X-Received: by 10.84.230.129 with SMTP id e1mr26917201plk.88.1496843095438; Wed, 07 Jun 2017 06:44:55 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id c27sm3824980pfj.107.2017.06.07.06.44.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Jun 2017 06:44:54 -0700 (PDT) From: Arvind Yadav To: mchehab@kernel.org, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: media: davinci_vpfe Fix resource leaks in error paths. Date: Wed, 7 Jun 2017 19:14:34 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Free memory, if ipipe_s_config and ipipe_g_config are not successful. Signed-off-by: Arvind Yadav --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 6a3434c..b6994ee 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c @@ -1286,15 +1286,20 @@ static int ipipe_s_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) if (to && from && size) { if (copy_from_user(to, from, size)) { rval = -EFAULT; + kfree(params); break; } rval = module_if->set(ipipe, to); - if (rval) + if (rval) { + kfree(params); goto error; + } } else if (to && !from && size) { rval = module_if->set(ipipe, NULL); - if (rval) + if (rval) { + kfree(params); goto error; + } } kfree(params); } @@ -1328,10 +1333,13 @@ static int ipipe_g_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) if (to && from && size) { rval = module_if->get(ipipe, from); - if (rval) + if (rval) { + kfree(params); goto error; + } if (copy_to_user(to, from, size)) { rval = -EFAULT; + kfree(params); break; } }