From patchwork Mon Apr 12 12:57:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 12197997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA44C433ED for ; Mon, 12 Apr 2021 12:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11C6661288 for ; Mon, 12 Apr 2021 12:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241245AbhDLM5b (ORCPT ); Mon, 12 Apr 2021 08:57:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239454AbhDLM5a (ORCPT ); Mon, 12 Apr 2021 08:57:30 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD380C061574; Mon, 12 Apr 2021 05:57:12 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id g15so13115428qkl.4; Mon, 12 Apr 2021 05:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x7tmmZHrCVQE02Px5t5c/UG1yYUMoOazF7ZKUu9ZpuU=; b=bG0J3T9h0gD7RFwfNzKPHOpVtBGHDC9e4xfbvB/QjXJZsoROBH322oIhWOFt5ydN0P 1anCaW9cFkl95K0dNa+EbRMXAoPlXdrJx/e+se+pX2glviRXmq3OhrFFPY51YvC3ajn+ 83hUxE2xXl9vp1qfzUjp8D0oX2JYcx+LW89E6owH8J/SATk7ABbi7x0yPotpnPoYT1tp Qx/gClqyN/42t0LjlexgVS5y1uBh4ECm545BJhY0d/VMPNO4GjoPgZ8Cl41UFTzUeyPg 9RKFFB17yrw2osPKw+yR5EFHYdcJjyI1SYsI62WeNfQtNeTavOvnyTfcLSc1/76Lt8xs zhPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x7tmmZHrCVQE02Px5t5c/UG1yYUMoOazF7ZKUu9ZpuU=; b=AUIrLpPX6M8olIYDs7WNtb4izya8dGpGGjc3nhZVMkYJZZcLdTZmOp74ftbwcTCtkA fwkzOWqakUdxfq3sLoz20K1/LV9HNHOJzJBrwdI+vyQantYe2l3ihYCq5RIJ9MsfKote BAMiQp/NK6P/8ybTfM6DY/s4iV5hU4TAC7DpDdwDgvR+f5qOpFmSM8LF83IfvwkhDRUe 8pz+KMYSStJMlEOF6NM0CpmFwUzinmzhwVGpqLGJTewYn49kS7kNQLGPd9koDWHx5SAo 1E0Sk9Sr9P6TzoXxumzmO7vJpVTdm3mT095XexLFyPFfMZgVvW6NzOTy2Sar0REi251Y 4G/A== X-Gm-Message-State: AOAM531Iilkc9qG3/ER8frID/upD6LH3JrZ0UU/3sqmp2AR1W4IR3OaO xW5EN/m5/NxFz93ZG9baatY= X-Google-Smtp-Source: ABdhPJyQpNi3IhdSeoFbNulAoOEdI449xVECFe4I0yY38UdmVEZ6p6nM/pmt1/u/ctp7QN3XPnZ+Fg== X-Received: by 2002:a05:620a:1592:: with SMTP id d18mr4863797qkk.329.1618232232193; Mon, 12 Apr 2021 05:57:12 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id t198sm3824160qke.44.2021.04.12.05.57.11 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 05:57:11 -0700 (PDT) Date: Mon, 12 Apr 2021 09:57:09 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro --- Changes since v1: - Insert file path in commit message drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index c89f268a..3bbc39e 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -27,22 +27,24 @@ #include "iss.h" #include "iss_regs.h" -#define ISS_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name)) +static inline iss_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name)); +} static void iss_print_status(struct iss_device *iss) { dev_dbg(iss->dev, "-------------ISS HL Register dump-------------\n"); - ISS_PRINT_REGISTER(iss, HL_REVISION); - ISS_PRINT_REGISTER(iss, HL_SYSCONFIG); - ISS_PRINT_REGISTER(iss, HL_IRQSTATUS(5)); - ISS_PRINT_REGISTER(iss, HL_IRQENABLE_SET(5)); - ISS_PRINT_REGISTER(iss, HL_IRQENABLE_CLR(5)); - ISS_PRINT_REGISTER(iss, CTRL); - ISS_PRINT_REGISTER(iss, CLKCTRL); - ISS_PRINT_REGISTER(iss, CLKSTAT); + iss_print_register(iss, HL_REVISION); + iss_print_register(iss, HL_SYSCONFIG); + iss_print_register(iss, HL_IRQSTATUS(5)); + iss_print_register(iss, HL_IRQENABLE_SET(5)); + iss_print_register(iss, HL_IRQENABLE_CLR(5)); + iss_print_register(iss, CTRL); + iss_print_register(iss, CLKCTRL); + iss_print_register(iss, CLKSTAT); dev_dbg(iss->dev, "-----------------------------------------------\n"); }