diff mbox

[media] rc-main: Fix rc_type handling

Message ID fb9b1641ba30385e1c142ecef2b631d31a881fd1.1415190468.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Nov. 5, 2014, 12:27 p.m. UTC 
As reported by smatch:
	drivers/media/rc/rc-main.c:1426 rc_register_device() warn: should '1 << rc_map->rc_type' be a 64 bit type?

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Comments

David Härdeman Nov. 7, 2014, 9:54 a.m. UTC | #1 
On 2014-11-05 13:27, Mauro Carvalho Chehab wrote:
> As reported by smatch:
> 	drivers/media/rc/rc-main.c:1426 rc_register_device() warn: should '1
> << rc_map->rc_type' be a 64 bit type?
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> 
> diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
> index 296de853a25d..66eabc5dd000 100644
> --- a/drivers/media/rc/rc-main.c
> +++ b/drivers/media/rc/rc-main.c
> @@ -1423,7 +1423,7 @@ int rc_register_device(struct rc_dev *dev)
>  	}
> 
>  	if (dev->change_protocol) {
> -		u64 rc_type = (1 << rc_map->rc_type);
> +		u64 rc_type = (1ll << rc_map->rc_type);

Just a minor nitpick, but I think "ull" is more consistent with "u64"

>  		rc = dev->change_protocol(dev, &rc_type);
>  		if (rc < 0)
>  			goto out_raw;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 296de853a25d..66eabc5dd000 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -1423,7 +1423,7 @@  int rc_register_device(struct rc_dev *dev)
 	}
 
 	if (dev->change_protocol) {
-		u64 rc_type = (1 << rc_map->rc_type);
+		u64 rc_type = (1ll << rc_map->rc_type);
 		rc = dev->change_protocol(dev, &rc_type);
 		if (rc < 0)
 			goto out_raw;