diff mbox series

TDA1997x: fix tda1997x_query_dv_timings() return value

Message ID m31r7lcpyz.fsf@t19.piap.pl (mailing list archive)
State New, archived
Headers show
Series TDA1997x: fix tda1997x_query_dv_timings() return value | expand

Commit Message

Krzysztof Hałasa July 26, 2021, 10:46 a.m. UTC 
Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>

Comments

Tim Harvey Aug. 19, 2021, 4:48 p.m. UTC | #1 
On Mon, Jul 26, 2021 at 3:46 AM Krzysztof Hałasa <khalasa@piap.pl> wrote:
>
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
>
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 043cc8275d00..cbfe58e413e9 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
>                                      struct v4l2_dv_timings *timings)
>  {
>         struct tda1997x_state *state = to_state(sd);
> +       int ret;
>
>         v4l_dbg(1, debug, state->client, "%s\n", __func__);
>         memset(timings, 0, sizeof(struct v4l2_dv_timings));
>         mutex_lock(&state->lock);
> -       tda1997x_detect_std(state, timings);
> +       ret = tda1997x_detect_std(state, timings);
>         mutex_unlock(&state->lock);
>
> -       return 0;
> +       return ret;
>  }
>
>  static const struct v4l2_subdev_video_ops tda1997x_video_ops = {

Krzysztof,

Patch looks good to me but needs a commit log.

Best regards,

Tim
diff mbox series

Patch

diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 043cc8275d00..cbfe58e413e9 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -1695,14 +1695,15 @@  static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
 				     struct v4l2_dv_timings *timings)
 {
 	struct tda1997x_state *state = to_state(sd);
+	int ret;
 
 	v4l_dbg(1, debug, state->client, "%s\n", __func__);
 	memset(timings, 0, sizeof(struct v4l2_dv_timings));
 	mutex_lock(&state->lock);
-	tda1997x_detect_std(state, timings);
+	ret = tda1997x_detect_std(state, timings);
 	mutex_unlock(&state->lock);
 
-	return 0;
+	return ret;
 }
 
 static const struct v4l2_subdev_video_ops tda1997x_video_ops = {