From patchwork Sat Aug 6 08:33:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 1041102 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p768YALv025912 for ; Sat, 6 Aug 2011 08:34:10 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385Ab1HFIdo (ORCPT ); Sat, 6 Aug 2011 04:33:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55165 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129Ab1HFIdm (ORCPT ); Sat, 6 Aug 2011 04:33:42 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 95762890B6; Sat, 6 Aug 2011 10:33:40 +0200 (CEST) Date: Sat, 06 Aug 2011 10:33:39 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Stephen Rothwell , linux-media@vger.kernel.org, Mauro Carvalho Chehab , linux-next@vger.kernel.org, LKML , Ondrej Zary Subject: Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2) In-Reply-To: <20110805165611.d2feaf32.rdunlap@xenotime.net> References: <20110805143103.f9388ca143560d73caac60c1@canb.auug.org.au> <20110805165611.d2feaf32.rdunlap@xenotime.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 06 Aug 2011 08:34:10 +0000 (UTC) At Fri, 5 Aug 2011 16:56:11 -0700, Randy Dunlap wrote: > > On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote: > > > Hi all, > > > > [The kernel.org mirroring is running slowly today] > > Is media/radio/radio-sf16fmr2 an ISA driver or a PCI driver? > ugh. Or is it an I2C driver? > > > linux-next fails with (this is not a new failure): > > ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > > The Kconfig entry for RADIO_SF16FMR2 is: > > config RADIO_SF16FMR2 > tristate "SF16FMR2 Radio" > depends on ISA && VIDEO_V4L2 && SND > > and the Kconfig entry for SND_TEA575X is (not user visible): > > config SND_TEA575X > tristate > depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 > default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 > > This latter entry is in sound/pci/Kconfig and is under: > if SND_PCI > so it depends on PCI and SND_PCI. > > This build fails when CONFIG_PCI is not enabled. tea575x-tuner is an i2c component (not meaning Linux i2c-subsystem), thus should be independent from the board bus type. Does a patch like below work? thanks, Takashi Reported-by: Randy Dunlap Acked-by: Randy Dunlap --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig index 50abf5b..8816804 100644 --- a/sound/pci/Kconfig +++ b/sound/pci/Kconfig @@ -1,5 +1,10 @@ # ALSA PCI drivers +config SND_TEA575X + tristate + depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 + default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 + menuconfig SND_PCI bool "PCI sound devices" depends on PCI @@ -563,11 +568,6 @@ config SND_FM801_TEA575X_BOOL FM801 chip with a TEA5757 tuner (MediaForte SF256-PCS, SF256-PCP and SF64-PCR) into the snd-fm801 driver. -config SND_TEA575X - tristate - depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 - default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 - source "sound/pci/hda/Kconfig" config SND_HDSP