From patchwork Tue Mar 31 05:34:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 15329 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2V6JUqp026564 for ; Tue, 31 Mar 2009 06:19:30 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbZCaGTa (ORCPT ); Tue, 31 Mar 2009 02:19:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755864AbZCaGTa (ORCPT ); Tue, 31 Mar 2009 02:19:30 -0400 Received: from mail.renesas.com ([202.234.163.13]:44346 "EHLO mail05.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753766AbZCaGT3 (ORCPT ); Tue, 31 Mar 2009 02:19:29 -0400 X-AuditID: ac140388-0000000700006b18-c4-49d1b5eb4e71 Received: from guardian03.idc.renesas.com ([172.20.8.202]) by mail05.idc.renesas.com (sendmail) with ESMTP id n2V6JNk1017116; Tue, 31 Mar 2009 15:19:23 +0900 (JST) Received: (from root@localhost) by guardian03.idc.renesas.com with id n2V6JN4g026679; Tue, 31 Mar 2009 15:19:23 +0900 (JST) Received: from mta02.idc.renesas.com (localhost [127.0.0.1]) by mta02.idc.renesas.com with ESMTP id n2V6JPp0027759; Tue, 31 Mar 2009 15:19:25 +0900 (JST) Received: from PG10870.renesas.com ([172.30.8.159]) by ims05.idc.renesas.com (Sendmail) with ESMTPA id <0KHC002EPXKB7O@ims05.idc.renesas.com>; Tue, 31 Mar 2009 15:19:23 +0900 (JST) Date: Tue, 31 Mar 2009 14:34:46 +0900 From: Kuninori Morimoto Subject: [PATCH] soc_camera: Add soc_camera_match function To: Guennadi Liakhovetski Cc: Linux Media Message-id: MIME-version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-type: text/plain; charset=US-ASCII User-Agent: SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.1 (i386-mingw-nt5.1.2600) MULE/5.0 (SAKAKI) Meadow/3.00-dev (KIKU) X-Brightmail-Tracker: AAAAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org ${LINUX}/drivers/base/dd.c :: __device_attach use driver_match_device function. It needs bus->match function. Signed-off-by: Kuninori Morimoto --- > Guennadi I tried latest Linux 2.6.29 from Paul's git git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6.git Then, soc_camera doesn't works. please check 49b420a13ff95b449947181190b08367348e3e1b But I'm not sure is this patch correct fix ? drivers/media/video/soc_camera.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c index 6d8bfd4..a10828b 100644 --- a/drivers/media/video/soc_camera.c +++ b/drivers/media/video/soc_camera.c @@ -929,12 +929,21 @@ static int soc_camera_resume(struct device *dev) return ret; } +int soc_camera_match(struct device *dev, struct device_driver *drv) +{ + struct soc_camera_device *icd = to_soc_camera_dev(dev); + struct soc_camera_host *ici = to_soc_camera_host(icd->dev.parent); + + return ici->nr == icd->iface; +} + static struct bus_type soc_camera_bus_type = { .name = "soc-camera", .probe = soc_camera_probe, .remove = soc_camera_remove, .suspend = soc_camera_suspend, .resume = soc_camera_resume, + .match = soc_camera_match, }; static struct device_driver ic_drv = {