mbox series

[v19,0/2] PS8640 MIPI-to-eDP bridge

Message ID 1570216148-22802-1-git-send-email-uli@fpond.eu (mailing list archive)
Headers show
Series PS8640 MIPI-to-eDP bridge | expand

Message

Ulrich Hecht Oct. 4, 2019, 7:09 p.m. UTC
Hi!

This driver seems to have fallen by the wayside because, while otherwise
fine, it has a firmware update feature that requires a blob that is not in
the linux-firmware repo.[1]

Whatever the cause for that may be, the update code is entirely optional
(my chip works fine with whatever firmware is currently installed), so I
have removed it in order to get this merged after all. I have also
followed various trivial API changes that have piled up since 2016; see
the individual patches for details.

I'm using this driver on an Acer Chromebook R13 ("Elm"); see
https://github.com/uli/kernel/tree/elm-working-5.4.

CU
Uli

[1] https://patchwork.kernel.org/patch/9427543/

Jitao Shi (2):
  Documentation: bridge: Add documentation for ps8640 DT properties
  drm/bridge: Add I2C based driver for ps8640 bridge

 .../devicetree/bindings/display/bridge/ps8640.txt  |  44 ++
 drivers/gpu/drm/bridge/Kconfig                     |  12 +
 drivers/gpu/drm/bridge/Makefile                    |   1 +
 drivers/gpu/drm/bridge/parade-ps8640.c             | 672 +++++++++++++++++++++
 4 files changed, 729 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt
 create mode 100644 drivers/gpu/drm/bridge/parade-ps8640.c

Comments

Matthias Brugger Oct. 5, 2019, 11:16 a.m. UTC | #1
Hi Uli,

On 04/10/2019 21:09, Ulrich Hecht wrote:
> Hi!
> 
> This driver seems to have fallen by the wayside because, while otherwise
> fine, it has a firmware update feature that requires a blob that is not in
> the linux-firmware repo.[1]
> 
> Whatever the cause for that may be, the update code is entirely optional
> (my chip works fine with whatever firmware is currently installed), so I
> have removed it in order to get this merged after all. I have also
> followed various trivial API changes that have piled up since 2016; see
> the individual patches for details.
> 
> I'm using this driver on an Acer Chromebook R13 ("Elm"); see
> https://github.com/uli/kernel/tree/elm-working-5.4.
> 

Thanks for your effort to get things upstream.
I just tried your branch on my R13. I had to do a trivial config change I had to
do, as I don't have and care about the bluetooth FW right now.
But after that my screen keeps black. I was able to build and boot
elm-working-5.3 and elm-working-5.2.

Unfortunatley I don't have a serial console on the Chromebook, so it's difficult
to find out where it hangs. Can you please double check if your new
elm-working-5.4 actually really works?

Thanks,
Matthias

> CU
> Uli
> 
> [1] https://patchwork.kernel.org/patch/9427543/
> 
> Jitao Shi (2):
>   Documentation: bridge: Add documentation for ps8640 DT properties
>   drm/bridge: Add I2C based driver for ps8640 bridge
> 
>  .../devicetree/bindings/display/bridge/ps8640.txt  |  44 ++
>  drivers/gpu/drm/bridge/Kconfig                     |  12 +
>  drivers/gpu/drm/bridge/Makefile                    |   1 +
>  drivers/gpu/drm/bridge/parade-ps8640.c             | 672 +++++++++++++++++++++
>  4 files changed, 729 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt
>  create mode 100644 drivers/gpu/drm/bridge/parade-ps8640.c
>
Ulrich Hecht Oct. 6, 2019, 12:32 p.m. UTC | #2
> On October 5, 2019 at 1:16 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> 
> 
> Hi Uli,
> 
> On 04/10/2019 21:09, Ulrich Hecht wrote:
> > Hi!
> > 
> > This driver seems to have fallen by the wayside because, while otherwise
> > fine, it has a firmware update feature that requires a blob that is not in
> > the linux-firmware repo.[1]
> > 
> > Whatever the cause for that may be, the update code is entirely optional
> > (my chip works fine with whatever firmware is currently installed), so I
> > have removed it in order to get this merged after all. I have also
> > followed various trivial API changes that have piled up since 2016; see
> > the individual patches for details.
> > 
> > I'm using this driver on an Acer Chromebook R13 ("Elm"); see
> > https://github.com/uli/kernel/tree/elm-working-5.4.
> > 
> 
> Thanks for your effort to get things upstream.
> I just tried your branch on my R13. I had to do a trivial config change I had to
> do, as I don't have and care about the bluetooth FW right now.

Thank you for testing!

> But after that my screen keeps black. I was able to build and boot
> elm-working-5.3 and elm-working-5.2.
> 
> Unfortunatley I don't have a serial console on the Chromebook, so it's difficult
> to find out where it hangs. Can you please double check if your new
> elm-working-5.4 actually really works?

No, it doesn't. :( It seems I forgot to run mkimage/vbutil_kernel when testing...
I have pushed a fix to the elm-working-5.4 tree, and I will send a v20 tomorrow. Sorry for the inconvenience.

CU
Uli