From patchwork Thu Aug 13 02:13:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chinwen Chang X-Patchwork-Id: 11711545 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0663913 for ; Thu, 13 Aug 2020 02:14:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 882B220771 for ; Thu, 13 Aug 2020 02:14:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gw4aE07f"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iBEvIDhk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 882B220771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=In5BEDYzvM+LqxrUOzEdSlHh7ldZDgSoWPdZ9PK0U34=; b=Gw4aE07fj/osksd4xEdE7kFxCm DjPZ0oSEJMMTbQJtup/ZWSNWB+g0X5p9pn3x6j653Xg0uSEZ9/hBNzBAZIMRTCscHe8+jBmCJeRWn zD/TGkVsIgGQG2vB8zq20Xbk5QGRhlync3NRu3+KXxSafMQXAbvDnVZPVWYvseHBmwbI5aqmKBNcu cD4uoDeD5IondjlYpdhwOfkRzmzOOQLfeIL61f8kEYl/SH51ZAVFl21Yh+0YTDK/LJZ1UciSgZadb nI2M1wCPiXY4dMF1wxsXnaSgLdKTryLGnqRTkvBcJjLn1c9gYZtcMP3HFLpF0MWzgGyinDDliLh+d qC6seJgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k62km-0003Tg-Hm; Thu, 13 Aug 2020 02:14:04 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k62ki-0003Rr-SA; Thu, 13 Aug 2020 02:14:02 +0000 X-UUID: 2794ca0de241451ab5f5e84cad1e9b1e-20200812 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=aF1D+BCyiRCtqB/9T1GyAsWkEq1ttG2TVqo5h3JEkxo=; b=iBEvIDhkcs6plnbJGYTJTybOT8PtjIeTJWVB6qEItJ5wE8T+KT5wBPVAWzbaoqOQmCDm+FEVaKHt7JEjukxum46gfzHUTT0rXnPGC/gSv+kHzXgyQ9vD3DmljqukS7O19IY74Yiow8WZbMRSbGn9x8cPgNtQ1TFsGe6uNU929WE=; X-UUID: 2794ca0de241451ab5f5e84cad1e9b1e-20200812 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 863826039; Wed, 12 Aug 2020 18:13:53 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 12 Aug 2020 19:13:52 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 13 Aug 2020 10:13:45 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 13 Aug 2020 10:13:45 +0800 From: Chinwen Chang To: Matthias Brugger , Michel Lespinasse , Andrew Morton , "Vlastimil Babka" , Daniel Jordan , "Davidlohr Bueso" , Chinwen Chang , "Alexey Dobriyan" , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , Steven Price , Song Liu , Jimmy Assarsson , Huang Ying Subject: [PATCH v2 0/2] Try to release mmap_lock temporarily in smaps_rollup Date: Thu, 13 Aug 2020 10:13:28 +0800 Message-ID: <1597284810-17454-1-git-send-email-chinwen.chang@mediatek.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_221401_058236_FD1C7D3A X-CRM114-Status: GOOD ( 13.86 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org Recently, we have observed some janky issues caused by unpleasantly long contention on mmap_lock which is held by smaps_rollup when probing large processes. To address the problem, we let smaps_rollup detect if anyone wants to acquire mmap_lock for write attempts. If yes, just release the lock temporarily to ease the contention. smaps_rollup is a procfs interface which allows users to summarize the process's memory usage without the overhead of seq_* calls. Android uses it to sample the memory usage of various processes to balance its memory pool sizes. If no one wants to take the lock for write requests, smaps_rollup with this patch will behave like the original one. Although there are on-going mmap_lock optimizations like range-based locks, the lock applied to smaps_rollup would be the coarse one, which is hard to avoid the occurrence of aforementioned issues. So the detection and temporary release for write attempts on mmap_lock in smaps_rollup is still necessary. Change since v1: - If current VMA is freed after dropping the lock, it will return - incomplete result. To fix this issue, refine the code flow as - suggested by Steve. [1] [1] https://lore.kernel.org/lkml/bf40676e-b14b-44cd-75ce-419c70194783@arm.com/ Chinwen Chang (2): mmap locking API: add mmap_lock_is_contended() mm: proc: smaps_rollup: do not stall write attempts on mmap_lock fs/proc/task_mmu.c | 57 ++++++++++++++++++++++++++++++++++++++- include/linux/mmap_lock.h | 5 ++++ 2 files changed, 61 insertions(+), 1 deletion(-)