[v7,0/3] iio: adc: mt6360: Add ADC driver for MT6360

Message

Gene Chen Oct. 20, 2020, 8:07 a.m. UTC

In-Reply-To: 

This patch series add MT6360 ADC support contains driver, testing document
and binding document

Gene Chen (2)
  dt-bindings: iio: adc: add bindings doc for MT6360 ADC
  Documentation: ABI: testing: mt6360: Add ADC sysfs guideline
  iio: adc: mt6360: Add ADC driver for MT6360

 Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360                 |   78 ++
 Documentation/devicetree/bindings/iio/adc/mediatek,mt6360-adc.yaml |   34 
 drivers/iio/adc/Kconfig                                            |   11 
 drivers/iio/adc/Makefile                                           |    1 
 drivers/iio/adc/mt6360-adc.c                                       |  372 ++++++++++
 5 files changed, 496 insertions(+)

changelogs between v1 & v2
 - adc: use IIO_CHAN_INFO_PROCESSED only
 - adc: use devm_iio_triggered_buffer_setup
 - adc: use use s64 to record timestamp

changelogs between v2 & v3
 - Rearrange include file order by alphabet
 - Set line length constraint below 100
 - Add Document for testing adc sysfs node guideline
 - Set compiler 64 bit aligned when handle iio timestamp

changelogs between v3 & v4
 - Fix sysfs guideline description
 - Replace iio channel processed by raw/scale/offset
 - Add comment of read adc flow for special HW design

changelogs between v4 & v5
 - Rename dt-bindings aligned to file name
 - Aligned sysfs node name with driver and add VBUSDIVX description
 - Add ADC channel sysfs node "*_labels"

changelogs between v5 & v6
 - Memset aligned adc data
 - Remove strong casting void pointer

changelogs between v6 & v7
 - Avoid adc polling infinite loop

Comments

Jonathan Cameron Nov. 1, 2020, 3:40 p.m. UTC | #1

On Tue, 20 Oct 2020 16:07:44 +0800
Gene Chen <[e-mail]> wrote:

> In-Reply-To: 
> 
> This patch series add MT6360 ADC support contains driver, testing document
> and binding document
> 
Hi Gene,

Other than that small edit needed in the dt binding this is stalled on
the label code getting upstreamed into the core.

I've asked Cristian to repost that so hopefully we can resolve that dependency
and get this merged fairly soon.

For the dt thing I can just drop the description entirely, but would prefer
if you sent a v8 fixing the tags issue Rob pointed out and also fixing that
description.

Thanks,

Jonathan

> Gene Chen (2)
>   dt-bindings: iio: adc: add bindings doc for MT6360 ADC
>   Documentation: ABI: testing: mt6360: Add ADC sysfs guideline
>   iio: adc: mt6360: Add ADC driver for MT6360
> 
>  Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360                 |   78 ++
>  Documentation/devicetree/bindings/iio/adc/mediatek,mt6360-adc.yaml |   34 
>  drivers/iio/adc/Kconfig                                            |   11 
>  drivers/iio/adc/Makefile                                           |    1 
>  drivers/iio/adc/mt6360-adc.c                                       |  372 ++++++++++
>  5 files changed, 496 insertions(+)
> 
> changelogs between v1 & v2
>  - adc: use IIO_CHAN_INFO_PROCESSED only
>  - adc: use devm_iio_triggered_buffer_setup
>  - adc: use use s64 to record timestamp
> 
> changelogs between v2 & v3
>  - Rearrange include file order by alphabet
>  - Set line length constraint below 100
>  - Add Document for testing adc sysfs node guideline
>  - Set compiler 64 bit aligned when handle iio timestamp
> 
> changelogs between v3 & v4
>  - Fix sysfs guideline description
>  - Replace iio channel processed by raw/scale/offset
>  - Add comment of read adc flow for special HW design
> 
> changelogs between v4 & v5
>  - Rename dt-bindings aligned to file name
>  - Aligned sysfs node name with driver and add VBUSDIVX description
>  - Add ADC channel sysfs node "*_labels"
> 
> changelogs between v5 & v6
>  - Memset aligned adc data
>  - Remove strong casting void pointer
> 
> changelogs between v6 & v7
>  - Avoid adc polling infinite loop
>

Gene Chen Nov. 2, 2020, 7:04 a.m. UTC | #2

Jonathan Cameron <[e-mail]> 於 2020年11月1日 週日 下午11:40寫道：
>
> On Tue, 20 Oct 2020 16:07:44 +0800
> Gene Chen <[e-mail]> wrote:
>
> > In-Reply-To:
> >
> > This patch series add MT6360 ADC support contains driver, testing document
> > and binding document
> >
> Hi Gene,
>
> Other than that small edit needed in the dt binding this is stalled on
> the label code getting upstreamed into the core.
>
> I've asked Cristian to repost that so hopefully we can resolve that dependency
> and get this merged fairly soon.
>
> For the dt thing I can just drop the description entirely, but would prefer
> if you sent a v8 fixing the tags issue Rob pointed out and also fixing that
> description.
>
> Thanks,
>
> Jonathan
>

=============
> +description: |
> +  Family of simple ADCs with i2c interface and internal references.
That seems unlikely...
=============

Do you means I should remove this description?
If yes, I will also update PATCH v8 for add tags and fix dt-bindings.

> > Gene Chen (2)
> >   dt-bindings: iio: adc: add bindings doc for MT6360 ADC
> >   Documentation: ABI: testing: mt6360: Add ADC sysfs guideline
> >   iio: adc: mt6360: Add ADC driver for MT6360
> >
> >  Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360                 |   78 ++
> >  Documentation/devicetree/bindings/iio/adc/mediatek,mt6360-adc.yaml |   34
> >  drivers/iio/adc/Kconfig                                            |   11
> >  drivers/iio/adc/Makefile                                           |    1
> >  drivers/iio/adc/mt6360-adc.c                                       |  372 ++++++++++
> >  5 files changed, 496 insertions(+)
> >
> > changelogs between v1 & v2
> >  - adc: use IIO_CHAN_INFO_PROCESSED only
> >  - adc: use devm_iio_triggered_buffer_setup
> >  - adc: use use s64 to record timestamp
> >
> > changelogs between v2 & v3
> >  - Rearrange include file order by alphabet
> >  - Set line length constraint below 100
> >  - Add Document for testing adc sysfs node guideline
> >  - Set compiler 64 bit aligned when handle iio timestamp
> >
> > changelogs between v3 & v4
> >  - Fix sysfs guideline description
> >  - Replace iio channel processed by raw/scale/offset
> >  - Add comment of read adc flow for special HW design
> >
> > changelogs between v4 & v5
> >  - Rename dt-bindings aligned to file name
> >  - Aligned sysfs node name with driver and add VBUSDIVX description
> >  - Add ADC channel sysfs node "*_labels"
> >
> > changelogs between v5 & v6
> >  - Memset aligned adc data
> >  - Remove strong casting void pointer
> >
> > changelogs between v6 & v7
> >  - Avoid adc polling infinite loop
> >
>

Jonathan Cameron Nov. 8, 2020, 4:23 p.m. UTC | #3

On Sun, 1 Nov 2020 15:40:19 +0000
Jonathan Cameron <[e-mail]> wrote:

> On Tue, 20 Oct 2020 16:07:44 +0800
> Gene Chen <[e-mail]> wrote:
> 
> > In-Reply-To: 
> > 
> > This patch series add MT6360 ADC support contains driver, testing document
> > and binding document
> >   
> Hi Gene,
> 
> Other than that small edit needed in the dt binding this is stalled on
> the label code getting upstreamed into the core.
> 
> I've asked Cristian to repost that so hopefully we can resolve that dependency
> and get this merged fairly soon.
> 
> For the dt thing I can just drop the description entirely, but would prefer
> if you sent a v8 fixing the tags issue Rob pointed out and also fixing that
> description.
I've tweaked as described and applied to the togreg branch of iio.git and
pushed out as testing for the autobuilders to poke at it more than I do.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > Gene Chen (2)
> >   dt-bindings: iio: adc: add bindings doc for MT6360 ADC
> >   Documentation: ABI: testing: mt6360: Add ADC sysfs guideline
> >   iio: adc: mt6360: Add ADC driver for MT6360
> > 
> >  Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360                 |   78 ++
> >  Documentation/devicetree/bindings/iio/adc/mediatek,mt6360-adc.yaml |   34 
> >  drivers/iio/adc/Kconfig                                            |   11 
> >  drivers/iio/adc/Makefile                                           |    1 
> >  drivers/iio/adc/mt6360-adc.c                                       |  372 ++++++++++
> >  5 files changed, 496 insertions(+)
> > 
> > changelogs between v1 & v2
> >  - adc: use IIO_CHAN_INFO_PROCESSED only
> >  - adc: use devm_iio_triggered_buffer_setup
> >  - adc: use use s64 to record timestamp
> > 
> > changelogs between v2 & v3
> >  - Rearrange include file order by alphabet
> >  - Set line length constraint below 100
> >  - Add Document for testing adc sysfs node guideline
> >  - Set compiler 64 bit aligned when handle iio timestamp
> > 
> > changelogs between v3 & v4
> >  - Fix sysfs guideline description
> >  - Replace iio channel processed by raw/scale/offset
> >  - Add comment of read adc flow for special HW design
> > 
> > changelogs between v4 & v5
> >  - Rename dt-bindings aligned to file name
> >  - Aligned sysfs node name with driver and add VBUSDIVX description
> >  - Add ADC channel sysfs node "*_labels"
> > 
> > changelogs between v5 & v6
> >  - Memset aligned adc data
> >  - Remove strong casting void pointer
> > 
> > changelogs between v6 & v7
> >  - Avoid adc polling infinite loop
> >   
>