[v3,0/2] Add Ingenic SoCs MAC support.

Message

Zhou Yanjie June 14, 2021, 5:15 p.m. UTC

v2->v3:
1.Add "ingenic,mac.yaml" for Ingenic SoCs.
2.Change tx clk delay and rx clk delay from hardware value to ps.
3.return -EINVAL when a unsupported value is encountered when
  parsing the binding.
4.Simplify the code of the RGMII part of X2000 SoC according to
  Andrew Lunn’s suggestion.
5.Follow the example of "dwmac-mediatek.c" to improve the code
  that handles delays according to Andrew Lunn’s suggestion.

周琰杰 (Zhou Yanjie) (2):
  dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
  net: stmmac: Add Ingenic SoCs MAC support.

 .../devicetree/bindings/net/ingenic,mac.yaml       |  76 ++++
 .../devicetree/bindings/net/snps,dwmac.yaml        |  15 +
 drivers/net/ethernet/stmicro/stmmac/Kconfig        |  12 +
 drivers/net/ethernet/stmicro/stmmac/Makefile       |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac-ingenic.c    | 401 +++++++++++++++++++++
 5 files changed, 505 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/ingenic,mac.yaml
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c

Comments

[e-mail] June 14, 2021, 8:20 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Tue, 15 Jun 2021 01:15:35 +0800 you wrote:
> v2->v3:
> 1.Add "ingenic,mac.yaml" for Ingenic SoCs.
> 2.Change tx clk delay and rx clk delay from hardware value to ps.
> 3.return -EINVAL when a unsupported value is encountered when
>   parsing the binding.
> 4.Simplify the code of the RGMII part of X2000 SoC according to
>   Andrew Lunn’s suggestion.
> 5.Follow the example of "dwmac-mediatek.c" to improve the code
>   that handles delays according to Andrew Lunn’s suggestion.
> 
> [...]

Here is the summary with links:
  - [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
    https://git.kernel.org/netdev/net-next/c/3b8401066e5a
  - [v3,2/2] net: stmmac: Add Ingenic SoCs MAC support.
    https://git.kernel.org/netdev/net-next/c/2bb4b98b60d7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Rob Herring June 15, 2021, 11:03 p.m. UTC | #2

On Mon, Jun 14, 2021 at 2:20 PM <[e-mail]> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (refs/heads/master):
>
> On Tue, 15 Jun 2021 01:15:35 +0800 you wrote:
> > v2->v3:
> > 1.Add "ingenic,mac.yaml" for Ingenic SoCs.
> > 2.Change tx clk delay and rx clk delay from hardware value to ps.
> > 3.return -EINVAL when a unsupported value is encountered when
> >   parsing the binding.
> > 4.Simplify the code of the RGMII part of X2000 SoC according to
> >   Andrew Lunn’s suggestion.
> > 5.Follow the example of "dwmac-mediatek.c" to improve the code
> >   that handles delays according to Andrew Lunn’s suggestion.
> >
> > [...]
>
> Here is the summary with links:
>   - [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
>     https://git.kernel.org/netdev/net-next/c/3b8401066e5a
>   - [v3,2/2] net: stmmac: Add Ingenic SoCs MAC support.
>     https://git.kernel.org/netdev/net-next/c/2bb4b98b60d7

Perhaps 3 hours is not sufficient time to review. It may be a v3, but
the binding appears to have changed quite a bit in addition to being
broken.

Rob