From patchwork Mon Jan 21 07:18:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pi-Hsun Shih X-Patchwork-Id: 10772641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9C34391E for ; Mon, 21 Jan 2019 07:18:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 808F229F0D for ; Mon, 21 Jan 2019 07:18:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 711C029F0F; Mon, 21 Jan 2019 07:18:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0306F29F0D for ; Mon, 21 Jan 2019 07:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=JBqzteYwqyrprSTbx4WlUACQaj9mbbJ/yqAns8zoOkE=; b=XNfnBMop50QBhY ilCL1odfIM8G1TfY3tmTs9I2jF+bDqpguCcZQfBVeX9eZMHr3XGH37L/Tn2t8Q3gyxgXe43EODS7w mjzveKOFrblBHSruGvIRJZFKlJl3GI5B9EDQbwFPexp+R1LSdrvjTDCmQZ9Q0znRAZbxlBSo0zQ6F IBG8k8WgN/1hGPxsfw0VNo6FxqtOL/fldqPhBPKTSim7DDK2KiINHAyjAgxX/3m9UCc8drPzhYf1a Cqji9vRo+HQp8bo7I/v7vwZX4dZloVZavdSrgWz/Q+VV05ytBEVHDeTu5QK/iwDCOaUz9rgfpgQr4 CXOgkSNyxEN5CYAf4ZEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glTqz-0000n0-Fe; Mon, 21 Jan 2019 07:18:41 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glTqx-0000mK-6K for linux-mediatek@lists.infradead.org; Mon, 21 Jan 2019 07:18:40 +0000 Received: by mail-pg1-x543.google.com with SMTP id c25so9059720pgb.4 for ; Sun, 20 Jan 2019 23:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6nGVfT8DBAMLYYNva9uGnefQdoalESvO1Aa5MDGIIVc=; b=fYN6BbVrU/gMF6Av5OwYaeDCI14V7YDqXEnQGPBR56VdAdOeAuTxpzqMg+n/OP5wmZ JDAxfNgRamHJhgi0k4swB0jpkZ1GQWPVVCdG8/AwcreGvZvUwa1Gm0kUs9aHtnZDmO5y Led74YLuz11HIcppG81PXssc7+cR98d9xDQVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6nGVfT8DBAMLYYNva9uGnefQdoalESvO1Aa5MDGIIVc=; b=EkJ7Jr7vwYGLG/Hwvx/f3HHaHLsKadTPBvsryOVbIktJVHvv8HYNOyki9lXD+F2Qmj NBUc7mhK/ht7nPBsZBzl8jOpD7PNkOi64zXSS/7J6olwB0rfmThWNTQX9fz5OjH013x/ rBiLURa4g+VBcqE7ShgC0ck4T9gtrODAj81HzAYyFynVYIknEtc5UcwowAB/ScghNr6O EVrvINEc9lt+0FppLVI4CuZamTcgG7zMLaCGOogjYd5ffp88IhRkvaGknNtl5MkEWB6i 5sNZ/aUEUt7pj8f8CX5QGSrGMNOCxVXUXh5KyYsjTdoBKFip2LP+VomyHM2S+1FE5f41 9ZpQ== X-Gm-Message-State: AJcUukc9j4K/PDoodmLAMJOuzb5LZPt/hEJ2oxn2eMzcRVhP1aW1MXxG Fjg28J+ZWE7Zr3FJyPzUNTmOMGqbisTW1w== X-Google-Smtp-Source: ALg8bN5UDnYyvb5OngueUpHvUdqg0KIAc3Te6rI7QWqYCrvKNjqdbdWxrmLl/vFUNGmHWq7cRrVbog== X-Received: by 2002:a63:d604:: with SMTP id q4mr26838953pgg.175.1548055118513; Sun, 20 Jan 2019 23:18:38 -0800 (PST) Received: from pihsun-z840.tpe.corp.google.com ([2401:fa00:1:10:7889:7a43:f899:134c]) by smtp.googlemail.com with ESMTPSA id v15sm14941843pfn.94.2019.01.20.23.18.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jan 2019 23:18:37 -0800 (PST) From: Pi-Hsun Shih To: Subject: [RFC v3 0/5] Add support for mt8183 SCP. Date: Mon, 21 Jan 2019 15:18:28 +0800 Message-Id: <20190121071833.43443-1-pihsun@chromium.org> X-Mailer: git-send-email 2.20.1.321.g9e740568ce-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190120_231839_257199_1114B6E1 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthias Brugger , Nicolas Boichat , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Add support for controlling and communicating with mt8183's system control processor (SCP), using the remoteproc & rpmsg framework. And also add a cros_ec driver for CrOS EC host command over rpmsg. The overall structure of the series is: * remoteproc/mtk_scp.c: Control the start / stop of SCP (Patch 2). * remoteproc/mtk_scp_ipi.c: Communicates to SCP using inter-processor interrupt (IPI) and shared memory (Patch 2). * rpmsg/mtk_rpmsg.c: Wrapper to wrap the IPI communication into a rpmsg device. Supports name service for SCP firmware to announce channels (Patch 3). * platform/chrome/cros_ec_rpmsg.c: Communicates with the SCP over the rpmsg framework (like what platform/chrome/cros_ec_{i2c,spi}.c does) (Patch 4). Since I'm not familiar with the remoteproc / rpmsg framework, and there are not much other custom rpmsg driver for reference, would like some review / comments on the overall structure of the driver. Changes from v2: - Fold patch 3 into patch 2 in v2. - Move IPI id around to support cross-testing for old and new firmware. - Finish more TODO items. Changes from v1: - Extract functions and rename variables in mtk_scp.c. - Do cleanup properly in mtk_rpmsg.c, which also removes the problem of short-lived work items. - Code format fix based on feedback for cros_ec_rpmsg.c. - Extract feature detection for SCP into separate patch (Patch 6). Erin Lo (2): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 Pi-Hsun Shih (3): rpmsg: add rpmsg support for mt8183 SCP. mfd: add EC host command support using rpmsg. cros_ec: differentiate SCP from EC by feature bit. .../bindings/remoteproc/mtk,scp.txt | 10 + drivers/mfd/cros_ec_dev.c | 9 + drivers/platform/chrome/Kconfig | 8 + drivers/platform/chrome/Makefile | 1 + drivers/platform/chrome/cros_ec_rpmsg.c | 186 +++++++ drivers/remoteproc/Kconfig | 9 + drivers/remoteproc/Makefile | 1 + drivers/remoteproc/mtk_common.h | 75 +++ drivers/remoteproc/mtk_scp.c | 460 ++++++++++++++++++ drivers/remoteproc/mtk_scp_ipi.c | 127 +++++ drivers/rpmsg/Kconfig | 8 + drivers/rpmsg/Makefile | 1 + drivers/rpmsg/mtk_rpmsg.c | 395 +++++++++++++++ include/linux/mfd/cros_ec.h | 1 + include/linux/mfd/cros_ec_commands.h | 2 + include/linux/platform_data/mtk_scp.h | 137 ++++++ include/linux/rpmsg/mtk_rpmsg.h | 35 ++ 17 files changed, 1465 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt create mode 100644 drivers/platform/chrome/cros_ec_rpmsg.c create mode 100644 drivers/remoteproc/mtk_common.h create mode 100644 drivers/remoteproc/mtk_scp.c create mode 100644 drivers/remoteproc/mtk_scp_ipi.c create mode 100644 drivers/rpmsg/mtk_rpmsg.c create mode 100644 include/linux/platform_data/mtk_scp.h create mode 100644 include/linux/rpmsg/mtk_rpmsg.h