| Message ID | 20190409065307.82280-1-wangyan.wang@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | make mt7623 clock of hdmi stable | expand |
Hi, Wangyan: This version still has alignment problem, but I've fixed it and for this series, Applied to mediatek-drm-fixes-5.1 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.1 Regards, CK On Tue, 2019-04-09 at 14:53 +0800, wangyan wang wrote: > From: Wangyan Wang <wangyan.wang@mediatek.com> > > V10 adopt maintainer's suggestion. > Here is the change list between V9 & V10 > > 1. Align the first character to the right of '(' in > mtk_hdmi_phy_clk_get_data() of "drm/mediatek: remove flag ..." > 2. Align the first character to the right of '(' in > mtk_hdmi_pll_recalc_rate() of "drm/mediatek: make implementation ..." > 3. Align the first character to the right of '(' in > mtk_hdmi_pll_round_rate() of "drm/mediatek: no change ..." > 4. move patch " drm/mediatek: make implementation ..." before > patch "drm/mediatek: no change parent ..." > 5. To make MT2701 HDMI stable, TVDPLL should not be adjusted and > it's the parent clock of HDMI phy, so HDMI phy could not adjust parent > rate. there are 3 steps to make MT2701 HDMI stable. > 1). remove flag CLK_SET_RATE_PARENT for mt2701 hdmi phy to not propagate > rate change to parent in "drm/mediatek: remove flag ...". > 2). Using new factor for tvdpll in mt2701 to match divider of DPI in > mt2701 in "drm/mediatek: using new...". > 3). No change parent rate in round_rate() for mt2701 hdmi phy in > "drm/mediatek: no change parent...". > > 6. Recalculate the rate of this clock, by querying hardware to > make implementation of recalc_rate() to match the definition. > > Wangyan Wang (5): > drm/mediatek: remove flag CLK_SET_RATE_PARENT for mt2701 hdmi phy > drm/mediatek: fix the rate and divder of hdmi phy for MT2701 > drm/mediatek: using new factor for tvdpll in MT2701 > drm/mediatek: make implementation of recalc_rate() to match the definition > drm/mediatek: no change parent rate in round_rate() for mt2701 hdmi phy > > 03_27_ck.diff | 91 ++++++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +-- > drivers/gpu/drm/mediatek/mtk_hdmi_phy.c | 35 ++-------- > drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 5 +- > drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 50 ++++++++++++-- > drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 23 +++++++ > patch1.diff | 75 ++++++++++++++++++++ > patch_5_4.diff | 95 ++++++++++++++++++++++++++ > remove_parent_flag.diff | 75 ++++++++++++++++++++ > 9 files changed, 412 insertions(+), 45 deletions(-) > create mode 100644 03_27_ck.diff > create mode 100644 patch1.diff > create mode 100644 patch_5_4.diff > create mode 100644 remove_parent_flag.diff >
Hi, have you got hdmi on mt7623 and kernel 5.1 working? i have applied this patchset, the clockpatch and some additional Patches like dts for bananapi r2 here, but i can't get hdmi (xserver) running https://github.com/frank-w/BPI-R2-4.14/commits/5.1-hdmi-v10 found no errors in dmesg, also no error when starting xserver, but it still shows nothing 5.0 works with xserver: https://github.com/frank-w/BPI-R2-4.14/commits/5.0-hdmi anyone can guide me get it working? regards Frank > Gesendet: Dienstag, 09. April 2019 um 11:55 Uhr > Von: "CK Hu" <ck.hu@mediatek.com> > An: "wangyan wang" <wangyan.wang@mediatek.com> > Cc: "Ryder Lee" <ryder.lee@mediatek.com>, "Philipp Zabel" <p.zabel@pengutronix.de>, srv_heupstream@mediatek.com, "chunhui dai" <chunhui.dai@mediatek.com>, "Stephen Boyd" <sboyd@kernel.org>, "Michael Turquette" <mturquette@baylibre.com>, "Sean Wang" <sean.wang@mediatek.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "David Airlie" <airlied@linux.ie>, linux-mediatek@lists.infradead.org, "Daniel Vetter" <daniel@ffwll.ch>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Colin Ian King" <colin.king@canonical.com>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org > Betreff: Re: [PATCH V10 0/5] make mt7623 clock of hdmi stable > > Hi, Wangyan: > > This version still has alignment problem, but I've fixed it and for this > series, > > Applied to mediatek-drm-fixes-5.1 [1], thanks. > > [1] > https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.1 > > Regards, > CK
Hi,
i got xserver and Framebuffer working on bananapi-r2/mt7623
see https://github.com/frank-w/BPI-R2-4.14/commits/5.1-hdmi-v10 for the used commits
i squashed some fixes into the original commits ("drm/mediatek: config component output by device node port","arm: dts: mt7623: add display subsystem related device nodes"), because they are not yet merged. hope this is ok
basicly these commits are needed on top of 5.1-rc5
3d72b35d4688 arm: dts: mt7623: add display subsystem related device nodes
176a2d716c5f fix boot up for 720 and 480 but 1080
f30d3fbc0e6e [hdmi] fix possible_crtcs
8cbd07f230dc drm/mediatek: config component output by device node port
take a look over it and please send it to mainline ;) because the clock-fixes and framebuffer (2 commits) already merged.
regards Frank
From: Wangyan Wang <wangyan.wang@mediatek.com> V10 adopt maintainer's suggestion. Here is the change list between V9 & V10 1. Align the first character to the right of '(' in mtk_hdmi_phy_clk_get_data() of "drm/mediatek: remove flag ..." 2. Align the first character to the right of '(' in mtk_hdmi_pll_recalc_rate() of "drm/mediatek: make implementation ..." 3. Align the first character to the right of '(' in mtk_hdmi_pll_round_rate() of "drm/mediatek: no change ..." 4. move patch " drm/mediatek: make implementation ..." before patch "drm/mediatek: no change parent ..." 5. To make MT2701 HDMI stable, TVDPLL should not be adjusted and it's the parent clock of HDMI phy, so HDMI phy could not adjust parent rate. there are 3 steps to make MT2701 HDMI stable. 1). remove flag CLK_SET_RATE_PARENT for mt2701 hdmi phy to not propagate rate change to parent in "drm/mediatek: remove flag ...". 2). Using new factor for tvdpll in mt2701 to match divider of DPI in mt2701 in "drm/mediatek: using new...". 3). No change parent rate in round_rate() for mt2701 hdmi phy in "drm/mediatek: no change parent...". 6. Recalculate the rate of this clock, by querying hardware to make implementation of recalc_rate() to match the definition. Wangyan Wang (5): drm/mediatek: remove flag CLK_SET_RATE_PARENT for mt2701 hdmi phy drm/mediatek: fix the rate and divder of hdmi phy for MT2701 drm/mediatek: using new factor for tvdpll in MT2701 drm/mediatek: make implementation of recalc_rate() to match the definition drm/mediatek: no change parent rate in round_rate() for mt2701 hdmi phy 03_27_ck.diff | 91 ++++++++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +-- drivers/gpu/drm/mediatek/mtk_hdmi_phy.c | 35 ++-------- drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 5 +- drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 50 ++++++++++++-- drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 23 +++++++ patch1.diff | 75 ++++++++++++++++++++ patch_5_4.diff | 95 ++++++++++++++++++++++++++ remove_parent_flag.diff | 75 ++++++++++++++++++++ 9 files changed, 412 insertions(+), 45 deletions(-) create mode 100644 03_27_ck.diff create mode 100644 patch1.diff create mode 100644 patch_5_4.diff create mode 100644 remove_parent_flag.diff