[v4,0/8] scsi: ufs: some cleanups and make the delay for host enabling customizable

Message

Stanley Chu March 13, 2020, 9 a.m. UTC

Hi,

This patchset applies some driver cleanups and performance improvement
in ufs host drivers by making the delay for host enabling customizable
according to vendors' requirements.

v3 -> v4
	- Collect review tags in v2
	- In patch #8, fix incorrect condition of customized delay for host enabling

v2 -> v3
	- Remove /arch/arm64/configs/defconfig chnage because it is for local test only

v1 -> v2
	- Add patch #1 "scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc"
	- Remove struct ufs_init_prefetch in patch #2 "scsi: ufs: remove init_prefetch_data in struct ufs_hba"
	- Introduce common delay function in patch #4
	- Replace all delay places by common delay function in ufs-mediatek in patch #5
	- Use common delay function instead for host enabling delay in patch #6
	- Add patch #7 "scsi: ufs: make HCE polling more compact to improve initializatoin latency"
	- In patch #8, customize the delay in ufs_mtk_hce_enable_notify callback instead of ufs_mtk_init (Avri)

 drivers/scsi/ufs/ufs-mediatek.c | 64 ++++++++++++++++-----------
 drivers/scsi/ufs/ufs-mediatek.h |  1 +
 drivers/scsi/ufs/ufshcd.c       | 47 +++++++++++---------
 drivers/scsi/ufs/ufshcd.h       | 78 ++++++++++++++++-----------------
 4 files changed, 106 insertions(+), 84 deletions(-)

Comments

Avri Altman March 14, 2020, 9:47 a.m. UTC | #1

Looks good to me.
Thanks,
Avri

 
> 
> Hi,
> 
> This patchset applies some driver cleanups and performance improvement
> in ufs host drivers by making the delay for host enabling customizable
> according to vendors' requirements.
> 
> v3 -> v4
>         - Collect review tags in v2
>         - In patch #8, fix incorrect condition of customized delay for host
> enabling
> 
> v2 -> v3
>         - Remove /arch/arm64/configs/defconfig chnage because it is for local
> test only
> 
> v1 -> v2
>         - Add patch #1 "scsi: ufs: fix uninitialized tx_lanes in
> ufshcd_disable_tx_lcc"
>         - Remove struct ufs_init_prefetch in patch #2 "scsi: ufs: remove
> init_prefetch_data in struct ufs_hba"
>         - Introduce common delay function in patch #4
>         - Replace all delay places by common delay function in ufs-mediatek in
> patch #5
>         - Use common delay function instead for host enabling delay in patch #6
>         - Add patch #7 "scsi: ufs: make HCE polling more compact to improve
> initializatoin latency"
>         - In patch #8, customize the delay in ufs_mtk_hce_enable_notify
> callback instead of ufs_mtk_init (Avri)
> 
>  drivers/scsi/ufs/ufs-mediatek.c | 64 ++++++++++++++++-----------
>  drivers/scsi/ufs/ufs-mediatek.h |  1 +
>  drivers/scsi/ufs/ufshcd.c       | 47 +++++++++++---------
>  drivers/scsi/ufs/ufshcd.h       | 78 ++++++++++++++++-----------------
>  4 files changed, 106 insertions(+), 84 deletions(-)
> 
> --
> 2.18.0