| Message ID | 20200508080115.24233-1-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: ufs: support LU Dedicated buffer mode for WriteBooster | expand |
This series looks good to me. Thanks, Avri > > > Hi, > This patchset adds LU dedicated buffer mode support for WriteBooster. > In the meanwhile, enable WriteBooster capability on MediaTek UFS > platforms. > > v7 -> v8: > - In exported funtion ufshcd_fixup_dev_quirks(), add null checking for > parameter "fixups" (Avri Altman) > > v6 -> v7: > - Add device descriptor length check in ufshcd_wb_probe() back to prevent > out-of-boundary access in ufshcd_wb_probe() > - Fix the check of device descriptor length (Avri Altman) > - Provide a new ufs_fixup_device_setup() function to pack both device fixup > methods by general quirk table and vendor-specific way (Avri Altman) > > v5 -> v6: > - Remove device descriptor length check in ufshcd_wb_probe() > > v4 -> v5: > - Check LUN ID for available WriteBooster buffer only from 0 to 7 according > to spec (Avri Altman) > - Skip checking any possible errors from ufshcd_read_unit_desc_param(hba, > lun, UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) in ufshcd_wb_probe() and > check returned d_lu_wb_buf_alloc (shall be zero if error happens) (Avri > Altman) > > v3 -> v4: > - Introduce "fixup_dev_quirks" vops to allow vendors to fix and modify > device quirks, and provide an initial vendor-specific device quirk table on > MediaTek UFS platforms > - Avoid relying on common device quirk table for pre-3.1 UFS device with > non-standard WriteBooster support (Can Guo) > - Fix comments for ufshcd_wb_probe() (Can Guo) > - Make ufshcd_wb_get_flag_index() inline and fix ufshcd_is_wb_flags() (Avri > Altman) > > v2 -> v3: > - Introduce a device quirk to support WriteBooster in pre-3.1 UFS devices > (Avri Altman) > - Fix WriteBooster related sysfs nodes. Now all WriteBooster related sysfs > nodes are specifically mapped to the LUN with WriteBooster enabled in LU > Dedicated buffer mode (Avri Altman) > > v1 -> v2: > - Change the definition name of WriteBooster buffer mode to correspond > to specification (Bean Huo) > - Add patch #5: "scsi: ufs: cleanup WriteBooster feature" > > Stanley Chu (8): > scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices > scsi: ufs: introduce fixup_dev_quirks vops > scsi: ufs: export ufs_fixup_device_setup() function > scsi: ufs-mediatek: add fixup_dev_quirks vops > scsi: ufs: add "index" in parameter list of ufshcd_query_flag() > scsi: ufs: add LU Dedicated buffer mode support for WriteBooster > scsi: ufs-mediatek: enable WriteBooster capability > scsi: ufs: cleanup WriteBooster feature > > drivers/scsi/ufs/ufs-mediatek.c | 25 ++++- > drivers/scsi/ufs/ufs-sysfs.c | 11 ++- > drivers/scsi/ufs/ufs.h | 10 ++ > drivers/scsi/ufs/ufs_quirks.h | 7 ++ > drivers/scsi/ufs/ufshcd.c | 166 +++++++++++++++++++++----------- > drivers/scsi/ufs/ufshcd.h | 19 +++- > 6 files changed, 176 insertions(+), 62 deletions(-) > > -- > 2.18.0
On Fri, 8 May 2020 16:01:07 +0800, Stanley Chu wrote: > This patchset adds LU dedicated buffer mode support for WriteBooster. > In the meanwhile, enable WriteBooster capability on MediaTek UFS platforms. > > v7 -> v8: > - In exported funtion ufshcd_fixup_dev_quirks(), add null checking for parameter "fixups" (Avri Altman) > > v6 -> v7: > - Add device descriptor length check in ufshcd_wb_probe() back to prevent out-of-boundary access in ufshcd_wb_probe() > - Fix the check of device descriptor length (Avri Altman) > - Provide a new ufs_fixup_device_setup() function to pack both device fixup methods by general quirk table and vendor-specific way (Avri Altman) > > [...] Applied to 5.8/scsi-queue, thanks! [1/8] scsi: ufs: Enable WriteBooster on some pre-3.1 UFS devices https://git.kernel.org/mkp/scsi/c/817d7e140283 [2/8] scsi: ufs: Introduce fixup_dev_quirks vops https://git.kernel.org/mkp/scsi/c/c28c00ba4f06 [3/8] scsi: ufs: Export ufs_fixup_device_setup() function https://git.kernel.org/mkp/scsi/c/8db269a5102e [4/8] scsi: ufs-mediatek: Add fixup_dev_quirks vops https://git.kernel.org/mkp/scsi/c/62c2f503b54c [5/8] scsi: ufs: Add "index" in parameter list of ufshcd_query_flag() https://git.kernel.org/mkp/scsi/c/1f34eedf9bc1 [6/8] scsi: ufs: Add LU Dedicated buffer mode support for WriteBooster https://git.kernel.org/mkp/scsi/c/6f8d5a6a78cf [7/8] scsi: ufs-mediatek: Enable WriteBooster capability https://git.kernel.org/mkp/scsi/c/29060a629135 [8/8] scsi: ufs: Cleanup WriteBooster feature https://git.kernel.org/mkp/scsi/c/79e3520f82cb