| Message ID | 20200803062214.24076-1-mark-pk.tsai@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | irqchip: irq-mt58xx: Add mt58xx series interrupt | expand |
Hi Mark-PK, Your driver seems to be for the same interrupt controller IP that is present in MStar's TV and camera SoCs and now SigmaStar's SoCs. I sent a series[0] for a driver very similar to yours but for the MStar SoCs. Do you know if it would be possible to confirm if they are the same thing? MediaTek bought MStar a few years ago so it seems likely but I have no hard information. If they are the same thing could we work on making one series that supports both use cases? It's also possible that if the interrupt controller is the same some other things like the SPI NOR controller etc are also common and working on a single driver for those would save us both time. [0] - https://lore.kernel.org/linux-arm-kernel/20200805110052.2655487-1-daniel@0x0f.com/
From: Daniel Palmer <daniel@0x0f.com> > Hi Mark-PK, > > Your driver seems to be for the same interrupt controller IP that is > present in MStar's TV and camera SoCs and now SigmaStar's SoCs. > I sent a series[0] for a driver very similar to yours but for the > MStar SoCs. Do you know if it would be possible to confirm if they are > the > same thing? MediaTek bought MStar a few years ago so it seems likely > but I have no hard information. > Yes, it's for the same interrupt controller IP. > If they are the same thing could we work on making one series that > supports both use cases? Sure, and I think the irq controller driver should support both use cases. So how about keep the MTK version driver? I'll send patch v2 after -rc1 as I mentioned in the previous mail, and keep you posted. And any suggestion is welcome. :) > It's also possible that if the interrupt controller is the same some > other things like the SPI NOR controller etc are also common and > working > on a single driver for those would save us both time. > I'm not sure about that. I'll check the patches you contributed and confirm with our driver owners.
Hi Mark-PK, On Thu, 6 Aug 2020 at 23:08, Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote: > > Do you know if it would be possible to confirm if they are > > the > > same thing? MediaTek bought MStar a few years ago so it seems likely > > but I have no hard information. > > > > Yes, it's for the same interrupt controller IP. That's good news. :) > > If they are the same thing could we work on making one series that > > supports both use cases? > > Sure, and I think the irq controller driver should support both use cases. > So how about keep the MTK version driver? I'm fine with that. Maybe you can push the MTK version and I can send a small patch after that to add the small bits I need? > I'll send patch v2 after -rc1 as I mentioned in the previous mail, > and keep you posted. > And any suggestion is welcome. :) I think Marc's comments on my series apply to your driver and I think maybe answer some of the questions you had. For example what to do about the read-modify-write sequence for updating the registers. > > It's also possible that if the interrupt controller is the same some > > other things like the SPI NOR controller etc are also common and > > working > > on a single driver for those would save us both time. > > I'm not sure about that. > I'll check the patches you contributed and confirm with our driver owners. I have a very messy tree with support for the SPI NOR controller, SPI, i2c etc that were used in MStar chips. If any of those are shared it'd be great to know. Thanks, Daniel
On 2020-08-06 15:58, Daniel Palmer wrote: > Hi Mark-PK, > > On Thu, 6 Aug 2020 at 23:08, Mark-PK Tsai <mark-pk.tsai@mediatek.com> > wrote: >> > Do you know if it would be possible to confirm if they are >> > the >> > same thing? MediaTek bought MStar a few years ago so it seems likely >> > but I have no hard information. >> > >> >> Yes, it's for the same interrupt controller IP. > > That's good news. :) > >> > If they are the same thing could we work on making one series that >> > supports both use cases? >> >> Sure, and I think the irq controller driver should support both use >> cases. >> So how about keep the MTK version driver? > > I'm fine with that. Maybe you can push the MTK version and I can send > a small patch after that to add the small bits I need? In the interest of being vendor agnostic, please rename the properties such as mediatek,irqs-map-range to something less brand-specific. The compatible string should be enough. Thanks, M.
From: Marc Zyngier <maz@kernel.org> > On 2020-08-06 15:58, Daniel Palmer wrote: > > Hi Mark-PK, > > > > On Thu, 6 Aug 2020 at 23:08, Mark-PK Tsai <mark-pk.tsai@mediatek.com> > > wrote: > >> > Do you know if it would be possible to confirm if they are > >> > the > >> > same thing? MediaTek bought MStar a few years ago so it seems likely > >> > but I have no hard information. > >> > > >> > >> Yes, it's for the same interrupt controller IP. > > > > That's good news. :) > > > >> > If they are the same thing could we work on making one series that > >> > supports both use cases? > >> > >> Sure, and I think the irq controller driver should support both use > >> cases. > >> So how about keep the MTK version driver? > > > > I'm fine with that. Maybe you can push the MTK version and I can send > > a small patch after that to add the small bits I need? > > In the interest of being vendor agnostic, please rename the properties > such as mediatek,irqs-map-range to something less brand-specific. > The compatible string should be enough. I can't find the suitable property in standard ones that match the custom properties here. And the vendor prefixed rule is described in [1]. The interrupt controller is first used in Mstar TV SoCs. Now it's used in MTK TV and Sigmastar SoCs. So I think Mstar prefixed would make more sense. I will rename the driver into mstar-intc, and MTK will maintain this driver. [1] https://www.kernel.org/doc/Documentation/devicetree/booting-without-of.txt