mbox series

[0/7] Input: mtk-pmic-keys - add support for MT6358

Message ID 20210428164219.1115537-1-mkorpershoek@baylibre.com (mailing list archive)
Headers show
Series Input: mtk-pmic-keys - add support for MT6358 | expand

Message

Mattijs Korpershoek April 28, 2021, 4:42 p.m. UTC 
The MediaTek MT6358 PMIC has support for two buttons: PWR and HOME.

The interrupt logic is a little different than other PMICs from the
same family:
* for MT6323 and MT6397, we have one interrupt source per button
* for MT6358, we have two interrupts lines per button: the press and
* release interrupts are distinct sources.

These series:
* Fix a NULL ptr error when we use mtk-pmic-keys without dts code
* Rework the mt6397 driver to prepare for this different interrupt logic
* Add support for the MT6358 power buttons

This has been functionally tested (using evtest) on
the mt8183-pumpkin board on linux/master

It has also been used for a couple of months in a downstream
tree based on v5.4.

Mattijs Korpershoek (7):
  Input: mtk-pmic-keys - check for NULL on of_match_device()
  mfd: mt6397: add mt6358 register definitions for power key
  mfd: mt6397: keys: use named IRQs instead of index
  dt-bindings: input: mtk-pmic-keys: add MT6358 binding definition
  Input: mtk-pmic-keys - add support for MT6358
  mfd: mt6397: Add PMIC keys for MT6358
  arm64: dts: mt6358: add mt6358-keys node

 .../bindings/input/mtk-pmic-keys.txt          |  5 +-
 arch/arm64/boot/dts/mediatek/mt6358.dtsi      | 12 ++++
 drivers/input/keyboard/mtk-pmic-keys.c        | 59 +++++++++++++++++--
 drivers/mfd/mt6397-core.c                     | 20 +++++--
 include/linux/mfd/mt6358/registers.h          |  2 +
 5 files changed, 89 insertions(+), 9 deletions(-)


base-commit: 4a0225c3d208cfa6e4550f2210ffd9114a952a81

Comments

Mattijs Korpershoek April 29, 2021, 2:57 p.m. UTC | #1 
Hi Matthias, Dmitry, Lee,

Mattijs Korpershoek <mkorpershoek@baylibre.com> writes:

Please ignore this series for now

> The MediaTek MT6358 PMIC has support for two buttons: PWR and HOME.
>
> The interrupt logic is a little different than other PMICs from the
> same family:
> * for MT6323 and MT6397, we have one interrupt source per button
> * for MT6358, we have two interrupts lines per button: the press and
> * release interrupts are distinct sources.
>
> These series:
> * Fix a NULL ptr error when we use mtk-pmic-keys without dts code
I've submitted this as a separate bugfix [1] to ease the review.

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20210429143811.2030717-1-mkorpershoek@baylibre.com/

> * Rework the mt6397 driver to prepare for this different interrupt logic
> * Add support for the MT6358 power buttons
>
> This has been functionally tested (using evtest) on
> the mt8183-pumpkin board on linux/master
>
> It has also been used for a couple of months in a downstream
> tree based on v5.4.
>
> Mattijs Korpershoek (7):
>   Input: mtk-pmic-keys - check for NULL on of_match_device()
>   mfd: mt6397: add mt6358 register definitions for power key
>   mfd: mt6397: keys: use named IRQs instead of index
>   dt-bindings: input: mtk-pmic-keys: add MT6358 binding definition
>   Input: mtk-pmic-keys - add support for MT6358
I'll send a v2 for these

>   mfd: mt6397: Add PMIC keys for MT6358
>   arm64: dts: mt6358: add mt6358-keys node
>
>  .../bindings/input/mtk-pmic-keys.txt          |  5 +-
>  arch/arm64/boot/dts/mediatek/mt6358.dtsi      | 12 ++++
>  drivers/input/keyboard/mtk-pmic-keys.c        | 59 +++++++++++++++++--
>  drivers/mfd/mt6397-core.c                     | 20 +++++--
>  include/linux/mfd/mt6358/registers.h          |  2 +
>  5 files changed, 89 insertions(+), 9 deletions(-)
>
>
> base-commit: 4a0225c3d208cfa6e4550f2210ffd9114a952a81
> -- 
> 2.27.0