mbox series

[0/5] Revert series "CMDQ refinement of Mediatek DRM driver"

Message ID 20211007235310.14626-1-chunkuang.hu@kernel.org (mailing list archive)
Headers show
Series Revert series "CMDQ refinement of Mediatek DRM driver" | expand

Message

Chun-Kuang Hu Oct. 7, 2021, 11:53 p.m. UTC 
Commit c1ec54b7b5af
("drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb")
would cause numerous mtk cmdq mailbox driver warning:

WARNING: CPU: 0 PID: 0 at drivers/mailbox/mtk-cmdq-mailbox.c:198
cmdq_task_exec_done+0xb8/0xe0

So revert that patch and all the patches depend on that patch.

Chun-Kuang Hu (5):
  Revert "drm/mediatek: Clear pending flag when cmdq packet is done"
  Revert "drm/mediatek: Add cmdq_handle in mtk_crtc"
  Revert "drm/mediatek: Detect CMDQ execution timeout"
  Revert "drm/mediatek: Remove struct cmdq_client"
  Revert "drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb"

 drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 157 ++++--------------------
 1 file changed, 24 insertions(+), 133 deletions(-)

Comments

Enric Balletbo Serra Oct. 8, 2021, 1:33 p.m. UTC | #1 
Hi Chun-Kuang,

Thank you to take time to send this, for full series

Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Display is now working again.

Thanks,
  Enric


Missatge de Chun-Kuang Hu <chunkuang.hu@kernel.org> del dia dv., 8
d’oct. 2021 a les 1:53:
>
> Commit c1ec54b7b5af
> ("drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb")
> would cause numerous mtk cmdq mailbox driver warning:
>
> WARNING: CPU: 0 PID: 0 at drivers/mailbox/mtk-cmdq-mailbox.c:198
> cmdq_task_exec_done+0xb8/0xe0
>
> So revert that patch and all the patches depend on that patch.
>
> Chun-Kuang Hu (5):
>   Revert "drm/mediatek: Clear pending flag when cmdq packet is done"
>   Revert "drm/mediatek: Add cmdq_handle in mtk_crtc"
>   Revert "drm/mediatek: Detect CMDQ execution timeout"
>   Revert "drm/mediatek: Remove struct cmdq_client"
>   Revert "drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb"
>
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 157 ++++--------------------
>  1 file changed, 24 insertions(+), 133 deletions(-)
>
> --
> 2.25.1
>
Chun-Kuang Hu Oct. 12, 2021, 12:13 a.m. UTC | #2 
Enric Balletbo Serra <eballetbo@gmail.com> 於 2021年10月8日 週五 下午9:33寫道：
>
> Hi Chun-Kuang,
>
> Thank you to take time to send this, for full series
>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> Display is now working again.

Applied to mediatek-drm-fixes [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> Thanks,
>   Enric
>
>
> Missatge de Chun-Kuang Hu <chunkuang.hu@kernel.org> del dia dv., 8
> d’oct. 2021 a les 1:53:
> >
> > Commit c1ec54b7b5af
> > ("drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb")
> > would cause numerous mtk cmdq mailbox driver warning:
> >
> > WARNING: CPU: 0 PID: 0 at drivers/mailbox/mtk-cmdq-mailbox.c:198
> > cmdq_task_exec_done+0xb8/0xe0
> >
> > So revert that patch and all the patches depend on that patch.
> >
> > Chun-Kuang Hu (5):
> >   Revert "drm/mediatek: Clear pending flag when cmdq packet is done"
> >   Revert "drm/mediatek: Add cmdq_handle in mtk_crtc"
> >   Revert "drm/mediatek: Detect CMDQ execution timeout"
> >   Revert "drm/mediatek: Remove struct cmdq_client"
> >   Revert "drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb"
> >
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 157 ++++--------------------
> >  1 file changed, 24 insertions(+), 133 deletions(-)
> >
> > --
> > 2.25.1
> >