| Message ID | 20220307122151.11666-1-jia-wei.chang@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | cpufreq: mediatek: introduce mtk cpufreq | expand |
On 07-03-22, 20:21, Tim Chang wrote: > CPUFREQ is DVFS driver used for power saving by scaling clock frequency > and supply voltage of CPUs. This module cooperates with CCI DEVFREQ for > certain Mediatek SoCs. Both subject and this log talks as if you are adding a new cpufreq driver, while what you are doing is just cleanup mostly. This isn't how it should be done. You need to be very explicit with what you are doing and make that change in a separate patch. The cover letter should tell what you are doing and why.
On Tue, 2022-03-08 at 10:06 +0530, Viresh Kumar wrote: > On 07-03-22, 20:21, Tim Chang wrote: > > CPUFREQ is DVFS driver used for power saving by scaling clock > > frequency > > and supply voltage of CPUs. This module cooperates with CCI DEVFREQ > > for > > certain Mediatek SoCs. > > Both subject and this log talks as if you are adding a new cpufreq > driver, while what you are doing is just cleanup mostly. This isn't > how it should be done. > > You need to be very explicit with what you are doing and make that > change in a separate patch. The cover letter should tell what you are > doing and why. > Hello Viresh, Thanks for your suggestion. Indeed, the subject is not proper for this series. I will help to upstream next version and fix the issue because of resource issues. Thanks. BRs, Rex
CPUFREQ is DVFS driver used for power saving by scaling clock frequency and supply voltage of CPUs. This module cooperates with CCI DEVFREQ for certain Mediatek SoCs. Jia-Wei Chang (4): dt-bindings: cpufreq: mediatek: transform cpufreq-mediatek into yaml dt-bindings: cpufreq: mediatek: add mt8186 cpufreq dt-bindings cpufreq: mediatek: clean up cpufreq driver cpufreq: mediatek: add platform data and clean up voltage tracking logic .../bindings/cpufreq/cpufreq-mediatek.yaml | 172 +++++ drivers/cpufreq/mediatek-cpufreq.c | 717 +++++++++--------- 2 files changed, 521 insertions(+), 368 deletions(-) create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.yaml