mbox series

[v3,0/2] MediaTek TTBR up to 35bit support

Message ID 20220512144557.18025-1-yf.wang@mediatek.com (mailing list archive)
Headers show
Series MediaTek TTBR up to 35bit support | expand

Message

yf.wang@mediatek.com May 12, 2022, 2:45 p.m. UTC
This patchset adds MediaTek TTBR up to 35bit support.


Changes in v3:
- Add version changes description, there is No new code change in V3.

Changes in v2:
- Update patch and commit message
  - Add Level 1 pgtable PA up to 35bit.
  - This is new feature, remove stable@vger.kernel.org
  - Update commit message.

Ning Li (2):
  iommu/io-pgtable-arm-v7s: Add a quirk to allow pgtable PA up to 35bit
  iomm/mediatek: Allow page table PA up to 35bit

 drivers/iommu/io-pgtable-arm-v7s.c | 56 ++++++++++++++++++++++--------
 drivers/iommu/mtk_iommu.c          | 29 +++++++++++++---
 include/linux/io-pgtable.h         | 15 +++++---
 3 files changed, 77 insertions(+), 23 deletions(-)

Comments

Yong Wu (吴勇) May 14, 2022, 2:09 a.m. UTC | #1
On Thu, 2022-05-12 at 22:45 +0800, yf.wang@mediatek.com wrote:
> This patchset adds MediaTek TTBR up to 35bit support.
> 
> 
> Changes in v3:
> - Add version changes description, there is No new code change in V3.
> 
> Changes in v2:
> - Update patch and commit message
>   - Add Level 1 pgtable PA up to 35bit.

Why add this for lvl1 pgtable? Did you get real problem?

lvl2 pgtable is allocated/freed dynamically, it may be allocated failed
in ZONE_DMA32 when burning test. But the lvl1 pgtable only is allocated
once after bootup. I think this is no need for lvl1 pgtable.

>   - This is new feature, remove stable@vger.kernel.org
>   - Update commit message.
> 
> Ning Li (2):
>   iommu/io-pgtable-arm-v7s: Add a quirk to allow pgtable PA up to
> 35bit
>   iomm/mediatek: Allow page table PA up to 35bit
> 
>  drivers/iommu/io-pgtable-arm-v7s.c | 56 ++++++++++++++++++++++----
> ----
>  drivers/iommu/mtk_iommu.c          | 29 +++++++++++++---
>  include/linux/io-pgtable.h         | 15 +++++---
>  3 files changed, 77 insertions(+), 23 deletions(-)
> 
>
yf.wang@mediatek.com May 16, 2022, 2:12 p.m. UTC | #2
On Sat, 2022-05-14 at 10:09 +0800, Yong Wu wrote:
> On Thu, 2022-05-12 at 22:45 +0800, yf.wang@mediatek.com wrote:
> > This patchset adds MediaTek TTBR up to 35bit support.
> > 
> > 
> > Changes in v3:
> > - Add version changes description, there is No new code change in
> > V3.
> > 
> > Changes in v2:
> > - Update patch and commit message
> >   - Add Level 1 pgtable PA up to 35bit.
> 
> Why add this for lvl1 pgtable? Did you get real problem?
> 
> lvl2 pgtable is allocated/freed dynamically, it may be allocated
> failed
> in ZONE_DMA32 when burning test. But the lvl1 pgtable only is
> allocated
> once after bootup. I think this is no need for lvl1 pgtable.

Hi Yong,

There is no DMA32 zone in some mediatek smartphone chip.

Thanks,
Yunfei.