| Message ID | 20220610063424.7800-1-moudy.ho@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add mutex support for MDP | expand |
On 10/06/2022 08:34, Moudy Ho wrote: > Change since V19: > - Reduce parameters pass to function "mtk_mutex_write_sof" > to avoid redundant action. > > Change since V18: > - Rebase on v5.19-rc1 > - Remove unnecessary functions: > "mtk_mutex_set_mod", "mtk_mutex_clear_mod", > "mtk_mutex_set_sof" and "mtk_mutex_clear_sof", and export > "mtk_mutex_write_mod" and "mtk_mutex_write_sof" to > set MOD/SOF directly. > - Remove unnecessary SOF tables and add new enumerations of SOF instead. > - Adjust the error checking for CMDQ operations. > > Change since V17: > - Rebase on v5.18-rc6 > - Fix undeclared identifier causing compilation to fail. > > Change since V16: > - Rebase on v5.18-rc4 > - Fix misplacement of definition "CONFIG_MTK_CMDQ" which > caused compilation error when CMD is not supported. > > Change since V15: > - Rebase on linux-next. > - As suggested by Angelo, split common parts into independent functions to > make functions more concise. > - Based on safety considerations, increase the returned error number and > message to facilitate error handling. > > Change since V14: > - Rebase on linux-next. > - Add new SOF and MOD table for general interface to integrate the requirement > of different modules. > - Remove unnecessary MOD structure. > - By Rob Herring's suggestion, revise the description of > "mediatek,gce-client-reg" in MUTEX dt-bindings. > - Delete the redundant definition of MTK_MUTEX_ENABLE and modify corresponding > function. > > Change since V13: > - Rebase on linux-next tag:next-20220316 > - Adjust the MUTEX MOD table structure and corresponding functions. > - Adjust the definition style about 8183 MDP MOD. > - Remove redundant definitions and enumerations. > - Adjust the CMDQ operation in MUTEX to be backward compatible > > Change since V12: > - Rebase on linux-next > - Remove ISP related settings in MMSYS > - Removed CMDQ operations previously used by MDP in MMSYS > - Move mediatek MUTEX dt-binding path > - Add additional property in MUTEX for CMDQ operations > > Change since V11: > - Rebase on v5.17-rc6. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next/soc&id=5f9b5b757e44de47ebdc116c14b90e3cc8bc7acb > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next/soc&id=831785f0e5b919c29e1bc5f9a74e9ebd38289e24 > [3]: https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next/soc&id=15f1768365aed810826a61fef4a744437aa5b426 > > Change since v10: > - For some ISP application scenarios, such as preview and recording > at the same time. > The routing table needs to be discarded, and the calculation result > on the SCP side is used to write a suitable mux setting for > 1 input and 2 output. > - Adjust the GCE client register parsing method to avoid redundant warning logs. > > Change since v9: > - Add API for MDP getting mutex mod. > > Hi, > > This patch splits mmsys and mutex settings from Media Data Path 3 (MDP3), > and original mailling list list below: > https://patchwork.kernel.org/project/linux-mediatek/cover/20211201095031.31606-1-moudy.ho@mediatek.com/ > Corresponding settings and interfaces are added for MDP operation in the > mmsys and mutex drivers, which increases the independence of the modules > > Moudy Ho (6): > soc: mediatek: mutex: add common interface for modules setting > soc: mediatek: mutex: add 8183 MUTEX MOD settings for MDP > dt-bindings: soc: mediatek: move out common module from display folder > dt-bindings: soc: mediatek: add gce-client-reg for MUTEX > dts: arm64: mt8183: add GCE client property for Mediatek MUTEX If fixed the commit subject to arm64: dts: mt8183... Whole series applied, Thanks! > soc: mediatek: mutex: add functions that operate registers by CMDQ > > .../mediatek/mediatek,mutex.yaml | 14 ++- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + > drivers/soc/mediatek/mtk-mutex.c | 119 +++++++++++++++++- > include/linux/soc/mediatek/mtk-mutex.h | 27 ++++ > 4 files changed, 159 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/{display => soc}/mediatek/mediatek,mutex.yaml (81%) >
On Fri, 2022-06-17 at 15:54 +0200, Matthias Brugger wrote: > > On 10/06/2022 08:34, Moudy Ho wrote: > > Change since V19: > > - Reduce parameters pass to function "mtk_mutex_write_sof" > > to avoid redundant action. > > > > Change since V18: > > - Rebase on v5.19-rc1 > > - Remove unnecessary functions: > > "mtk_mutex_set_mod", "mtk_mutex_clear_mod", > > "mtk_mutex_set_sof" and "mtk_mutex_clear_sof", and export > > "mtk_mutex_write_mod" and "mtk_mutex_write_sof" to > > set MOD/SOF directly. > > - Remove unnecessary SOF tables and add new enumerations of SOF > > instead. > > - Adjust the error checking for CMDQ operations. > > > > Change since V17: > > - Rebase on v5.18-rc6 > > - Fix undeclared identifier causing compilation to fail. > > > > Change since V16: > > - Rebase on v5.18-rc4 > > - Fix misplacement of definition "CONFIG_MTK_CMDQ" which > > caused compilation error when CMD is not supported. > > > > Change since V15: > > - Rebase on linux-next. > > - As suggested by Angelo, split common parts into independent > > functions to > > make functions more concise. > > - Based on safety considerations, increase the returned error > > number and > > message to facilitate error handling. > > > > Change since V14: > > - Rebase on linux-next. > > - Add new SOF and MOD table for general interface to integrate the > > requirement > > of different modules. > > - Remove unnecessary MOD structure. > > - By Rob Herring's suggestion, revise the description of > > "mediatek,gce-client-reg" in MUTEX dt-bindings. > > - Delete the redundant definition of MTK_MUTEX_ENABLE and modify > > corresponding > > function. > > > > Change since V13: > > - Rebase on linux-next tag:next-20220316 > > - Adjust the MUTEX MOD table structure and corresponding functions. > > - Adjust the definition style about 8183 MDP MOD. > > - Remove redundant definitions and enumerations. > > - Adjust the CMDQ operation in MUTEX to be backward compatible > > > > Change since V12: > > - Rebase on linux-next > > - Remove ISP related settings in MMSYS > > - Removed CMDQ operations previously used by MDP in MMSYS > > - Move mediatek MUTEX dt-binding path > > - Add additional property in MUTEX for CMDQ operations > > > > Change since V11: > > - Rebase on v5.17-rc6. > > > > [1]: > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next*soc&id=5f9b5b757e44de47ebdc116c14b90e3cc8bc7acb__;Lw!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5DQsUzWs$ > > > > [2]: > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next*soc&id=831785f0e5b919c29e1bc5f9a74e9ebd38289e24__;Lw!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5AuVaksc$ > > > > [3]: > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next*soc&id=15f1768365aed810826a61fef4a744437aa5b426__;Lw!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5NwN4SIb$ > > > > > > Change since v10: > > - For some ISP application scenarios, such as preview and recording > > at the same time. > > The routing table needs to be discarded, and the calculation > > result > > on the SCP side is used to write a suitable mux setting for > > 1 input and 2 output. > > - Adjust the GCE client register parsing method to avoid redundant > > warning logs. > > > > Change since v9: > > - Add API for MDP getting mutex mod. > > > > Hi, > > > > This patch splits mmsys and mutex settings from Media Data Path 3 > > (MDP3), > > and original mailling list list below: > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/cover/20211201095031.31606-1-moudy.ho@mediatek.com/__;!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5Ov7mlf5$ > > > > Corresponding settings and interfaces are added for MDP operation > > in the > > mmsys and mutex drivers, which increases the independence of the > > modules > > > > Moudy Ho (6): > > soc: mediatek: mutex: add common interface for modules setting > > soc: mediatek: mutex: add 8183 MUTEX MOD settings for MDP > > dt-bindings: soc: mediatek: move out common module from display > > folder > > dt-bindings: soc: mediatek: add gce-client-reg for MUTEX > > dts: arm64: mt8183: add GCE client property for Mediatek MUTEX > > If fixed the commit subject to arm64: dts: mt8183... > Whole series applied, > > Thanks! > Hi Matthias, Thanks for the correction, I'll fix it as soon as possible. Regards, Moudy > > soc: mediatek: mutex: add functions that operate registers by > > CMDQ > > > > .../mediatek/mediatek,mutex.yaml | 14 ++- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + > > drivers/soc/mediatek/mtk-mutex.c | 119 > > +++++++++++++++++- > > include/linux/soc/mediatek/mtk-mutex.h | 27 ++++ > > 4 files changed, 159 insertions(+), 2 deletions(-) > > rename Documentation/devicetree/bindings/{display => > > soc}/mediatek/mediatek,mutex.yaml (81%) > >
On 20/06/2022 03:36, moudy.ho wrote: > On Fri, 2022-06-17 at 15:54 +0200, Matthias Brugger wrote: >> >> On 10/06/2022 08:34, Moudy Ho wrote: >>> Change since V19: >>> - Reduce parameters pass to function "mtk_mutex_write_sof" >>> to avoid redundant action. >>> >>> Change since V18: >>> - Rebase on v5.19-rc1 >>> - Remove unnecessary functions: >>> "mtk_mutex_set_mod", "mtk_mutex_clear_mod", >>> "mtk_mutex_set_sof" and "mtk_mutex_clear_sof", and export >>> "mtk_mutex_write_mod" and "mtk_mutex_write_sof" to >>> set MOD/SOF directly. >>> - Remove unnecessary SOF tables and add new enumerations of SOF >>> instead. >>> - Adjust the error checking for CMDQ operations. >>> >>> Change since V17: >>> - Rebase on v5.18-rc6 >>> - Fix undeclared identifier causing compilation to fail. >>> >>> Change since V16: >>> - Rebase on v5.18-rc4 >>> - Fix misplacement of definition "CONFIG_MTK_CMDQ" which >>> caused compilation error when CMD is not supported. >>> >>> Change since V15: >>> - Rebase on linux-next. >>> - As suggested by Angelo, split common parts into independent >>> functions to >>> make functions more concise. >>> - Based on safety considerations, increase the returned error >>> number and >>> message to facilitate error handling. >>> >>> Change since V14: >>> - Rebase on linux-next. >>> - Add new SOF and MOD table for general interface to integrate the >>> requirement >>> of different modules. >>> - Remove unnecessary MOD structure. >>> - By Rob Herring's suggestion, revise the description of >>> "mediatek,gce-client-reg" in MUTEX dt-bindings. >>> - Delete the redundant definition of MTK_MUTEX_ENABLE and modify >>> corresponding >>> function. >>> >>> Change since V13: >>> - Rebase on linux-next tag:next-20220316 >>> - Adjust the MUTEX MOD table structure and corresponding functions. >>> - Adjust the definition style about 8183 MDP MOD. >>> - Remove redundant definitions and enumerations. >>> - Adjust the CMDQ operation in MUTEX to be backward compatible >>> >>> Change since V12: >>> - Rebase on linux-next >>> - Remove ISP related settings in MMSYS >>> - Removed CMDQ operations previously used by MDP in MMSYS >>> - Move mediatek MUTEX dt-binding path >>> - Add additional property in MUTEX for CMDQ operations >>> >>> Change since V11: >>> - Rebase on v5.17-rc6. >>> >>> [1]: >>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next*soc&id=5f9b5b757e44de47ebdc116c14b90e3cc8bc7acb__;Lw!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5DQsUzWs$ >>> >>> [2]: >>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next*soc&id=831785f0e5b919c29e1bc5f9a74e9ebd38289e24__;Lw!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5AuVaksc$ >>> >>> [3]: >>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next*soc&id=15f1768365aed810826a61fef4a744437aa5b426__;Lw!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5NwN4SIb$ >>> >>> >>> Change since v10: >>> - For some ISP application scenarios, such as preview and recording >>> at the same time. >>> The routing table needs to be discarded, and the calculation >>> result >>> on the SCP side is used to write a suitable mux setting for >>> 1 input and 2 output. >>> - Adjust the GCE client register parsing method to avoid redundant >>> warning logs. >>> >>> Change since v9: >>> - Add API for MDP getting mutex mod. >>> >>> Hi, >>> >>> This patch splits mmsys and mutex settings from Media Data Path 3 >>> (MDP3), >>> and original mailling list list below: >>> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/cover/20211201095031.31606-1-moudy.ho@mediatek.com/__;!!CTRNKA9wMg0ARbw!xbP5nA78eRJ8wIp4yFgD5aE4jwxaKHyasyrDibJyg6s4V_rFBmX96_JR5Ov7mlf5$ >>> >>> Corresponding settings and interfaces are added for MDP operation >>> in the >>> mmsys and mutex drivers, which increases the independence of the >>> modules >>> >>> Moudy Ho (6): >>> soc: mediatek: mutex: add common interface for modules setting >>> soc: mediatek: mutex: add 8183 MUTEX MOD settings for MDP >>> dt-bindings: soc: mediatek: move out common module from display >>> folder >>> dt-bindings: soc: mediatek: add gce-client-reg for MUTEX >>> dts: arm64: mt8183: add GCE client property for Mediatek MUTEX >> >> If fixed the commit subject to arm64: dts: mt8183... >> Whole series applied, >> >> Thanks! >> > > Hi Matthias, > > Thanks for the correction, I'll fix it as soon as possible. I already fixed that when I took the series. No action from your side needed. Regards, Matthias > > Regards, > Moudy > >>> soc: mediatek: mutex: add functions that operate registers by >>> CMDQ >>> >>> .../mediatek/mediatek,mutex.yaml | 14 ++- >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + >>> drivers/soc/mediatek/mtk-mutex.c | 119 >>> +++++++++++++++++- >>> include/linux/soc/mediatek/mtk-mutex.h | 27 ++++ >>> 4 files changed, 159 insertions(+), 2 deletions(-) >>> rename Documentation/devicetree/bindings/{display => >>> soc}/mediatek/mediatek,mutex.yaml (81%) >>> >
Change since V19: - Reduce parameters pass to function "mtk_mutex_write_sof" to avoid redundant action. Change since V18: - Rebase on v5.19-rc1 - Remove unnecessary functions: "mtk_mutex_set_mod", "mtk_mutex_clear_mod", "mtk_mutex_set_sof" and "mtk_mutex_clear_sof", and export "mtk_mutex_write_mod" and "mtk_mutex_write_sof" to set MOD/SOF directly. - Remove unnecessary SOF tables and add new enumerations of SOF instead. - Adjust the error checking for CMDQ operations. Change since V17: - Rebase on v5.18-rc6 - Fix undeclared identifier causing compilation to fail. Change since V16: - Rebase on v5.18-rc4 - Fix misplacement of definition "CONFIG_MTK_CMDQ" which caused compilation error when CMD is not supported. Change since V15: - Rebase on linux-next. - As suggested by Angelo, split common parts into independent functions to make functions more concise. - Based on safety considerations, increase the returned error number and message to facilitate error handling. Change since V14: - Rebase on linux-next. - Add new SOF and MOD table for general interface to integrate the requirement of different modules. - Remove unnecessary MOD structure. - By Rob Herring's suggestion, revise the description of "mediatek,gce-client-reg" in MUTEX dt-bindings. - Delete the redundant definition of MTK_MUTEX_ENABLE and modify corresponding function. Change since V13: - Rebase on linux-next tag:next-20220316 - Adjust the MUTEX MOD table structure and corresponding functions. - Adjust the definition style about 8183 MDP MOD. - Remove redundant definitions and enumerations. - Adjust the CMDQ operation in MUTEX to be backward compatible Change since V12: - Rebase on linux-next - Remove ISP related settings in MMSYS - Removed CMDQ operations previously used by MDP in MMSYS - Move mediatek MUTEX dt-binding path - Add additional property in MUTEX for CMDQ operations Change since V11: - Rebase on v5.17-rc6. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next/soc&id=5f9b5b757e44de47ebdc116c14b90e3cc8bc7acb [2]: https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next/soc&id=831785f0e5b919c29e1bc5f9a74e9ebd38289e24 [3]: https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.17-next/soc&id=15f1768365aed810826a61fef4a744437aa5b426 Change since v10: - For some ISP application scenarios, such as preview and recording at the same time. The routing table needs to be discarded, and the calculation result on the SCP side is used to write a suitable mux setting for 1 input and 2 output. - Adjust the GCE client register parsing method to avoid redundant warning logs. Change since v9: - Add API for MDP getting mutex mod. Hi, This patch splits mmsys and mutex settings from Media Data Path 3 (MDP3), and original mailling list list below: https://patchwork.kernel.org/project/linux-mediatek/cover/20211201095031.31606-1-moudy.ho@mediatek.com/ Corresponding settings and interfaces are added for MDP operation in the mmsys and mutex drivers, which increases the independence of the modules Moudy Ho (6): soc: mediatek: mutex: add common interface for modules setting soc: mediatek: mutex: add 8183 MUTEX MOD settings for MDP dt-bindings: soc: mediatek: move out common module from display folder dt-bindings: soc: mediatek: add gce-client-reg for MUTEX dts: arm64: mt8183: add GCE client property for Mediatek MUTEX soc: mediatek: mutex: add functions that operate registers by CMDQ .../mediatek/mediatek,mutex.yaml | 14 ++- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + drivers/soc/mediatek/mtk-mutex.c | 119 +++++++++++++++++- include/linux/soc/mediatek/mtk-mutex.h | 27 ++++ 4 files changed, 159 insertions(+), 2 deletions(-) rename Documentation/devicetree/bindings/{display => soc}/mediatek/mediatek,mutex.yaml (81%)