mbox series

[0/4] ASoC: mt8192: Fixes from initial glance at kselftest run

Message ID 20230223-asoc-mt8192-quick-fixes-v1-0-9a85f90368e1@kernel.org (mailing list archive)
Headers show
Series ASoC: mt8192: Fixes from initial glance at kselftest run | expand

Message

Mark Brown Feb. 24, 2023, 2:03 p.m. UTC
This is a collection of fixes I came up after glancing through an
initial test run with the Spherion Chromebook on KernelCI.  There are
more issues flagged, this is just what I fixed thus far - the volume
controls on the MT6359 have issues for example, and a lot of controls
aren't marked as Switches like they should be.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (4):
      ASoC: mt8192: Remove spammy log messages
      ASoC: mt8192: Fix event generation for controls
      ASoC: mt8192: Report an error if when an invalid sidetone gain is written
      ASoC: mt8192: Fix range for sidetone positive gain

 sound/soc/mediatek/mt8192/mt8192-dai-adda.c | 58 ++++++++++-------------------
 1 file changed, 19 insertions(+), 39 deletions(-)
---
base-commit: b361d5d2464a88184f6e17a6462719ba79180b1a
change-id: 20230223-asoc-mt8192-quick-fixes-8f3e0a187226

Best regards,

Comments

Nícolas F. R. A. Prado Feb. 24, 2023, 7:40 p.m. UTC | #1
On Fri, Feb 24, 2023 at 02:03:54PM +0000, Mark Brown wrote:
> This is a collection of fixes I came up after glancing through an
> initial test run with the Spherion Chromebook on KernelCI.  There are
> more issues flagged, this is just what I fixed thus far - the volume
> controls on the MT6359 have issues for example, and a lot of controls
> aren't marked as Switches like they should be.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Thanks for the fixes.

Tested on a spherion chromebook to make sure audio still works as expected, and
the following tests from mixer-test in the alsa kselftest are fixed:

	# No event generated for MTKAIF_ADDA6_ONLY Switch
	not ok 1910 event_missing.0.13

	# No event generated for MTKAIF_DMIC Switch
	not ok 1917 event_missing.0.12

	# No event generated for Sidetone_Positive_Gain_dB
	# Sidetone_Positive_Gain_dB.0 value -1 less than minimum 0
	# Sidetone_Positive_Gain_dB.0 value 101 more than maximum 100
	not ok 1930 write_invalid.0.10

(no change in pcm-test results)

So,

Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas
Mark Brown Feb. 28, 2023, 6 p.m. UTC | #2
On Fri, 24 Feb 2023 14:03:54 +0000, Mark Brown wrote:
> This is a collection of fixes I came up after glancing through an
> initial test run with the Spherion Chromebook on KernelCI.  There are
> more issues flagged, this is just what I fixed thus far - the volume
> controls on the MT6359 have issues for example, and a lot of controls
> aren't marked as Switches like they should be.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: mt8192: Remove spammy log messages
      commit: 5df1a5d28449f2b98ff84f69dea74b06f9b8e362
[2/4] ASoC: mt8192: Fix event generation for controls
      commit: b373076f609993d333dbbc3283b65320c7a41834
[3/4] ASoC: mt8192: Report an error if when an invalid sidetone gain is written
      commit: 05437a91173b8780692ac35313f98cac68be7c42
[4/4] ASoC: mt8192: Fix range for sidetone positive gain
      commit: ce40d93b062c0bdcd29218c12ab1dba544382dd8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark