mbox series

[0/3] Documentation fixes for MT6370 RGB

Message ID 20230319074903.13075-1-bagasdotme@gmail.com (mailing list archive)
Headers show
Series Documentation fixes for MT6370 RGB | expand

Message

Bagas Sanjaya March 19, 2023, 7:49 a.m. UTC
kernel test robot recently reported htmldocs warnings on documentation
for MT6370 RGB LED. So here are the fixes.

Bagas Sanjaya (3):
  Documentation: leds: Add MT6370 doc to the toctree
  Documentation: leds: MT6370: Properly wrap hw_pattern chart
  Documentation: leds: MT6370: Use bullet lists for timing variables

 Documentation/leds/index.rst           |  1 +
 Documentation/leds/leds-mt6370-rgb.rst | 42 +++++++++++++-------------
 2 files changed, 22 insertions(+), 21 deletions(-)


base-commit: 4ba9df04b7ac66d2d000ed7ae2d8136302d99a57

Comments

Bagas Sanjaya March 23, 2023, 5:06 a.m. UTC | #1
On 3/19/23 14:49, Bagas Sanjaya wrote:
> kernel test robot recently reported htmldocs warnings on documentation
> for MT6370 RGB LED. So here are the fixes.
> 
> Bagas Sanjaya (3):
>   Documentation: leds: Add MT6370 doc to the toctree
>   Documentation: leds: MT6370: Properly wrap hw_pattern chart
>   Documentation: leds: MT6370: Use bullet lists for timing variables
> 
>  Documentation/leds/index.rst           |  1 +
>  Documentation/leds/leds-mt6370-rgb.rst | 42 +++++++++++++-------------
>  2 files changed, 22 insertions(+), 21 deletions(-)
> 
> 
> base-commit: 4ba9df04b7ac66d2d000ed7ae2d8136302d99a57

ping
Pavel Machek March 23, 2023, 11:08 a.m. UTC | #2
On Sun 2023-03-19 14:49:00, Bagas Sanjaya wrote:
> kernel test robot recently reported htmldocs warnings on documentation
> for MT6370 RGB LED. So here are the fixes.
> 
> Bagas Sanjaya (3):
>   Documentation: leds: Add MT6370 doc to the toctree
>   Documentation: leds: MT6370: Properly wrap hw_pattern chart
>   Documentation: leds: MT6370: Use bullet lists for timing variables
> 
>  Documentation/leds/index.rst           |  1 +
>  Documentation/leds/leds-mt6370-rgb.rst | 42 +++++++++++++-------------
>  2 files changed, 22 insertions(+), 21 deletions(-)

Series looks good to me.

Acked-by: Pavel Machek <pavel@ucw.cz>

								Pavel
Lee Jones March 23, 2023, 12:31 p.m. UTC | #3
On Thu, 23 Mar 2023, Bagas Sanjaya wrote:

> On 3/19/23 14:49, Bagas Sanjaya wrote:
> > kernel test robot recently reported htmldocs warnings on documentation
> > for MT6370 RGB LED. So here are the fixes.
> >
> > Bagas Sanjaya (3):
> >   Documentation: leds: Add MT6370 doc to the toctree
> >   Documentation: leds: MT6370: Properly wrap hw_pattern chart
> >   Documentation: leds: MT6370: Use bullet lists for timing variables
> >
> >  Documentation/leds/index.rst           |  1 +
> >  Documentation/leds/leds-mt6370-rgb.rst | 42 +++++++++++++-------------
> >  2 files changed, 22 insertions(+), 21 deletions(-)
> >
> >
> > base-commit: 4ba9df04b7ac66d2d000ed7ae2d8136302d99a57
>
> ping

a) Don't do that!

b) Especually don't do that 4 days after submission!

The usual expectation is 2 full weeks before submitting a [RESEND].

Mark Brown says it best:

"
Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
"

--
Lee Jones [李琼斯]
Bagas Sanjaya March 23, 2023, 12:35 p.m. UTC | #4
On 3/23/23 19:31, Lee Jones wrote:
>> ping
> 
> a) Don't do that!
> 
> b) Especually don't do that 4 days after submission!
> 
> The usual expectation is 2 full weeks before submitting a [RESEND].
> 
> Mark Brown says it best:
> 
> "
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.
> 
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.
> "
> 

Ah! I triggered the wrong message at the wrong time. Thanks anyway!