| Message ID | 20240925093807.1026949-1-wenst@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add of_regulator_get_optional() and Fix MTK Power Domain Driver | expand |
On Wed, 25 Sept 2024 at 11:38, Chen-Yu Tsai <wenst@chromium.org> wrote: > > Hi folks, > > This series is split off from my "DT hardware prober" series [1]. > > Changes since v7: > - Added stub versions for of_regulator_get_optional() for !CONFIG_OF > and !CONFIG_REGULATOR > - Added new patches for devres version and converting MTK pmdomain > driver > > At ELCE, Sebastian told me about his recent work on adding regulator > supply support to the Rockchip power domain driver [2], how the MediaTek > driver has been using the existing devm_regulator_get() API and > reassigning different device nodes to the device doing the lookup, and > how the new of_regulator_get_optional() is the proper fit for this. > > Patch 1 adds a new of_regulator_get_optional() function to look up > regulator supplies using device tree nodes. > > Patch 2 adds a devres version of the aforementioned function at > Sebastian's request for the two power domain drivers. > > Patch 3 converts the MediaTek power domain driver to use function. > > > Each of the latter two patches depend on the previous one at build time. > Mark, would it be possible for you to put the two regulator patches > on an immutable branch / tag? Otherwise we could have Ulf ack the > pmdomain patch and merge it through your tree. Sebastian was fine > with converting the rockchip pmdomain some time later. Thanks for providing some context! In my opinion I would prefer an immutable branch/tag of the regulator core changes, so I can carry the pmdomain changes for MTK through my pmdomain tree, but also because I would prefer if Sebastian could make the corresponding conversion for the Rockchip pmdomain driver. If this can get queued soon, there is really no need to have an intermediate step for Rockchip, I think. Does it make sense - or do you prefer another way forward? [...] Kind regards Uffe
On Thu, Sep 26, 2024 at 11:49 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Wed, 25 Sept 2024 at 11:38, Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > Hi folks, > > > > This series is split off from my "DT hardware prober" series [1]. > > > > Changes since v7: > > - Added stub versions for of_regulator_get_optional() for !CONFIG_OF > > and !CONFIG_REGULATOR > > - Added new patches for devres version and converting MTK pmdomain > > driver > > > > At ELCE, Sebastian told me about his recent work on adding regulator > > supply support to the Rockchip power domain driver [2], how the MediaTek > > driver has been using the existing devm_regulator_get() API and > > reassigning different device nodes to the device doing the lookup, and > > how the new of_regulator_get_optional() is the proper fit for this. > > > > Patch 1 adds a new of_regulator_get_optional() function to look up > > regulator supplies using device tree nodes. > > > > Patch 2 adds a devres version of the aforementioned function at > > Sebastian's request for the two power domain drivers. > > > > Patch 3 converts the MediaTek power domain driver to use function. > > > > > > Each of the latter two patches depend on the previous one at build time. > > Mark, would it be possible for you to put the two regulator patches > > on an immutable branch / tag? Otherwise we could have Ulf ack the > > pmdomain patch and merge it through your tree. Sebastian was fine > > with converting the rockchip pmdomain some time later. > > Thanks for providing some context! > > In my opinion I would prefer an immutable branch/tag of the regulator > core changes, so I can carry the pmdomain changes for MTK through my > pmdomain tree, but also because I would prefer if Sebastian could make > the corresponding conversion for the Rockchip pmdomain driver. If this > can get queued soon, there is really no need to have an intermediate > step for Rockchip, I think. > > Does it make sense - or do you prefer another way forward? Makes sense to me! ChenYu
On Wed, 25 Sep 2024 17:38:03 +0800, Chen-Yu Tsai wrote: > This series is split off from my "DT hardware prober" series [1]. > > Changes since v7: > - Added stub versions for of_regulator_get_optional() for !CONFIG_OF > and !CONFIG_REGULATOR > - Added new patches for devres version and converting MTK pmdomain > driver > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/3] regulator: Add of_regulator_get_optional() for pure DT regulator lookup commit: 5441b6975adc26aeaca316b9075e04a98238b1b3 [2/3] regulator: Add devres version of of_regulator_get_optional() commit: 36ec3f437227470568e5f460997f367f5446a34d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi folks, This series is split off from my "DT hardware prober" series [1]. Changes since v7: - Added stub versions for of_regulator_get_optional() for !CONFIG_OF and !CONFIG_REGULATOR - Added new patches for devres version and converting MTK pmdomain driver At ELCE, Sebastian told me about his recent work on adding regulator supply support to the Rockchip power domain driver [2], how the MediaTek driver has been using the existing devm_regulator_get() API and reassigning different device nodes to the device doing the lookup, and how the new of_regulator_get_optional() is the proper fit for this. Patch 1 adds a new of_regulator_get_optional() function to look up regulator supplies using device tree nodes. Patch 2 adds a devres version of the aforementioned function at Sebastian's request for the two power domain drivers. Patch 3 converts the MediaTek power domain driver to use function. Each of the latter two patches depend on the previous one at build time. Mark, would it be possible for you to put the two regulator patches on an immutable branch / tag? Otherwise we could have Ulf ack the pmdomain patch and merge it through your tree. Sebastian was fine with converting the rockchip pmdomain some time later. Thanks ChenYu [1] https://lore.kernel.org/all/20240911072751.365361-1-wenst@chromium.org/ [2] https://lore.kernel.org/all/20240919091834.83572-1-sebastian.reichel@collabora.com/ Chen-Yu Tsai (3): regulator: Add of_regulator_get_optional() for pure DT regulator lookup regulator: Add devres version of of_regulator_get_optional() pmdomain: mediatek: Use OF-specific regulator API to get power domain supply drivers/pmdomain/mediatek/mtk-pm-domains.c | 12 +---- drivers/regulator/core.c | 4 +- drivers/regulator/devres.c | 39 +++++++++++++++++ drivers/regulator/internal.h | 18 +++++--- drivers/regulator/of_regulator.c | 51 +++++++++++++++++++--- include/linux/regulator/consumer.h | 37 ++++++++++++++++ 6 files changed, 136 insertions(+), 25 deletions(-) base-commit: 2b7275670032a98cba266bd1b8905f755b3e650f