From patchwork Sun Feb 9 11:10:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Woudstra X-Patchwork-Id: 13966772 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AA64C02199 for ; Sun, 9 Feb 2025 11:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=CyvKVSI33vZu8t/QmYGxOXMM6HMY8Y3GepsTnlkxCpQ=; b=tEK8k7bRa+7Kbpp17N/Jh/KGHG bgk1fQzk/AhDlN1InBzJ0u6mf30GdGb29F+5juqnL3f5KRiE9cCpdrjLMpmqOsK85MBWhwtQTBGTf dwX1zrWFH4Xp5S3wU2ppfGTgCbPY63EEWP8c0U7qpoojr5aCUp7BlMhm/fuds6/bJq6kfxiULVwCI vUOgeUqqe2vFHvkg1cSt9vIe20CUgZbg+Mu6A54BNNTx14mCNkrJBduqJpP9u0h+ZZX0AJl4NXae1 SgfgM0QVJJpBimrhX4uf6zsctcUglLWmXo7NQt6Xq4PDLoXiIfVsXxbkXEmZj4P0FA+7MLVb3jtED 5vxF93Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1th5Eq-0000000EhBh-2Lqe; Sun, 09 Feb 2025 11:12:36 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1th5D0-0000000EgWF-2HIX; Sun, 09 Feb 2025 11:10:43 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5de4d4adac9so3861154a12.3; Sun, 09 Feb 2025 03:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739099441; x=1739704241; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CyvKVSI33vZu8t/QmYGxOXMM6HMY8Y3GepsTnlkxCpQ=; b=MBSIUTdZwBdZtK9vpv08yJU2YQ5sQjdHq093glMzl3vRB0cCI1rFISziTAqCBXQx/9 n2bZ7XeaqMZpsoQJWJZse0S8sC61fV1jn+hcr6/2XEbXMayzzXKZZJ0BpblvNOtnylKV VK7el75CT/tCiYIWxZttFdkExyjAq3t53i1N1qv8qq6AtoUyWMAYoPI0w8ssZEY38hag yEN6W6KOksDe5T4Qzh3szoPaLVm9mQenQZfVkLtMJc9CBLmDW+mi/ppCdwKs/qM8eDnF kOcB2HsCz/dDI3BVCHYqLBw50j7ck8KNqVVQ1SU7JhtQaoiHPoovgsvN2B3HvkhRlaMq wc5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739099441; x=1739704241; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CyvKVSI33vZu8t/QmYGxOXMM6HMY8Y3GepsTnlkxCpQ=; b=tBzIbgOW1cM1/BPjg9I1d4CRkHl516CbZo//pCEU98dZdWVi8uD9D9gkydL3ptryvx /c1vTF4Rg1EB6o40AhPRtQiGXkxSg38rGF9MJzjOTCVsHsDlw8TgnR5c4NGCWsGc69Tj OHOaq0LjUFB9XfOxuQhc7NO3eMvzkkrg3nlHcLLPPfMfvrXNvlQK6iG3C5wyswtclWyt zR/grEcMpw/CPT1wgToSZABtSNSxmIo/lHhgkGlp8cRnJXXhffj/y4pbJhtUag3NkoFc xS129mer2mh2vlNe4rIJeY4xax9x1SvFpL2LiLSIv4XejNYC0lJzNg2NCWGPE6mA5JH9 hn4A== X-Forwarded-Encrypted: i=1; AJvYcCUUsQY7E/+7l4E0T4YcYex0LYKqTE0hbc4VeVIyrFM0JjMDTouor49L7JbMQ0+kGg3SLTZiBhQDumj0n2nVFJrZ@lists.infradead.org, AJvYcCVUoVN0y6cEIJhroZHmL1Rgpe3kUbBMtR/1j6AML52K9RR71cqe3g6e5quInX2vthD5TJabYn2gYc8JNHnstVQ=@lists.infradead.org X-Gm-Message-State: AOJu0YwY7XIBi509u6Xha8UkhX2QgXmAZ0Np6YKj44cxpQFR7vCYj6RW GGwYshgUr7b0rWukmu5T8VNOWa/Npxl2NWY8H20oY0KV1Q1h8KPJ X-Gm-Gg: ASbGnctAxqs2sC2EKkxNjbUjq6eHUv9zXTiyU9cilx0k3WcZ/ug/LiPdpxrQE7NbmZQ rAhu7WNA5mKVAdgzc+yN7pU+8EqD3JHQr6WyoKEnOuNSYEtkpJstcKZPQAanpQfFXWHEEzkCLXi ntTHkvkuzxTIVG2Bc+WpCUehgiPrGoqyrWCn9X0U4HYQNYHtDt81tAh9mB11xb9+K+tTyXSzUgA wvZvXANuXPw5xQWwHebrr5SnTGsy6f6ToRB+kW6sq3TyXTN72FYlLeOcpBxo3wh8+Wvm5kbx0mB hyO2R9Qke1dsL+8h8d/gRYmpKDAP193gD8jQbOMR92rsEOAGeSiScGGo3zISA6FXw2IUiSNkwef 2Sj/HwwvacF+Pj/Sdp6mIVWQMGABJSV1f X-Google-Smtp-Source: AGHT+IEbNo/zNmhConkNcLHKgH3TnCUwIDNTGJ5Gx8cyqDGyWa7TYG5GlIYlUiiTBmfRe7hgt6Cw8Q== X-Received: by 2002:a17:907:98b:b0:aa6:832b:8d76 with SMTP id a640c23a62f3a-ab789a9da54mr1139791266b.12.1739099440544; Sun, 09 Feb 2025 03:10:40 -0800 (PST) Received: from corebook.localdomain (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl. [2001:1c00:20d:1300:1b1c:4449:176a:89ea]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab79afc7452sm357516366b.163.2025.02.09.03.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 03:10:40 -0800 (PST) From: Eric Woudstra To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Pablo Neira Ayuso , Jozsef Kadlecsik , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Matthias Brugger , AngeloGioacchino Del Regno , Kuniyuki Iwashima , Sebastian Andrzej Siewior , Lorenzo Bianconi , Joe Damato , Alexander Lobakin , Vladimir Oltean , "Frank Wunderlich" , Daniel Golle Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Eric Woudstra Subject: [PATCH v6 net-next 00/14] bridge-fastpath and related improvements Date: Sun, 9 Feb 2025 12:10:20 +0100 Message-ID: <20250209111034.241571-1-ericwouds@gmail.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250209_031042_600794_99B270C2 X-CRM114-Status: GOOD ( 25.24 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org This patchset makes it possible to set up a software fastpath between bridged interfaces. One patch adds the flow rule for the hardware fastpath. This creates the possibility to have a hardware offloaded fastpath between bridged interfaces. More patches are added to solve issues found with the existing code. To set up the fastpath with offloading, add this extra flowtable: table bridge filter { flowtable fb { hook ingress priority filter devices = { lan0, lan1, lan2, lan3, lan4, wlan0, wlan1 } flags offload } chain forward { type filter hook forward priority filter; policy accept; ct state established flow add @fb } } Creating a separate fastpath for bridges. forward fastpath bypass .----------------------------------------. / \ | IP - forwarding | | / \ v | / wan ... | / | | | | | brlan.1 | | | +-------------------------------+ | | vlan 1 | | | | | | brlan (vlan-filtering) | | +---------------+ | | | DSA-SWITCH | | | | | vlan 1 | | | | to | | | vlan 1 | untagged | | +---------------+---------------+ . / \ ------>lan0 wlan1 . ^ ^ . | | . \_________________/ . bridge fastpath bypass . ^ vlan 1 tagged packets To have the ability to handle xmit direct with outgoing encaps in the bridge fastpass bypass, we need to be able to handle them without going through vlan/pppoe devices. So I've applied, amended and squashed wenxu's patchset. This patch also makes it possible to egress from vlan-filtering brlan to lan0 with vlan tagged packets, if the bridge master port is doing the vlan tagging, instead of the vlan-device. Without this patch, this is not possible in the bridge-fastpath and also not in the forward-fastpath, as seen in the figure above. There are also some more fixes for filling in the forward path. These fixes also apply to for the forward-fastpath. They include handling DEV_PATH_MTK_WDMA in nft_dev_path_info(). There are now 2 patches for avoiding ingress_vlans bit set for bridged dsa user ports and foreign (dsa) ports. Another patch introduces DEV_PATH_BR_VLAN_KEEP_HW, needed for the bridge-fastpath only. Conntrack bridge only tracks untagged and 802.1q. To make the bridge fastpath experience more similar to the forward fastpath experience, I've added double vlan, pppoe and pppoe-in-q tagged packets to bridge conntrack and to bridge filter chain. Note: While testing direct transmit in the software forward-fastpath, without the capability of setting the offload flag, it is sometimes useful to enslave the wan interface to another bridge, brwan. This will make sure both directions of the software forward-fastpath use direct transmit, which also happens when the offload flag is set. I have send RFC v2 as I previously only owned a dsa device. I now have obtained a switchdev supporting SWITCHDEV_OBJ_ID_PORT_VLAN, and found there was more to do to handle the ingress_vlans bit and corresponding vlan encap. I send v4 and above as non-RFC as the previous 2 RFC's did not get any comment. Changes in v6: - Conntrack double vlan and pppoe patch: Set ph and vhdr after the calls to pskb_may_pull(). Changes in v5: - Conntrack double vlan and pppoe patch: Moved pskb_may_pull() up to the first switch statement, to the start of the cases. Removed the second switch statement. Replaced 0xffffffff with U32_MAX. - Added patch removing hw_outdev, out.hw_ifindex and out.hw_ifidx members. - Fix error path returned from nft_flow_offload_bridge_init(). - Cosmetics. Changes in v4: - Added !CONFIG_NET_SWITCHDEV version of br_switchdev_port_vlan_no_foreign_add(). Changes in v3: - Squashed the two 'port to port' patches to avoid build errors when only one of the two commits is applied. Changes in v2: - Introduce DEV_PATH_BR_VLAN_KEEP_HW for use in the bridge-fastpath only. It is needed for switchdevs supporting SWITCHDEV_OBJ_ID_PORT_VLAN. - Different approach for handling BR_VLFLAG_ADDED_BY_SWITCHDEV in br_vlan_fill_forward_path_mode() for foreign devices. Introduce SWITCHDEV_F_NO_FOREIGN, BR_VLFLAG_TAGGING_BY_SWITCHDEV and br_switchdev_port_vlan_no_foreign_add(). The latter function can be used to make sure the vlan was added to a switchdev native device. When that fails, adding the vlan with br_switchdev_port_vlan_add() means it was added to a switchdev foreign device. - Clear ingress_vlans bit and corresponding encap for dsa user ports. - Add check for ingress_vlans bit to nft_dev_fill_bridge_path(). - Adapted cover letter description to make clear the patches apply to software fastpath, making hardware-offloaded fastpath possible. - Fixed clang error for vlan_hdr * and struct ppp_hdr * by adding block. - Updated !CONFIG_BRIDGE_VLAN_FILTERING version of br_vlan_fill_forward_path_pvid(). - Removed erroneous check netif_is_bridge_master(ctx->dev) from dev_fill_bridge_path(). - Cosmetic changes. Eric Woudstra (14): netfilter: nf_flow_table_offload: Add nf_flow_encap_push() for xmit direct netfilter: flow: remove hw_outdev, out.hw_ifindex and out.hw_ifidx netfilter: bridge: Add conntrack double vlan and pppoe netfilter: nft_chain_filter: Add bridge double vlan and pppoe bridge: Add filling forward path from port to port net: core: dev: Add dev_fill_bridge_path() netfilter :nf_flow_table_offload: Add nf_flow_rule_bridge() netfilter: nf_flow_table_inet: Add nf_flowtable_type flowtable_bridge netfilter: nft_flow_offload: Add NFPROTO_BRIDGE to validate netfilter: nft_flow_offload: Add DEV_PATH_MTK_WDMA to nft_dev_path_info() netfilter: nft_flow_offload: No ingress_vlan forward info for dsa user port bridge: No DEV_PATH_BR_VLAN_UNTAG_HW for dsa foreign bridge: Introduce DEV_PATH_BR_VLAN_KEEP_HW for bridge-fastpath netfilter: nft_flow_offload: Add bridgeflow to nft_flow_offload_eval() include/linux/netdevice.h | 3 + include/net/netfilter/nf_flow_table.h | 5 +- include/net/switchdev.h | 1 + net/bridge/br_device.c | 23 ++- net/bridge/br_private.h | 12 ++ net/bridge/br_switchdev.c | 15 ++ net/bridge/br_vlan.c | 29 +++- net/bridge/netfilter/nf_conntrack_bridge.c | 83 ++++++++-- net/core/dev.c | 66 ++++++-- net/netfilter/nf_flow_table_core.c | 1 - net/netfilter/nf_flow_table_inet.c | 13 ++ net/netfilter/nf_flow_table_ip.c | 96 +++++++++++- net/netfilter/nf_flow_table_offload.c | 15 +- net/netfilter/nft_chain_filter.c | 20 ++- net/netfilter/nft_flow_offload.c | 168 +++++++++++++++++++-- net/switchdev/switchdev.c | 2 +- 16 files changed, 492 insertions(+), 60 deletions(-)