[net-next,v2,0/9] net: dsa: mt7530: updates for phylink changes

Message

Russell King (Oracle) April 11, 2022, 9:45 a.m. UTC

Hi,

This revised series is a partial conversion of the mt7530 DSA driver to
the modern phylink infrastructure. This driver has some exceptional
cases which prevent - at the moment - its full conversion (particularly
with the Autoneg bit) to using phylink_generic_validate().

Patch 1 fixes the incorrect test highlighted in the first RFC series.

Patch 2 fixes the incorrect assumption that RGMII is unable to support
1000BASE-X.

Patch 3 populates the supported_interfaces for each port

Patch 4 removes the interface checks that become unnecessary as a result
of patch 3.

Patch 5 removes use of phylink_helper_basex_speed() which is no longer
required by phylink.

Patch 6 becomes possible after patch 5, only indicating the ethtool
modes that can be supported with a particular interface mode - this
involves removing some modes and adding others as per phylink
documentation.

Patch 7 switches the driver to use phylink_get_linkmodes(), which moves
the driver as close as we can to phylink_generic_validate() due to the
Autoneg bit issue mentioned above.

Patch 8 converts the driver to the phylink pcs support, removing a bunch
of driver private indirected methods. We include TRGMII as a PCS even
though strictly TRGMII does not have a PCS. This is convenient to allow
the change in patch 9 to be made.

Patch 9 moves the special autoneg handling to the PCS validate method,
which means we can convert the MAC side to the generic validator.

Patch 10 marks the driver as non-legacy.

The series was posted on 23 February, and a ping sent on 3 March, but
no feedback has been received. The previous posting also received no
feedback on the actual patches either.

v2:
- fix build issue in patch 5
- add Marek's tested-by

 drivers/net/dsa/mt7530.c | 330 +++++++++++++++++++++--------------------------
 drivers/net/dsa/mt7530.h |  26 ++--
 2 files changed, 159 insertions(+), 197 deletions(-)

Comments

[e-mail] April 12, 2022, 10:10 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <[e-mail]>:

On Mon, 11 Apr 2022 10:45:32 +0100 you wrote:
> Hi,
> 
> This revised series is a partial conversion of the mt7530 DSA driver to
> the modern phylink infrastructure. This driver has some exceptional
> cases which prevent - at the moment - its full conversion (particularly
> with the Autoneg bit) to using phylink_generic_validate().
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/9] net: dsa: mt7530: 1G can also support 1000BASE-X link mode
    https://git.kernel.org/netdev/net-next/c/66f862563ed6
  - [net-next,v2,2/9] net: dsa: mt7530: populate supported_interfaces and mac_capabilities
    https://git.kernel.org/netdev/net-next/c/59c2215f3604
  - [net-next,v2,3/9] net: dsa: mt7530: remove interface checks
    https://git.kernel.org/netdev/net-next/c/26f6d8810282
  - [net-next,v2,4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed()
    https://git.kernel.org/netdev/net-next/c/fd301137e6b3
  - [net-next,v2,5/9] net: dsa: mt7530: only indicate linkmodes that can be supported
    https://git.kernel.org/netdev/net-next/c/7c04c8489115
  - [net-next,v2,6/9] net: dsa: mt7530: switch to use phylink_get_linkmodes()
    https://git.kernel.org/netdev/net-next/c/6789d6d76e81
  - [net-next,v2,7/9] net: dsa: mt7530: partially convert to phylink_pcs
    https://git.kernel.org/netdev/net-next/c/cbd1f243bc41
  - [net-next,v2,8/9] net: dsa: mt7530: move autoneg handling to PCS validation
    https://git.kernel.org/netdev/net-next/c/9d0df207c002
  - [net-next,v2,9/9] net: dsa: mt7530: mark as non-legacy
    https://git.kernel.org/netdev/net-next/c/7b972512ec0e

You are awesome, thank you!

Russell King (Oracle) April 12, 2022, 10:20 a.m. UTC | #2

On Tue, Apr 12, 2022 at 10:10:13AM +0000, [e-mail] wrote:
> Hello:
> 
> This series was applied to netdev/net-next.git (master)
> by Paolo Abeni <[e-mail]>:

Hi,

I think your bot is incorrect on that point, and probably needs
servicing.

Russell.

Russell King (Oracle) April 12, 2022, 10:21 a.m. UTC | #3

On Tue, Apr 12, 2022 at 11:20:26AM +0100, Russell King (Oracle) wrote:
> On Tue, Apr 12, 2022 at 10:10:13AM +0000, [e-mail] wrote:
> > Hello:
> > 
> > This series was applied to netdev/net-next.git (master)
> > by Paolo Abeni <[e-mail]>:
> 
> Hi,
> 
> I think your bot is incorrect on that point, and probably needs
> servicing.

Oh, sorry, misread, everything is fine (apart from my sanity.)