diff mbox

[v3] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig

Message ID 1426257652-16779-1-git-send-email-yingjoe.chen@mediatek.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yingjoe Chen March 13, 2015, 2:40 p.m. UTC
Hi Linus,

Yet another version. Changed based on Arnd's suggestion to make config
options for PINCTRL_MT8135 & PINCTRL_MT8173 more consist. This is based
on mtk-staging in your tree. If you think this is OK, please applied or
squash this into previous change. Thanks.

Old patch can be found at:
http://lists.infradead.org/pipermail/linux-mediatek/2015-March/000057.html

Joe.C

8<-------------------------------------------------------
ARM64 maintainer doesn't want to add MACH_* for each SoC.
Adjust mt8173 pinctrl kconfig entry so user can manually select it.

Also make PINCTRL_MT8135 selectable when COMPILE_TEST is enabled.

Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
---
 drivers/pinctrl/mediatek/Kconfig | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Linus Walleij March 18, 2015, 12:01 p.m. UTC | #1
On Fri, Mar 13, 2015 at 3:40 PM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote:

> Hi Linus,
>
> Yet another version. Changed based on Arnd's suggestion to make config
> options for PINCTRL_MT8135 & PINCTRL_MT8173 more consist. This is based
> on mtk-staging in your tree. If you think this is OK, please applied or
> squash this into previous change. Thanks.
>
> Old patch can be found at:
> http://lists.infradead.org/pipermail/linux-mediatek/2015-March/000057.html
>
> Joe.C
>
> 8<-------------------------------------------------------
> ARM64 maintainer doesn't want to add MACH_* for each SoC.
> Adjust mt8173 pinctrl kconfig entry so user can manually select it.
>
> Also make PINCTRL_MT8135 selectable when COMPILE_TEST is enabled.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>

This last version of the patch applied.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index 49b8649..5983cf5 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -1,4 +1,4 @@ 
-if ARCH_MEDIATEK
+if ARCH_MEDIATEK || COMPILE_TEST
 
 config PINCTRL_MTK_COMMON
 	bool
@@ -7,12 +7,17 @@  config PINCTRL_MTK_COMMON
 	select GPIOLIB
 	select OF_GPIO
 
+# For ARMv7 SoCs
 config PINCTRL_MT8135
-	def_bool MACH_MT8135
+	bool "Mediatek MT8135 pin control" if COMPILE_TEST && !MACH_MT8135
+	default MACH_MT8135
 	select PINCTRL_MTK_COMMON
 
+# For ARMv8 SoCs
 config PINCTRL_MT8173
-	def_bool MACH_MT8173
+	bool "Mediatek MT8173 pin control"
+	depends on ARM64 || COMPILE_TEST
+	default ARM64 && ARCH_MEDIATEK
 	select PINCTRL_MTK_COMMON
 
 endif