| Message ID | 1437715481-31528-2-git-send-email-henryc.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Henry, I believe Mark asked you to use a subject lines reflecting the style for the subsystem, so the subject should had been something like: regulators: mt6311: Add DT binding document On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen@mediatek.com> wrote: > This patch adds a list of supported regulator names to the devicetree > binding documentation for Mediatek MT6311 PMIC. > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com> > --- I know is in your cover letter, but usually is good to also include a history log of the changes for each patch so people know what changed. Everything between the '---' and the diff are omitted by tools like git am so you can add there. You can use tools like patman that do this automatically for you. Also, I said that you could add my Reviewed-by after the node name change so you should had carried that. So again: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier
Hi Javier, On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote: > Hello Henry, > > I believe Mark asked you to use a subject lines reflecting the style > for the subsystem, so the subject should had been something like: > > regulators: mt6311: Add DT binding document > > On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen@mediatek.com> wrote: > > This patch adds a list of supported regulator names to the devicetree > > binding documentation for Mediatek MT6311 PMIC. > > > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com> > > --- > > I know is in your cover letter, but usually is good to also include a > history log of the changes for each patch so people know what changed. > Everything between the '---' and the diff are omitted by tools like > git am so you can add there. You can use tools like patman that do > this automatically for you. > Ok, got it, I will follow that. > Also, I said that you could add my Reviewed-by after the node name > change so you should had carried that. So again: Sorry, did you mean I need to resent again? Thanks for advise. Henry > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Best regards, > Javier
Hello Henry, On Fri, Jul 24, 2015 at 2:59 PM, Henry Chen <HenryC.Chen@mediatek.com> wrote: > Hi Javier, > > On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote: >> Hello Henry, >> >> I believe Mark asked you to use a subject lines reflecting the style >> for the subsystem, so the subject should had been something like: >> >> regulators: mt6311: Add DT binding document >> >> On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen@mediatek.com> wrote: >> > This patch adds a list of supported regulator names to the devicetree >> > binding documentation for Mediatek MT6311 PMIC. >> > >> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com> >> > --- >> >> I know is in your cover letter, but usually is good to also include a >> history log of the changes for each patch so people know what changed. >> Everything between the '---' and the diff are omitted by tools like >> git am so you can add there. You can use tools like patman that do >> this automatically for you. >> > Ok, got it, I will follow that. > >> Also, I said that you could add my Reviewed-by after the node name >> change so you should had carried that. So again: > > Sorry, did you mean I need to resent again? > Sorry for not being clear. No, it's not necessary to resend. I just mentioned for the next time. > Thanks for advise. > Henry > Best regards, Javier
diff --git a/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt new file mode 100644 index 0000000..02649d8 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt @@ -0,0 +1,35 @@ +Mediatek MT6311 Regulator Driver + +Required properties: +- compatible: "mediatek,mt6311-regulator" +- reg: I2C slave address, usually 0x6b. +- regulators: List of regulators provided by this controller. It is named + to VDVFS and VBIASN. + The definition for each of these nodes is defined using the standard binding + for regulators at Documentation/devicetree/bindings/regulator/regulator.txt. + +The valid names for regulators are: +BUCK: + VDVFS +LDO: + VBIASN + +Example: + mt6311: pmic@6b { + compatible = "mediatek,mt6311-regulator"; + reg = <0x6b>; + + regulators { + mt6311_vcpu_reg: VDVFS { + regulator-name = "VDVFS"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1400000>; + regulator-ramp-delay = <10000>; + }; + mt6311_ldo_reg: VBIASN { + regulator-name = "VBIASN"; + regulator-min-microvolt = <200000>; + regulator-max-microvolt = <800000>; + }; + }; + };
This patch adds a list of supported regulator names to the devicetree binding documentation for Mediatek MT6311 PMIC. Signed-off-by: Henry Chen <henryc.chen@mediatek.com> --- .../bindings/regulator/mt6311-regulator.txt | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mt6311-regulator.txt