From patchwork Fri Sep 4 03:21:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 7119881 Return-Path: X-Original-To: patchwork-linux-mediatek@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2F7579F1D5 for ; Fri, 4 Sep 2015 03:22:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5AC5920891 for ; Fri, 4 Sep 2015 03:22:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 343A72081B for ; Fri, 4 Sep 2015 03:22:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXhaI-0001f4-UW; Fri, 04 Sep 2015 03:22:38 +0000 Received: from mail-la0-f44.google.com ([209.85.215.44]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXhaH-0001d0-4G for linux-mediatek@lists.infradead.org; Fri, 04 Sep 2015 03:22:37 +0000 Received: by lagj9 with SMTP id j9so5253029lag.2 for ; Thu, 03 Sep 2015 20:22:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GbYY12R05+XT6UzQM+gxboYwbq9bVQtbKZCZOKTarK8=; b=VNdWH0SHu731yiYjfqoyKienL5ckOKxJ/3itwllJ6rxRxL74PWdjSEXHywSbKAWQvP 7aElXTzwGSYXW3rpBfQUV1wPcb2HhY+PvEdDkDoacb0e/frt/AeDMSPGUB7ZlUnl6m/T n/eEngl6e7dmos0dUSAQ5GAkD3oN/RVuP9H0wpx4l9akRiKJ/pomsJzwypzqOWv3CCXb OxcYx5f1sg81uqgGs+dEMfb9nqPRf+j+sSt8zxnkgydXoampyNicNt2qC8BpMhd4Nz+W 5CLXm105Wk01cybeXltE6cElblacSfCwaIefPfGHAsd0d4z3uM3pi2ADzmEfRFulvLhD bYCw== X-Gm-Message-State: ALoCoQlVhAc8/mogQb7/al97nVdgD4J4u868fDr6K9y145HpKHo18VP93jbBAAPxyNvlGnc2J0oL X-Received: by 10.152.228.135 with SMTP id si7mr1295015lac.77.1441336934779; Thu, 03 Sep 2015 20:22:14 -0700 (PDT) Received: from localhost.localdomain ([46.39.50.164]) by smtp.gmail.com with ESMTPSA id t2sm216126lag.36.2015.09.03.20.22.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Sep 2015 20:22:14 -0700 (PDT) From: Alexey Klimov To: daniel.lezcano@linaro.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com Subject: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init Date: Fri, 4 Sep 2015 06:21:39 +0300 Message-Id: <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1441336900-15095-1-git-send-email-alexey.klimov@linaro.org> References: <1441336900-15095-1-git-send-email-alexey.klimov@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150903_202237_438655_6609D3E2 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yingjoe.chen@mediatek.com, tglx@linutronix.de, Alexey Klimov , linux-kernel@vger.kernel.org, klimov.linux@gmail.com MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These messages are actually errors and not warnings. Use pr_err() macro for them and add missing \n. Signed-off-by: Alexey Klimov Acked-by: Matthias Brugger --- drivers/clocksource/mtk_timer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c index ca5ea9e..fbaacbf 100644 --- a/drivers/clocksource/mtk_timer.c +++ b/drivers/clocksource/mtk_timer.c @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node) evt = kzalloc(sizeof(*evt), GFP_KERNEL); if (!evt) { - pr_warn("Can't allocate mtk clock event driver struct"); + pr_err("Can't allocate mtk clock event driver struct\n"); return; } @@ -200,24 +200,24 @@ static void __init mtk_timer_init(struct device_node *node) evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer"); if (IS_ERR(evt->gpt_base)) { - pr_warn("Can't get resource\n"); + pr_err("Can't get resource\n"); return; } evt->dev.irq = irq_of_parse_and_map(node, 0); if (evt->dev.irq <= 0) { - pr_warn("Can't parse IRQ"); + pr_err("Can't parse IRQ\n"); goto err_mem; } clk = of_clk_get(node, 0); if (IS_ERR(clk)) { - pr_warn("Can't get timer clock"); + pr_err("Can't get timer clock\n"); goto err_irq; } if (clk_prepare_enable(clk)) { - pr_warn("Can't prepare clock"); + pr_err("Can't prepare clock\n"); goto err_clk_put; } rate = clk_get_rate(clk); @@ -226,7 +226,7 @@ static void __init mtk_timer_init(struct device_node *node) if (request_irq(evt->dev.irq, mtk_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) { - pr_warn("failed to setup irq %d\n", evt->dev.irq); + pr_err("failed to setup irq %d\n", evt->dev.irq); goto err_clk_disable; }