| Message ID | 1452587470-61506-2-git-send-email-jamesjj.liao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > Add a Kconfig to define clock configuration for each SoC, and > modify the Makefile to build drivers that only selected in config. > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > --- > drivers/clk/Kconfig | 1 + > drivers/clk/mediatek/Kconfig | 23 +++++++++++++++++++++++ > drivers/clk/mediatek/Makefile | 6 +++--- > 3 files changed, 27 insertions(+), 3 deletions(-) > create mode 100644 drivers/clk/mediatek/Kconfig > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c3e3a02..b7a37dc 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig" > > source "drivers/clk/samsung/Kconfig" > source "drivers/clk/tegra/Kconfig" > +source "drivers/clk/mediatek/Kconfig" Hi James, drivers/clk/mediatek/Kconfig add user selectable options, menuconfig will list them outside of "Common Clock Framework" sub-menu if you source the file here. Kconfig for samsung & tegra doesn't have any, so it is OK for them to stay here. Please move it inside the menu, also it seems the source lines are sorted now, so let's keep them sorted. Joe.C
On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote: > On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > > Add a Kconfig to define clock configuration for each SoC, and > > modify the Makefile to build drivers that only selected in config. > > > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > --- > > drivers/clk/Kconfig | 1 + > > drivers/clk/mediatek/Kconfig | 23 +++++++++++++++++++++++ > > drivers/clk/mediatek/Makefile | 6 +++--- > > 3 files changed, 27 insertions(+), 3 deletions(-) > > create mode 100644 drivers/clk/mediatek/Kconfig > > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > index c3e3a02..b7a37dc 100644 > > --- a/drivers/clk/Kconfig > > +++ b/drivers/clk/Kconfig > > @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig" > > > > source "drivers/clk/samsung/Kconfig" > > source "drivers/clk/tegra/Kconfig" > > +source "drivers/clk/mediatek/Kconfig" > > > Hi James, > > drivers/clk/mediatek/Kconfig add user selectable options, menuconfig > will list them outside of "Common Clock Framework" sub-menu if you > source the file here. Kconfig for samsung & tegra doesn't have any, so > it is OK for them to stay here. > > Please move it inside the menu, also it seems the source lines are > sorted now, so let's keep them sorted. After looking at drivers/clk/Kconfig history, it seems we have similar issue before. I think we should move all sources under clk menu to prevent this from happening. Joe.C
Hi Yingjoe, On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote: > On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > > Add a Kconfig to define clock configuration for each SoC, and > > modify the Makefile to build drivers that only selected in config. > > > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > --- > > drivers/clk/Kconfig | 1 + > > drivers/clk/mediatek/Kconfig | 23 +++++++++++++++++++++++ > > drivers/clk/mediatek/Makefile | 6 +++--- > > 3 files changed, 27 insertions(+), 3 deletions(-) > > create mode 100644 drivers/clk/mediatek/Kconfig > > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > index c3e3a02..b7a37dc 100644 > > --- a/drivers/clk/Kconfig > > +++ b/drivers/clk/Kconfig > > @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig" > > > > source "drivers/clk/samsung/Kconfig" > > source "drivers/clk/tegra/Kconfig" > > +source "drivers/clk/mediatek/Kconfig" > > > Hi James, > > drivers/clk/mediatek/Kconfig add user selectable options, menuconfig > will list them outside of "Common Clock Framework" sub-menu if you > source the file here. Kconfig for samsung & tegra doesn't have any, so > it is OK for them to stay here. > > Please move it inside the menu, also it seems the source lines are > sorted now, so let's keep them sorted. OK. I'll move mediatek/Kconfig into menu section in next patch. Best regards, James
Hi Yingjoe, On Thu, 2016-01-21 at 10:45 +0800, Yingjoe Chen wrote: > On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote: > > On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > > > Add a Kconfig to define clock configuration for each SoC, and > > > modify the Makefile to build drivers that only selected in config. > > > > > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > > --- > > > drivers/clk/Kconfig | 1 + > > > drivers/clk/mediatek/Kconfig | 23 +++++++++++++++++++++++ > > > drivers/clk/mediatek/Makefile | 6 +++--- > > > 3 files changed, 27 insertions(+), 3 deletions(-) > > > create mode 100644 drivers/clk/mediatek/Kconfig > > > > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > > index c3e3a02..b7a37dc 100644 > > > --- a/drivers/clk/Kconfig > > > +++ b/drivers/clk/Kconfig > > > @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig" > > > > > > source "drivers/clk/samsung/Kconfig" > > > source "drivers/clk/tegra/Kconfig" > > > +source "drivers/clk/mediatek/Kconfig" > > > > > > Hi James, > > > > drivers/clk/mediatek/Kconfig add user selectable options, menuconfig > > will list them outside of "Common Clock Framework" sub-menu if you > > source the file here. Kconfig for samsung & tegra doesn't have any, so > > it is OK for them to stay here. > > > > Please move it inside the menu, also it seems the source lines are > > sorted now, so let's keep them sorted. > > > After looking at drivers/clk/Kconfig history, it seems we have similar > issue before. I think we should move all sources under clk menu to > prevent this from happening. I may provide a separated patch to move other Kconfig into menu section. Best regards, James
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index c3e3a02..b7a37dc 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig" source "drivers/clk/samsung/Kconfig" source "drivers/clk/tegra/Kconfig" +source "drivers/clk/mediatek/Kconfig" diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig new file mode 100644 index 0000000..dc224e6 --- /dev/null +++ b/drivers/clk/mediatek/Kconfig @@ -0,0 +1,23 @@ +# +# MediaTek SoC drivers +# +config COMMON_CLK_MEDIATEK + bool + ---help--- + Mediatek SoCs' clock support. + +config COMMON_CLK_MT8135 + bool "Clock driver for Mediatek MT8135" + depends on COMMON_CLK + select COMMON_CLK_MEDIATEK + default ARCH_MEDIATEK + ---help--- + This driver supports Mediatek MT8135 clocks. + +config COMMON_CLK_MT8173 + bool "Clock driver for Mediatek MT8173" + depends on COMMON_CLK + select COMMON_CLK_MEDIATEK + default ARCH_MEDIATEK + ---help--- + This driver supports Mediatek MT8173 clocks. diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile index 95fdfac..32e7222 100644 --- a/drivers/clk/mediatek/Makefile +++ b/drivers/clk/mediatek/Makefile @@ -1,4 +1,4 @@ -obj-y += clk-mtk.o clk-pll.o clk-gate.o clk-apmixed.o +obj-$(CONFIG_COMMON_CLK_MEDIATEK) += clk-mtk.o clk-pll.o clk-gate.o clk-apmixed.o obj-$(CONFIG_RESET_CONTROLLER) += reset.o -obj-y += clk-mt8135.o -obj-y += clk-mt8173.o +obj-$(CONFIG_COMMON_CLK_MT8135) += clk-mt8135.o +obj-$(CONFIG_COMMON_CLK_MT8173) += clk-mt8173.o