From patchwork Tue Jul 12 11:01:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 9225049 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3444560572 for ; Tue, 12 Jul 2016 11:01:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23CB727C39 for ; Tue, 12 Jul 2016 11:01:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 180FF27E63; Tue, 12 Jul 2016 11:01:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AC03E27C39 for ; Tue, 12 Jul 2016 11:01:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bMvRu-0004lp-D0; Tue, 12 Jul 2016 11:01:58 +0000 Received: from m12-14.163.com ([220.181.12.14]) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bMvRl-0004aR-1W; Tue, 12 Jul 2016 11:01:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=My3e+ ooWJYw6w4KwoUNir53G+mw6ph9sA8teiSKaJGE=; b=mzi8uTPONARkO7sA4A2u6 6Wh2DHvVqk7DmV0joUnKUaDYsNiIZm3JTGcfEBEyEgSaRUuu62KYAKgFg9qhyqZz 6UjfZUuNKg5D1r3isGHD+EsnaP/fHK0UuveEUHGz0B4uJJc5xr7lOs9GidY6nz/Q 1krv9iFqiBl1jLj8dSGP9o= Received: from localhost.localdomain.localdomain (unknown [180.110.253.144]) by smtp10 (Coremail) with SMTP id DsCowAB3a9gGzoRXPPevAQ--.28782S2; Tue, 12 Jul 2016 19:01:27 +0800 (CST) From: weiyj_lk@163.com To: Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger Subject: [PATCH -next] [media] VPU: mediatek: remove redundant dev_err call in mtk_vpu_probe() Date: Tue, 12 Jul 2016 11:01:26 +0000 Message-Id: <1468321286-15939-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: DsCowAB3a9gGzoRXPPevAQ--.28782S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxJF17JryrZrW8Gw1kGr47twb_yoW8Xr45pr ZYyayxCryrGa1jq3y5t3W7uFs5Zr4Iqay5uws3Zw1fZwsxXFWDWr1DJa48ZryYkas7ta43 trs8urW3Aa95ZF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jBeHgUUUUU= X-Originating-IP: [180.110.253.144] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbivwek1lWBS6ZDAwAAsz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160712_040149_441435_D4488C3A X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yongjun , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c index b60d02c..532d2a4 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c @@ -774,17 +774,13 @@ static int mtk_vpu_probe(struct platform_device *pdev) vpu->dev = &pdev->dev; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "tcm"); vpu->reg.tcm = devm_ioremap_resource(dev, res); - if (IS_ERR((__force void *)vpu->reg.tcm)) { - dev_err(dev, "devm_ioremap_resource vpu tcm failed.\n"); + if (IS_ERR((__force void *)vpu->reg.tcm)) return PTR_ERR((__force void *)vpu->reg.tcm); - } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg_reg"); vpu->reg.cfg = devm_ioremap_resource(dev, res); - if (IS_ERR((__force void *)vpu->reg.cfg)) { - dev_err(dev, "devm_ioremap_resource vpu cfg failed.\n"); + if (IS_ERR((__force void *)vpu->reg.cfg)) return PTR_ERR((__force void *)vpu->reg.cfg); - } /* Get VPU clock */ vpu->clk = devm_clk_get(dev, "main");