diff mbox

[RESEND,net] macsec: fix validation failed in asynchronous operation.

Message ID 1484988127-25860-1-git-send-email-ryder.lee@mediatek.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ryder Lee Jan. 21, 2017, 8:42 a.m. UTC
Add missing "macsec_skb_cb(skb)->valid = true" in callback
function macsec_decrypt_done(), this fixes packet validation
failed while decrypting asynchronously.

Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
 drivers/net/macsec.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

David Miller Jan. 22, 2017, 9:44 p.m. UTC | #1
Why are you resending this?

The original posting on Jan 20th made it to the mailing list and is queued
up in patchwork just fine.

Also, regardless of the reason, a "RESEND" patch should always contain an
explanation of why it needs to be resent.  So that the maintainer doesn't
need to ask questions like I am right now.
Ryder Lee Jan. 23, 2017, 1:39 a.m. UTC | #2
Sorry for forgetting to explain it. 

The original patch was incomplete, but I sent it out by mistake... 
So please ignore it.

On Sun, 2017-01-22 at 16:44 -0500, David Miller wrote:
> Why are you resending this?
> 
> The original posting on Jan 20th made it to the mailing list and is queued
> up in patchwork just fine.
> 
> Also, regardless of the reason, a "RESEND" patch should always contain an
> explanation of why it needs to be resent.  So that the maintainer doesn't
> need to ask questions like I am right now.
diff mbox

Patch

diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index f83cf66..73d8d39 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -880,6 +880,9 @@  static void macsec_decrypt_done(struct crypto_async_request *base, int err)
 	aead_request_free(macsec_skb_cb(skb)->req);
 
 	rcu_read_lock_bh();
+	if (err == 0)
+		macsec_skb_cb(skb)->valid = true;
+
 	pn = ntohl(macsec_ethhdr(skb)->packet_number);
 	if (!macsec_post_decrypt(skb, &macsec->secy, pn)) {
 		rcu_read_unlock_bh();