From patchwork Fri Jan 27 11:19:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shailendra.v@samsung.com X-Patchwork-Id: 9541355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5CF31604AB for ; Fri, 27 Jan 2017 11:21:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DDDC20649 for ; Fri, 27 Jan 2017 11:21:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 428BB27F99; Fri, 27 Jan 2017 11:21:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00 autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56B0A20649 for ; Fri, 27 Jan 2017 11:21:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cX4aW-00066w-6B; Fri, 27 Jan 2017 11:21:04 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cX4Zf-0004MK-6y; Fri, 27 Jan 2017 11:20:12 +0000 Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OKF0077ERH0KL20@mailout1.samsung.com>; Fri, 27 Jan 2017 20:19:48 +0900 (KST) Received: from epsmges2p4.samsung.com (unknown [182.195.42.72]) by epcas2p3.samsung.com (KnoxPortal) with ESMTP id 20170127111948epcas2p3c78424f47a5d2a260652082f3b16dc0c~dnOuoemtp0632506325epcas2p3r; Fri, 27 Jan 2017 11:19:48 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 5F.7F.06713.3DC2B885; Fri, 27 Jan 2017 20:19:48 +0900 (KST) Received: from epsmgmsp02.samsung.com (unknown [182.195.34.23]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20170127111947epcas2p14f5ea86f0069142be02339754fda4a55~dnOuav97E0053300533epcas2p1J; Fri, 27 Jan 2017 11:19:47 +0000 (GMT) X-AuditID: b6c32a48-f79116d000001a39-a6-588b2cd35284 Received: from srin.p4 (Unknown_Domain [107.108.168.37]) by epsmgmsp02.samsung.com (EPCPMTA) with SMTP id 1A.3D.04860.1DC2B885; Fri, 27 Jan 2017 20:19:47 +0900 (KST) From: Shailendra Verma To: Felix Fietkau , John Crispin , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:49:40 +0530 Message-id: <1485515980-3814-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsWy7bCmue4Vne4Ig2NXGC3uT/vGbnGy+Qaj xabH11gtLu+aw2Zxufkio0VTi7HFmatX2C2OLRCz2DGllcXi1ryZbBaLvr1iduD22DnrLrvH 5iX1HlsWZ3j0bVnF6PF5k1wAaxSXTUpqTmZZapG+XQJXxrP7U5kKrrFVHLu1lLmB8QprFyMn h4SAicSsA1+ZIWwxiQv31rN1MXJxCAnsYJRoX3YMyvnMKHHi5QKgDg6wjs5pKSANQgIrGSV+ f8wGsdkEDCVe9/1lAqkXEehllrg1Zwc7SEJYwENi7fFtbCA2i4CqxIWdPWDbeAXcJWa/+8QE MVNBYs4kG5BeCYHbbBJfd7xnh4jLSmw6AHWci8Szyz+YIGxhiVfHt7BD2FISr3ZcY4boPcYo 8fj5YiYI5zKjxJbTy6Cq7CWu3XoNZjML8El0HP4LtYBXoqNNCKLEQ6Ln7zU2CNtR4umTmcwQ T8ZKvFzZzDiBUXIBI8MqRrHUguLc9NRiowITveLE3OLSvHS95PzcTYzgyNTy2MF44JzPIUYB DkYlHt4I+a4IIdbEsuLK3EOMEhzMSiK8umLdEUK8KYmVValF+fFFpTmpxYcYpTlYlMR5/62z jhASSE8sSc1OTS1ILYLJMnFwSjUwtjWJd9eLHjoSK5BQfcT44c6lDMvu+nm39Jay6yky3r3u emiNk1g5i5KbU/lab5evXQrWj6arL7G2at5x4L3W7S2epz9YfttvVsYoX6XtzuoweeP6t0yO uYKzjq3/snYnp8n/BY4zDU5JFffq7l5pFOsZ8fnDpZtHTV7Mf/hRw/jKr07z//M3KLEUZyQa ajEXFScCAKZDk4DIAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsWSnbNCVfeyTneEweITBhb3p31jtzjZfIPR YtPja6wWl3fNYbO43HyR0aKpxdjizNUr7BbHFohZ7JjSymJxa95MNotF314xO3B77Jx1l91j 85J6jy2LMzz6tqxi9Pi8SS6ANcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULX NyRISaEsMacUyDMyQAMOzgHuwUr6dgluGc/uT2UquMZWcezWUuYGxiusXYwcHBICJhKd01K6 GDmBTDGJC/fWs3UxcnEICSxnlGha95gRJMEmYCjxuu8vE0hCRGA6s8Ss1+dYQBLCAh4Sa49v YwOxWQRUJS7s7GEGsXkF3CVmv/vEBLFAQWLOJJsJjJwLGBlWMYqlFhTnpucWFxgY6RUn5haX 5qXrJefnbmIEBuO2w0riOxhnrfA6xCjAwajEw5vB1x0hxJpYVlyZe4hRgoNZSYRXVwwoxJuS WFmVWpQfX1Sak1p8iNEUaPtEZinR5HxgpOSVxBuamFpYWJhYGhsbW5goifPGTn8WLiSQnliS mp2aWpBaBNPHxMEp1cCY15m0tttzjXPGau29fv0f07Jzvc14RTylzpRz67R8qzrEuPFg0afq 3Mg1i7q/blHdJTH///RuNaaJ3/nf+7qJ+X5q9J3eN3ezXkXGdiPHHzaLvBlLdrZ1+bTtajzI 9VlwalJx5pOEo71Hlr3ZZKCo8nb9HamQ/gVKDVOmMWX8SGTg9mosPqfEUpyRaKjFXFScCAAQ rfKOXAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127111947epcas2p14f5ea86f0069142be02339754fda4a55 X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170127111947epcas2p14f5ea86f0069142be02339754fda4a55 X-RootMTR: 20170127111947epcas2p14f5ea86f0069142be02339754fda4a55 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170127_032011_429394_E2AE94ED X-CRM114-Status: UNSURE ( 8.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 4a62ffd..4495b7b 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) int i; match = of_match_device(of_mtk_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } soc = (struct mtk_soc_data *)match->data; eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL);