From patchwork Tue Mar 21 08:27:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nickey Yang X-Patchwork-Id: 9636207 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98365601E9 for ; Tue, 21 Mar 2017 08:27:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EAAD27CAF for ; Tue, 21 Mar 2017 08:27:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8196127D29; Tue, 21 Mar 2017 08:27:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 228BD27CAF for ; Tue, 21 Mar 2017 08:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=qJVYAix0IUYLZG0i4fa+QpzmNPmfLa/Xg33ob1xFPAE=; b=k8r Opks4qbtOdhW8PJNzk475jV9pL0XfrjrsvzoHGhCHANxR8Gg7VpnK51bM9Z5N5AVh3PFEcbXxIBbF 26O+fl+5GMrDY4Y2+k3dTDIvM2iNR6DJMExOUCZgcuE2IpONUyX0u6gzrz0YmvadNJOqICp07K7cb ZR09iFcLMk2FP9BY3aFARfFP6wGlHe0zjoBOl8zeDa+vUmZafASFbRCrJ0cCX/h3hmGFBJBGo63xD 0yqJDUkm5+IPN56aCVNLbb/r+X0BxiQeILWgMk6E0lTFNJFQGFDDjdcxFv9XzTe9PjBHGg5a648iM wQAqLLEy6zCuP57U7gwLz1fJpyutpqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqF90-0000Y9-9H; Tue, 21 Mar 2017 08:27:54 +0000 Received: from regular1.263xmail.com ([211.150.99.137]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqF8i-0000Jj-3E; Tue, 21 Mar 2017 08:27:37 +0000 Received: from nickey.yang?rock-chips.com (unknown [192.168.167.193]) by regular1.263xmail.com (Postfix) with ESMTP id DD1A8DC64; Tue, 21 Mar 2017 16:27:09 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.263.net (Postfix) with ESMTP id B9EE1420; Tue, 21 Mar 2017 16:27:09 +0800 (CST) X-RL-SENDER: nickey.yang@rock-chips.com X-FST-TO: ck.hu@mediatek.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: nickey.yang@rock-chips.com X-UNIQUE-TAG: <5060034416fb52dff7f6ef8cd0ee63c1> X-ATTACHMENT-NUM: 0 X-SENDER: nickey.yang@rock-chips.com X-DNS-TYPE: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (Postfix) whith ESMTP id 9710OQW7XZ; Tue, 21 Mar 2017 16:27:11 +0800 (CST) From: Nickey Yang To: ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, matthias.bgg@gmail.com Subject: [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake Date: Tue, 21 Mar 2017 16:27:03 +0800 Message-Id: <1490084823-3968-1-git-send-email-nickey.yang@rock-chips.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170321_012736_528485_085D9A6E X-CRM114-Status: UNSURE ( 7.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: junzhi.zhao@mediatek.com, jie.qiu@mediatek.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nickey Yang , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP mtk_hdmi_setup_vendor_specific_infoframe will return before handle mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack returns the number of bytes packed into the binary buffer or a negative error code on failure. So correct it. Signed-off-by: Nickey Yang --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index c262512..b43aa29 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1062,7 +1062,7 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi, } err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer)); - if (err) { + if (err < 0) { dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n", err); return err;