| Message ID | 1508746897-62291-2-git-send-email-xiaolei.li@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 23 Oct 2017 16:21:36 +0800 Xiaolei Li <xiaolei.li@mediatek.com> wrote: > There will disable ECC IRQ in ECC IRQ handle function, so no need to > disable it again in the function mtk_ecc_disable. > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > --- > drivers/mtd/nand/mtk_ecc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c > index 7f3b065..82aa6f2 100644 > --- a/drivers/mtd/nand/mtk_ecc.c > +++ b/drivers/mtd/nand/mtk_ecc.c > @@ -307,7 +307,6 @@ void mtk_ecc_disable(struct mtk_ecc *ecc) > > /* disable it */ > mtk_ecc_wait_idle(ecc, op); > - writew(0, ecc->regs + ECC_IRQ_REG(op)); As explained in my review of patch 2, I would do it the other way around: remove this write from the irq handler and keep it here. > writew(ECC_OP_DISABLE, ecc->regs + ECC_CTL_REG(op)); > > mutex_unlock(&ecc->lock);
diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c index 7f3b065..82aa6f2 100644 --- a/drivers/mtd/nand/mtk_ecc.c +++ b/drivers/mtd/nand/mtk_ecc.c @@ -307,7 +307,6 @@ void mtk_ecc_disable(struct mtk_ecc *ecc) /* disable it */ mtk_ecc_wait_idle(ecc, op); - writew(0, ecc->regs + ECC_IRQ_REG(op)); writew(ECC_OP_DISABLE, ecc->regs + ECC_CTL_REG(op)); mutex_unlock(&ecc->lock);
There will disable ECC IRQ in ECC IRQ handle function, so no need to disable it again in the function mtk_ecc_disable. Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> --- drivers/mtd/nand/mtk_ecc.c | 1 - 1 file changed, 1 deletion(-)